diff options
author | Jingoo Han <jg1.han@samsung.com> | 2013-05-27 15:01:12 -0400 |
---|---|---|
committer | Nitin Garg <nitin.garg@freescale.com> | 2014-04-16 09:00:58 -0400 |
commit | 02bc78392ad28562b0ce8f84a2cfd85f7b0b6890 (patch) | |
tree | ebb6387df9796965398cee5f0eca34d03b272d1f /drivers/net/ethernet/marvell | |
parent | 05c2d40bf9ffcbc386ea7c09a12c9b45e965bc15 (diff) |
net: ethernet: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Rob Herring <rob.herring@calxeda.com>
Acked-by: Roland Stigge <stigge@antcom.de>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Tested-by: Roland Stigge <stigge@antcom.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/marvell')
-rw-r--r-- | drivers/net/ethernet/marvell/mv643xx_eth.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/marvell/mvneta.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/marvell/pxa168_eth.c | 1 |
3 files changed, 0 insertions, 5 deletions
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index 4be11ff516a0..078c6a795821 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c | |||
@@ -2811,8 +2811,6 @@ static int mv643xx_eth_remove(struct platform_device *pdev) | |||
2811 | 2811 | ||
2812 | free_netdev(mp->dev); | 2812 | free_netdev(mp->dev); |
2813 | 2813 | ||
2814 | platform_set_drvdata(pdev, NULL); | ||
2815 | |||
2816 | return 0; | 2814 | return 0; |
2817 | } | 2815 | } |
2818 | 2816 | ||
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 254f255204f9..a8329ea24e5a 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c | |||
@@ -2815,8 +2815,6 @@ static int mvneta_remove(struct platform_device *pdev) | |||
2815 | irq_dispose_mapping(dev->irq); | 2815 | irq_dispose_mapping(dev->irq); |
2816 | free_netdev(dev); | 2816 | free_netdev(dev); |
2817 | 2817 | ||
2818 | platform_set_drvdata(pdev, NULL); | ||
2819 | |||
2820 | return 0; | 2818 | return 0; |
2821 | } | 2819 | } |
2822 | 2820 | ||
diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index 1c8af8ba08d9..462b755e239c 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c | |||
@@ -1602,7 +1602,6 @@ static int pxa168_eth_remove(struct platform_device *pdev) | |||
1602 | unregister_netdev(dev); | 1602 | unregister_netdev(dev); |
1603 | cancel_work_sync(&pep->tx_timeout_task); | 1603 | cancel_work_sync(&pep->tx_timeout_task); |
1604 | free_netdev(dev); | 1604 | free_netdev(dev); |
1605 | platform_set_drvdata(pdev, NULL); | ||
1606 | return 0; | 1605 | return 0; |
1607 | } | 1606 | } |
1608 | 1607 | ||