diff options
author | Alexander Duyck <alexander.h.duyck@intel.com> | 2011-08-26 03:46:45 -0400 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2011-10-13 01:46:13 -0400 |
commit | c74d588e2addd9a13cca49a4d9172e0e2948448f (patch) | |
tree | 0e181edbadb51947dde88eaef6f0e8d751088a89 /drivers/net/ethernet/intel/igb/igb_main.c | |
parent | 0d1ae7f46f1b51623bed2904576d15f6ecd5dc10 (diff) |
igb: Make certain one vector is always assigned in igb_request_irq
This change makes certain that one interrupt is always initialized in
igb_request_irq. In addition we drop the use of adapter->pdev and
instead just call pdev since we made a local copy of the pointer earlier in
the function.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/igb/igb_main.c')
-rw-r--r-- | drivers/net/ethernet/intel/igb/igb_main.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 3905a499a591..efc367bddc47 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c | |||
@@ -1262,7 +1262,7 @@ static int igb_request_irq(struct igb_adapter *adapter) | |||
1262 | goto request_done; | 1262 | goto request_done; |
1263 | /* fall back to MSI */ | 1263 | /* fall back to MSI */ |
1264 | igb_clear_interrupt_scheme(adapter); | 1264 | igb_clear_interrupt_scheme(adapter); |
1265 | if (!pci_enable_msi(adapter->pdev)) | 1265 | if (!pci_enable_msi(pdev)) |
1266 | adapter->flags |= IGB_FLAG_HAS_MSI; | 1266 | adapter->flags |= IGB_FLAG_HAS_MSI; |
1267 | igb_free_all_tx_resources(adapter); | 1267 | igb_free_all_tx_resources(adapter); |
1268 | igb_free_all_rx_resources(adapter); | 1268 | igb_free_all_rx_resources(adapter); |
@@ -1284,12 +1284,12 @@ static int igb_request_irq(struct igb_adapter *adapter) | |||
1284 | } | 1284 | } |
1285 | igb_setup_all_tx_resources(adapter); | 1285 | igb_setup_all_tx_resources(adapter); |
1286 | igb_setup_all_rx_resources(adapter); | 1286 | igb_setup_all_rx_resources(adapter); |
1287 | } else { | ||
1288 | igb_assign_vector(adapter->q_vector[0], 0); | ||
1289 | } | 1287 | } |
1290 | 1288 | ||
1289 | igb_assign_vector(adapter->q_vector[0], 0); | ||
1290 | |||
1291 | if (adapter->flags & IGB_FLAG_HAS_MSI) { | 1291 | if (adapter->flags & IGB_FLAG_HAS_MSI) { |
1292 | err = request_irq(adapter->pdev->irq, igb_intr_msi, 0, | 1292 | err = request_irq(pdev->irq, igb_intr_msi, 0, |
1293 | netdev->name, adapter); | 1293 | netdev->name, adapter); |
1294 | if (!err) | 1294 | if (!err) |
1295 | goto request_done; | 1295 | goto request_done; |
@@ -1299,11 +1299,11 @@ static int igb_request_irq(struct igb_adapter *adapter) | |||
1299 | adapter->flags &= ~IGB_FLAG_HAS_MSI; | 1299 | adapter->flags &= ~IGB_FLAG_HAS_MSI; |
1300 | } | 1300 | } |
1301 | 1301 | ||
1302 | err = request_irq(adapter->pdev->irq, igb_intr, IRQF_SHARED, | 1302 | err = request_irq(pdev->irq, igb_intr, IRQF_SHARED, |
1303 | netdev->name, adapter); | 1303 | netdev->name, adapter); |
1304 | 1304 | ||
1305 | if (err) | 1305 | if (err) |
1306 | dev_err(&adapter->pdev->dev, "Error %d getting interrupt\n", | 1306 | dev_err(&pdev->dev, "Error %d getting interrupt\n", |
1307 | err); | 1307 | err); |
1308 | 1308 | ||
1309 | request_done: | 1309 | request_done: |