aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/can/usb
diff options
context:
space:
mode:
authorWolfgang Grandegger <wg@grandegger.com>2012-02-01 05:02:05 -0500
committerMarc Kleine-Budde <mkl@pengutronix.de>2012-02-02 19:21:26 -0500
commitaabdfd6adb804d0aaba0188ade0f1afe42a52e31 (patch)
treeb329ab5b070c5340f60bc1d125e1655d340ee457 /drivers/net/can/usb
parent79d0d8a7d5edca459f544c2ad75088e99307795e (diff)
can: replace the dev_dbg/info/err/... with the new netdev_xxx macros
Cc: uclinux-dist-devel@blackfin.uclinux.org Cc: Anant Gole <anantgole@ti.com> Cc: Chris Elston <celston@katalix.com> Cc: Sebastian Haas <haas@ems-wuensche.com> Cc: Matthias Fuchs <matthias.fuchs@esd.eu> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com> Acked-by: Sebastian Haas <dev@sebastianhaas.info> Acked-by: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can/usb')
-rw-r--r--drivers/net/can/usb/ems_usb.c57
-rw-r--r--drivers/net/can/usb/esd_usb2.c27
2 files changed, 35 insertions, 49 deletions
diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
index 9783e02fbc26..7ae65fc80032 100644
--- a/drivers/net/can/usb/ems_usb.c
+++ b/drivers/net/can/usb/ems_usb.c
@@ -288,8 +288,7 @@ static void ems_usb_read_interrupt_callback(struct urb *urb)
288 return; 288 return;
289 289
290 default: 290 default:
291 dev_info(netdev->dev.parent, "Rx interrupt aborted %d\n", 291 netdev_info(netdev, "Rx interrupt aborted %d\n", urb->status);
292 urb->status);
293 break; 292 break;
294 } 293 }
295 294
@@ -298,8 +297,7 @@ static void ems_usb_read_interrupt_callback(struct urb *urb)
298 if (err == -ENODEV) 297 if (err == -ENODEV)
299 netif_device_detach(netdev); 298 netif_device_detach(netdev);
300 else if (err) 299 else if (err)
301 dev_err(netdev->dev.parent, 300 netdev_err(netdev, "failed resubmitting intr urb: %d\n", err);
302 "failed resubmitting intr urb: %d\n", err);
303} 301}
304 302
305static void ems_usb_rx_can_msg(struct ems_usb *dev, struct ems_cpc_msg *msg) 303static void ems_usb_rx_can_msg(struct ems_usb *dev, struct ems_cpc_msg *msg)
@@ -431,8 +429,7 @@ static void ems_usb_read_bulk_callback(struct urb *urb)
431 return; 429 return;
432 430
433 default: 431 default:
434 dev_info(netdev->dev.parent, "Rx URB aborted (%d)\n", 432 netdev_info(netdev, "Rx URB aborted (%d)\n", urb->status);
435 urb->status);
436 goto resubmit_urb; 433 goto resubmit_urb;
437 } 434 }
438 435
@@ -477,7 +474,7 @@ static void ems_usb_read_bulk_callback(struct urb *urb)
477 msg_count--; 474 msg_count--;
478 475
479 if (start > urb->transfer_buffer_length) { 476 if (start > urb->transfer_buffer_length) {
480 dev_err(netdev->dev.parent, "format error\n"); 477 netdev_err(netdev, "format error\n");
481 break; 478 break;
482 } 479 }
483 } 480 }
@@ -493,8 +490,8 @@ resubmit_urb:
493 if (retval == -ENODEV) 490 if (retval == -ENODEV)
494 netif_device_detach(netdev); 491 netif_device_detach(netdev);
495 else if (retval) 492 else if (retval)
496 dev_err(netdev->dev.parent, 493 netdev_err(netdev,
497 "failed resubmitting read bulk urb: %d\n", retval); 494 "failed resubmitting read bulk urb: %d\n", retval);
498} 495}
499 496
500/* 497/*
@@ -521,8 +518,7 @@ static void ems_usb_write_bulk_callback(struct urb *urb)
521 return; 518 return;
522 519
523 if (urb->status) 520 if (urb->status)
524 dev_info(netdev->dev.parent, "Tx URB aborted (%d)\n", 521 netdev_info(netdev, "Tx URB aborted (%d)\n", urb->status);
525 urb->status);
526 522
527 netdev->trans_start = jiffies; 523 netdev->trans_start = jiffies;
528 524
@@ -605,8 +601,7 @@ static int ems_usb_start(struct ems_usb *dev)
605 /* create a URB, and a buffer for it */ 601 /* create a URB, and a buffer for it */
606 urb = usb_alloc_urb(0, GFP_KERNEL); 602 urb = usb_alloc_urb(0, GFP_KERNEL);
607 if (!urb) { 603 if (!urb) {
608 dev_err(netdev->dev.parent, 604 netdev_err(netdev, "No memory left for URBs\n");
609 "No memory left for URBs\n");
610 err = -ENOMEM; 605 err = -ENOMEM;
611 break; 606 break;
612 } 607 }
@@ -614,8 +609,7 @@ static int ems_usb_start(struct ems_usb *dev)
614 buf = usb_alloc_coherent(dev->udev, RX_BUFFER_SIZE, GFP_KERNEL, 609 buf = usb_alloc_coherent(dev->udev, RX_BUFFER_SIZE, GFP_KERNEL,
615 &urb->transfer_dma); 610 &urb->transfer_dma);
616 if (!buf) { 611 if (!buf) {
617 dev_err(netdev->dev.parent, 612 netdev_err(netdev, "No memory left for USB buffer\n");
618 "No memory left for USB buffer\n");
619 usb_free_urb(urb); 613 usb_free_urb(urb);
620 err = -ENOMEM; 614 err = -ENOMEM;
621 break; 615 break;
@@ -641,13 +635,13 @@ static int ems_usb_start(struct ems_usb *dev)
641 635
642 /* Did we submit any URBs */ 636 /* Did we submit any URBs */
643 if (i == 0) { 637 if (i == 0) {
644 dev_warn(netdev->dev.parent, "couldn't setup read URBs\n"); 638 netdev_warn(netdev, "couldn't setup read URBs\n");
645 return err; 639 return err;
646 } 640 }
647 641
648 /* Warn if we've couldn't transmit all the URBs */ 642 /* Warn if we've couldn't transmit all the URBs */
649 if (i < MAX_RX_URBS) 643 if (i < MAX_RX_URBS)
650 dev_warn(netdev->dev.parent, "rx performance may be slow\n"); 644 netdev_warn(netdev, "rx performance may be slow\n");
651 645
652 /* Setup and start interrupt URB */ 646 /* Setup and start interrupt URB */
653 usb_fill_int_urb(dev->intr_urb, dev->udev, 647 usb_fill_int_urb(dev->intr_urb, dev->udev,
@@ -658,8 +652,7 @@ static int ems_usb_start(struct ems_usb *dev)
658 652
659 err = usb_submit_urb(dev->intr_urb, GFP_KERNEL); 653 err = usb_submit_urb(dev->intr_urb, GFP_KERNEL);
660 if (err) { 654 if (err) {
661 dev_warn(netdev->dev.parent, "intr URB submit failed: %d\n", 655 netdev_warn(netdev, "intr URB submit failed: %d\n", err);
662 err);
663 656
664 return err; 657 return err;
665 } 658 }
@@ -688,7 +681,7 @@ static int ems_usb_start(struct ems_usb *dev)
688 return 0; 681 return 0;
689 682
690failed: 683failed:
691 dev_warn(netdev->dev.parent, "couldn't submit control: %d\n", err); 684 netdev_warn(netdev, "couldn't submit control: %d\n", err);
692 685
693 return err; 686 return err;
694} 687}
@@ -728,8 +721,7 @@ static int ems_usb_open(struct net_device *netdev)
728 if (err == -ENODEV) 721 if (err == -ENODEV)
729 netif_device_detach(dev->netdev); 722 netif_device_detach(dev->netdev);
730 723
731 dev_warn(netdev->dev.parent, "couldn't start device: %d\n", 724 netdev_warn(netdev, "couldn't start device: %d\n", err);
732 err);
733 725
734 close_candev(netdev); 726 close_candev(netdev);
735 727
@@ -762,13 +754,13 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne
762 /* create a URB, and a buffer for it, and copy the data to the URB */ 754 /* create a URB, and a buffer for it, and copy the data to the URB */
763 urb = usb_alloc_urb(0, GFP_ATOMIC); 755 urb = usb_alloc_urb(0, GFP_ATOMIC);
764 if (!urb) { 756 if (!urb) {
765 dev_err(netdev->dev.parent, "No memory left for URBs\n"); 757 netdev_err(netdev, "No memory left for URBs\n");
766 goto nomem; 758 goto nomem;
767 } 759 }
768 760
769 buf = usb_alloc_coherent(dev->udev, size, GFP_ATOMIC, &urb->transfer_dma); 761 buf = usb_alloc_coherent(dev->udev, size, GFP_ATOMIC, &urb->transfer_dma);
770 if (!buf) { 762 if (!buf) {
771 dev_err(netdev->dev.parent, "No memory left for USB buffer\n"); 763 netdev_err(netdev, "No memory left for USB buffer\n");
772 usb_free_urb(urb); 764 usb_free_urb(urb);
773 goto nomem; 765 goto nomem;
774 } 766 }
@@ -811,7 +803,7 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne
811 usb_unanchor_urb(urb); 803 usb_unanchor_urb(urb);
812 usb_free_coherent(dev->udev, size, buf, urb->transfer_dma); 804 usb_free_coherent(dev->udev, size, buf, urb->transfer_dma);
813 805
814 dev_warn(netdev->dev.parent, "couldn't find free context\n"); 806 netdev_warn(netdev, "couldn't find free context\n");
815 807
816 return NETDEV_TX_BUSY; 808 return NETDEV_TX_BUSY;
817 } 809 }
@@ -842,7 +834,7 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne
842 if (err == -ENODEV) { 834 if (err == -ENODEV) {
843 netif_device_detach(netdev); 835 netif_device_detach(netdev);
844 } else { 836 } else {
845 dev_warn(netdev->dev.parent, "failed tx_urb %d\n", err); 837 netdev_warn(netdev, "failed tx_urb %d\n", err);
846 838
847 stats->tx_dropped++; 839 stats->tx_dropped++;
848 } 840 }
@@ -882,7 +874,7 @@ static int ems_usb_close(struct net_device *netdev)
882 874
883 /* Set CAN controller to reset mode */ 875 /* Set CAN controller to reset mode */
884 if (ems_usb_write_mode(dev, SJA1000_MOD_RM)) 876 if (ems_usb_write_mode(dev, SJA1000_MOD_RM))
885 dev_warn(netdev->dev.parent, "couldn't stop device"); 877 netdev_warn(netdev, "couldn't stop device");
886 878
887 close_candev(netdev); 879 close_candev(netdev);
888 880
@@ -919,7 +911,7 @@ static int ems_usb_set_mode(struct net_device *netdev, enum can_mode mode)
919 switch (mode) { 911 switch (mode) {
920 case CAN_MODE_START: 912 case CAN_MODE_START:
921 if (ems_usb_write_mode(dev, SJA1000_MOD_NORMAL)) 913 if (ems_usb_write_mode(dev, SJA1000_MOD_NORMAL))
922 dev_warn(netdev->dev.parent, "couldn't start device"); 914 netdev_warn(netdev, "couldn't start device");
923 915
924 if (netif_queue_stopped(netdev)) 916 if (netif_queue_stopped(netdev))
925 netif_wake_queue(netdev); 917 netif_wake_queue(netdev);
@@ -944,8 +936,7 @@ static int ems_usb_set_bittiming(struct net_device *netdev)
944 if (dev->can.ctrlmode & CAN_CTRLMODE_3_SAMPLES) 936 if (dev->can.ctrlmode & CAN_CTRLMODE_3_SAMPLES)
945 btr1 |= 0x80; 937 btr1 |= 0x80;
946 938
947 dev_info(netdev->dev.parent, "setting BTR0=0x%02x BTR1=0x%02x\n", 939 netdev_info(netdev, "setting BTR0=0x%02x BTR1=0x%02x\n", btr0, btr1);
948 btr0, btr1);
949 940
950 dev->active_params.msg.can_params.cc_params.sja1000.btr0 = btr0; 941 dev->active_params.msg.can_params.cc_params.sja1000.btr0 = btr0;
951 dev->active_params.msg.can_params.cc_params.sja1000.btr1 = btr1; 942 dev->active_params.msg.can_params.cc_params.sja1000.btr1 = btr1;
@@ -1050,15 +1041,13 @@ static int ems_usb_probe(struct usb_interface *intf,
1050 1041
1051 err = ems_usb_command_msg(dev, &dev->active_params); 1042 err = ems_usb_command_msg(dev, &dev->active_params);
1052 if (err) { 1043 if (err) {
1053 dev_err(netdev->dev.parent, 1044 netdev_err(netdev, "couldn't initialize controller: %d\n", err);
1054 "couldn't initialize controller: %d\n", err);
1055 goto cleanup_tx_msg_buffer; 1045 goto cleanup_tx_msg_buffer;
1056 } 1046 }
1057 1047
1058 err = register_candev(netdev); 1048 err = register_candev(netdev);
1059 if (err) { 1049 if (err) {
1060 dev_err(netdev->dev.parent, 1050 netdev_err(netdev, "couldn't register CAN device: %d\n", err);
1061 "couldn't register CAN device: %d\n", err);
1062 goto cleanup_tx_msg_buffer; 1051 goto cleanup_tx_msg_buffer;
1063 } 1052 }
1064 1053
diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
index 92774637aad8..09b1da5bc512 100644
--- a/drivers/net/can/usb/esd_usb2.c
+++ b/drivers/net/can/usb/esd_usb2.c
@@ -470,8 +470,7 @@ static void esd_usb2_write_bulk_callback(struct urb *urb)
470 return; 470 return;
471 471
472 if (urb->status) 472 if (urb->status)
473 dev_info(netdev->dev.parent, "Tx URB aborted (%d)\n", 473 netdev_info(netdev, "Tx URB aborted (%d)\n", urb->status);
474 urb->status);
475 474
476 netdev->trans_start = jiffies; 475 netdev->trans_start = jiffies;
477} 476}
@@ -651,7 +650,7 @@ failed:
651 if (err == -ENODEV) 650 if (err == -ENODEV)
652 netif_device_detach(netdev); 651 netif_device_detach(netdev);
653 652
654 dev_err(netdev->dev.parent, "couldn't start device: %d\n", err); 653 netdev_err(netdev, "couldn't start device: %d\n", err);
655 654
656 return err; 655 return err;
657} 656}
@@ -687,8 +686,7 @@ static int esd_usb2_open(struct net_device *netdev)
687 /* finally start device */ 686 /* finally start device */
688 err = esd_usb2_start(priv); 687 err = esd_usb2_start(priv);
689 if (err) { 688 if (err) {
690 dev_warn(netdev->dev.parent, 689 netdev_warn(netdev, "couldn't start device: %d\n", err);
691 "couldn't start device: %d\n", err);
692 close_candev(netdev); 690 close_candev(netdev);
693 return err; 691 return err;
694 } 692 }
@@ -721,7 +719,7 @@ static netdev_tx_t esd_usb2_start_xmit(struct sk_buff *skb,
721 /* create a URB, and a buffer for it, and copy the data to the URB */ 719 /* create a URB, and a buffer for it, and copy the data to the URB */
722 urb = usb_alloc_urb(0, GFP_ATOMIC); 720 urb = usb_alloc_urb(0, GFP_ATOMIC);
723 if (!urb) { 721 if (!urb) {
724 dev_err(netdev->dev.parent, "No memory left for URBs\n"); 722 netdev_err(netdev, "No memory left for URBs\n");
725 stats->tx_dropped++; 723 stats->tx_dropped++;
726 dev_kfree_skb(skb); 724 dev_kfree_skb(skb);
727 goto nourbmem; 725 goto nourbmem;
@@ -730,7 +728,7 @@ static netdev_tx_t esd_usb2_start_xmit(struct sk_buff *skb,
730 buf = usb_alloc_coherent(dev->udev, size, GFP_ATOMIC, 728 buf = usb_alloc_coherent(dev->udev, size, GFP_ATOMIC,
731 &urb->transfer_dma); 729 &urb->transfer_dma);
732 if (!buf) { 730 if (!buf) {
733 dev_err(netdev->dev.parent, "No memory left for USB buffer\n"); 731 netdev_err(netdev, "No memory left for USB buffer\n");
734 stats->tx_dropped++; 732 stats->tx_dropped++;
735 dev_kfree_skb(skb); 733 dev_kfree_skb(skb);
736 goto nobufmem; 734 goto nobufmem;
@@ -766,7 +764,7 @@ static netdev_tx_t esd_usb2_start_xmit(struct sk_buff *skb,
766 * This may never happen. 764 * This may never happen.
767 */ 765 */
768 if (!context) { 766 if (!context) {
769 dev_warn(netdev->dev.parent, "couldn't find free context\n"); 767 netdev_warn(netdev, "couldn't find free context\n");
770 ret = NETDEV_TX_BUSY; 768 ret = NETDEV_TX_BUSY;
771 goto releasebuf; 769 goto releasebuf;
772 } 770 }
@@ -806,7 +804,7 @@ static netdev_tx_t esd_usb2_start_xmit(struct sk_buff *skb,
806 if (err == -ENODEV) 804 if (err == -ENODEV)
807 netif_device_detach(netdev); 805 netif_device_detach(netdev);
808 else 806 else
809 dev_warn(netdev->dev.parent, "failed tx_urb %d\n", err); 807 netdev_warn(netdev, "failed tx_urb %d\n", err);
810 808
811 goto releasebuf; 809 goto releasebuf;
812 } 810 }
@@ -845,7 +843,7 @@ static int esd_usb2_close(struct net_device *netdev)
845 for (i = 0; i <= ESD_MAX_ID_SEGMENT; i++) 843 for (i = 0; i <= ESD_MAX_ID_SEGMENT; i++)
846 msg.msg.filter.mask[i] = 0; 844 msg.msg.filter.mask[i] = 0;
847 if (esd_usb2_send_msg(priv->usb2, &msg) < 0) 845 if (esd_usb2_send_msg(priv->usb2, &msg) < 0)
848 dev_err(netdev->dev.parent, "sending idadd message failed\n"); 846 netdev_err(netdev, "sending idadd message failed\n");
849 847
850 /* set CAN controller to reset mode */ 848 /* set CAN controller to reset mode */
851 msg.msg.hdr.len = 2; 849 msg.msg.hdr.len = 2;
@@ -854,7 +852,7 @@ static int esd_usb2_close(struct net_device *netdev)
854 msg.msg.setbaud.rsvd = 0; 852 msg.msg.setbaud.rsvd = 0;
855 msg.msg.setbaud.baud = cpu_to_le32(ESD_USB2_NO_BAUDRATE); 853 msg.msg.setbaud.baud = cpu_to_le32(ESD_USB2_NO_BAUDRATE);
856 if (esd_usb2_send_msg(priv->usb2, &msg) < 0) 854 if (esd_usb2_send_msg(priv->usb2, &msg) < 0)
857 dev_err(netdev->dev.parent, "sending setbaud message failed\n"); 855 netdev_err(netdev, "sending setbaud message failed\n");
858 856
859 priv->can.state = CAN_STATE_STOPPED; 857 priv->can.state = CAN_STATE_STOPPED;
860 858
@@ -910,7 +908,7 @@ static int esd_usb2_set_bittiming(struct net_device *netdev)
910 msg.msg.setbaud.rsvd = 0; 908 msg.msg.setbaud.rsvd = 0;
911 msg.msg.setbaud.baud = cpu_to_le32(canbtr); 909 msg.msg.setbaud.baud = cpu_to_le32(canbtr);
912 910
913 dev_info(netdev->dev.parent, "setting BTR=%#x\n", canbtr); 911 netdev_info(netdev, "setting BTR=%#x\n", canbtr);
914 912
915 return esd_usb2_send_msg(priv->usb2, &msg); 913 return esd_usb2_send_msg(priv->usb2, &msg);
916} 914}
@@ -988,15 +986,14 @@ static int esd_usb2_probe_one_net(struct usb_interface *intf, int index)
988 986
989 err = register_candev(netdev); 987 err = register_candev(netdev);
990 if (err) { 988 if (err) {
991 dev_err(&intf->dev, 989 dev_err(&intf->dev, "couldn't register CAN device: %d\n", err);
992 "couldn't register CAN device: %d\n", err);
993 free_candev(netdev); 990 free_candev(netdev);
994 err = -ENOMEM; 991 err = -ENOMEM;
995 goto done; 992 goto done;
996 } 993 }
997 994
998 dev->nets[index] = priv; 995 dev->nets[index] = priv;
999 dev_info(netdev->dev.parent, "device %s registered\n", netdev->name); 996 netdev_info(netdev, "device %s registered\n", netdev->name);
1000 997
1001done: 998done:
1002 return err; 999 return err;