aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mmc
diff options
context:
space:
mode:
authorDaniel Drake <dsd@laptop.org>2011-07-20 12:39:22 -0400
committerChris Ball <cjb@laptop.org>2011-10-26 15:43:35 -0400
commit08da834a24312157f512224691ad1fddd11c1073 (patch)
tree6ed587d6a7937c792085bf9fc9765ce1c6a63ed9 /drivers/mmc
parent1e4cb22bb5094def8eb5c3893f9dda2d517d29bb (diff)
mmc: enable runtime PM by default
Now that we have improved the runtime power management powerup/powerdown code, we believe that MMC_CAP_POWER_OFF_CARD is no longer necessary: runtime PM should now work everywhere. The only hard evidence for introducing MMC_CAP_POWER_OFF_CARD was the Marvell sd8686 wifi chip, which was believed to require external gpio manipulation which wasn't supported by some boards. After further investigation it was realized (and confirmed by Marvell folks) that sd8686 requirements can be fulfilled by changing the reset sequence itself, even if no external gpio is manipulated. For further information, see the following thread: http://www.mail-archive.com/linux-mmc@vger.kernel.org/msg04289.html Enable this trivially for a release or two. If no problems are reported, we will follow up with a more extensive patch to remove this flag altogether. If problems are reported, we can look at whitelist/blacklist possibilities as before. Signed-off-by: Daniel Drake <dsd@laptop.org> Acked-by: Ohad Ben-Cohen <ohad@wizery.com> Signed-off-by: Chris Ball <cjb@laptop.org>
Diffstat (limited to 'drivers/mmc')
-rw-r--r--drivers/mmc/core/host.c11
1 files changed, 11 insertions, 0 deletions
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 793d0a0dad8d..ca2e4f50f615 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -301,6 +301,17 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
301 host->max_blk_size = 512; 301 host->max_blk_size = 512;
302 host->max_blk_count = PAGE_CACHE_SIZE / 512; 302 host->max_blk_count = PAGE_CACHE_SIZE / 512;
303 303
304 /*
305 * Enable runtime power management by default. This flag was added due
306 * to runtime power management causing disruption for some users, but
307 * the power on/off code has been improved since then.
308 *
309 * We'll enable this flag by default as an experiment, and if no
310 * problems are reported, we will follow up later and remove the flag
311 * altogether.
312 */
313 host->caps = MMC_CAP_POWER_OFF_CARD;
314
304 return host; 315 return host;
305 316
306free: 317free: