diff options
author | Egbert Eich <eich@suse.de> | 2013-02-25 12:06:52 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-03-27 12:13:43 -0400 |
commit | 4f770a5bee04566e63f3a826a15c24bccaa124e8 (patch) | |
tree | ccc62178ae196cc5b00703d21bc1b8af5751507f /drivers/gpu/drm | |
parent | bac56d5b9535f16409b294d92ecc01c354059b41 (diff) |
DRM/i915: Get rid if the 'hotplug_supported_mask' in struct drm_i915_private.
Now since we have replaced the bits to show interest in hotplug IRQs
we can go and nuke the 'hotplug_supported_mask'.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm')
-rw-r--r-- | drivers/gpu/drm/i915/i915_drv.h | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_crt.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_dp.c | 3 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_hdmi.c | 3 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_sdvo.c | 9 |
5 files changed, 3 insertions, 15 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index cda598d89f17..1d091ea12fad 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h | |||
@@ -922,7 +922,6 @@ typedef struct drm_i915_private { | |||
922 | u32 irq_mask; | 922 | u32 irq_mask; |
923 | u32 gt_irq_mask; | 923 | u32 gt_irq_mask; |
924 | 924 | ||
925 | u32 hotplug_supported_mask; | ||
926 | struct work_struct hotplug_work; | 925 | struct work_struct hotplug_work; |
927 | bool enable_hotplug_processing; | 926 | bool enable_hotplug_processing; |
928 | 927 | ||
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c index a4b3e4e01e65..756ae552e7e5 100644 --- a/drivers/gpu/drm/i915/intel_crt.c +++ b/drivers/gpu/drm/i915/intel_crt.c | |||
@@ -799,8 +799,6 @@ void intel_crt_init(struct drm_device *dev) | |||
799 | */ | 799 | */ |
800 | crt->force_hotplug_required = 0; | 800 | crt->force_hotplug_required = 0; |
801 | 801 | ||
802 | dev_priv->hotplug_supported_mask |= CRT_HOTPLUG_INT_STATUS; | ||
803 | |||
804 | /* | 802 | /* |
805 | * TODO: find a proper way to discover whether we need to set the the | 803 | * TODO: find a proper way to discover whether we need to set the the |
806 | * polarity and link reversal bits or not, instead of relying on the | 804 | * polarity and link reversal bits or not, instead of relying on the |
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index c7c5635f06e0..ad6bba3ba06a 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c | |||
@@ -2825,17 +2825,14 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, | |||
2825 | name = "DPDDC-A"; | 2825 | name = "DPDDC-A"; |
2826 | break; | 2826 | break; |
2827 | case PORT_B: | 2827 | case PORT_B: |
2828 | dev_priv->hotplug_supported_mask |= PORTB_HOTPLUG_INT_STATUS; | ||
2829 | intel_encoder->hpd_pin = HPD_PORT_B; | 2828 | intel_encoder->hpd_pin = HPD_PORT_B; |
2830 | name = "DPDDC-B"; | 2829 | name = "DPDDC-B"; |
2831 | break; | 2830 | break; |
2832 | case PORT_C: | 2831 | case PORT_C: |
2833 | dev_priv->hotplug_supported_mask |= PORTC_HOTPLUG_INT_STATUS; | ||
2834 | intel_encoder->hpd_pin = HPD_PORT_C; | 2832 | intel_encoder->hpd_pin = HPD_PORT_C; |
2835 | name = "DPDDC-C"; | 2833 | name = "DPDDC-C"; |
2836 | break; | 2834 | break; |
2837 | case PORT_D: | 2835 | case PORT_D: |
2838 | dev_priv->hotplug_supported_mask |= PORTD_HOTPLUG_INT_STATUS; | ||
2839 | intel_encoder->hpd_pin = HPD_PORT_D; | 2836 | intel_encoder->hpd_pin = HPD_PORT_D; |
2840 | name = "DPDDC-D"; | 2837 | name = "DPDDC-D"; |
2841 | break; | 2838 | break; |
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 6d92aebadfc3..b9a83d7c804b 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c | |||
@@ -989,17 +989,14 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, | |||
989 | case PORT_B: | 989 | case PORT_B: |
990 | intel_hdmi->ddc_bus = GMBUS_PORT_DPB; | 990 | intel_hdmi->ddc_bus = GMBUS_PORT_DPB; |
991 | intel_encoder->hpd_pin = HPD_PORT_B; | 991 | intel_encoder->hpd_pin = HPD_PORT_B; |
992 | dev_priv->hotplug_supported_mask |= PORTB_HOTPLUG_INT_STATUS; | ||
993 | break; | 992 | break; |
994 | case PORT_C: | 993 | case PORT_C: |
995 | intel_hdmi->ddc_bus = GMBUS_PORT_DPC; | 994 | intel_hdmi->ddc_bus = GMBUS_PORT_DPC; |
996 | intel_encoder->hpd_pin = HPD_PORT_C; | 995 | intel_encoder->hpd_pin = HPD_PORT_C; |
997 | dev_priv->hotplug_supported_mask |= PORTC_HOTPLUG_INT_STATUS; | ||
998 | break; | 996 | break; |
999 | case PORT_D: | 997 | case PORT_D: |
1000 | intel_hdmi->ddc_bus = GMBUS_PORT_DPD; | 998 | intel_hdmi->ddc_bus = GMBUS_PORT_DPD; |
1001 | intel_encoder->hpd_pin = HPD_PORT_D; | 999 | intel_encoder->hpd_pin = HPD_PORT_D; |
1002 | dev_priv->hotplug_supported_mask |= PORTD_HOTPLUG_INT_STATUS; | ||
1003 | break; | 1000 | break; |
1004 | case PORT_A: | 1001 | case PORT_A: |
1005 | intel_encoder->hpd_pin = HPD_PORT_A; | 1002 | intel_encoder->hpd_pin = HPD_PORT_A; |
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index 0ff557fe2f60..8fdd8f82f09d 100644 --- a/drivers/gpu/drm/i915/intel_sdvo.c +++ b/drivers/gpu/drm/i915/intel_sdvo.c | |||
@@ -2779,6 +2779,9 @@ bool intel_sdvo_init(struct drm_device *dev, uint32_t sdvo_reg, bool is_sdvob) | |||
2779 | SDVOB_HOTPLUG_INT_STATUS_I915 : SDVOC_HOTPLUG_INT_STATUS_I915; | 2779 | SDVOB_HOTPLUG_INT_STATUS_I915 : SDVOC_HOTPLUG_INT_STATUS_I915; |
2780 | } | 2780 | } |
2781 | 2781 | ||
2782 | /* Only enable the hotplug irq if we need it, to work around noisy | ||
2783 | * hotplug lines. | ||
2784 | */ | ||
2782 | if (intel_sdvo->hotplug_active) | 2785 | if (intel_sdvo->hotplug_active) |
2783 | intel_encoder->hpd_pin = HPD_SDVO_B ? HPD_SDVO_B : HPD_SDVO_C; | 2786 | intel_encoder->hpd_pin = HPD_SDVO_B ? HPD_SDVO_B : HPD_SDVO_C; |
2784 | 2787 | ||
@@ -2810,12 +2813,6 @@ bool intel_sdvo_init(struct drm_device *dev, uint32_t sdvo_reg, bool is_sdvob) | |||
2810 | */ | 2813 | */ |
2811 | intel_sdvo->base.cloneable = false; | 2814 | intel_sdvo->base.cloneable = false; |
2812 | 2815 | ||
2813 | /* Only enable the hotplug irq if we need it, to work around noisy | ||
2814 | * hotplug lines. | ||
2815 | */ | ||
2816 | if (intel_sdvo->hotplug_active) | ||
2817 | dev_priv->hotplug_supported_mask |= hotplug_mask; | ||
2818 | |||
2819 | intel_sdvo_select_ddc_bus(dev_priv, intel_sdvo, sdvo_reg); | 2816 | intel_sdvo_select_ddc_bus(dev_priv, intel_sdvo, sdvo_reg); |
2820 | 2817 | ||
2821 | /* Set the input timing to the screen. Assume always input 0. */ | 2818 | /* Set the input timing to the screen. Assume always input 0. */ |