aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/firewire/core-transaction.c
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2010-06-20 16:50:35 -0400
committerStefan Richter <stefanr@s5r6.in-berlin.de>2010-06-20 17:11:55 -0400
commit33e553fe2b4a983ef34a57ab1440d8d33397bb12 (patch)
tree3a7098a935f0b678a6e6a565619d0d990f9122f3 /drivers/firewire/core-transaction.c
parent56d04cb189f955e5167c27944d61aa57ad69b598 (diff)
firewire: remove an unused function argument
void (*fw_address_callback_t)(..., int speed, ...) is the speed that a remote node chose to transmit a request to us. In case of split transactions, firewire-core will transmit the response at that speed. Upper layer drivers on the other hand (firewire-net, -sbp2, firedtv, and userspace drivers) cannot do anything useful with that speed datum, except log it for debug purposes. But data that is merely potentially (not even actually) used for debug purposes does not belong into the API. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/core-transaction.c')
-rw-r--r--drivers/firewire/core-transaction.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/firewire/core-transaction.c b/drivers/firewire/core-transaction.c
index cb6390fe3686..2f67c8d5ce91 100644
--- a/drivers/firewire/core-transaction.c
+++ b/drivers/firewire/core-transaction.c
@@ -802,7 +802,7 @@ static void handle_exclusive_region_request(struct fw_card *card,
802 else 802 else
803 handler->address_callback(card, request, 803 handler->address_callback(card, request,
804 tcode, destination, source, 804 tcode, destination, source,
805 p->generation, p->speed, offset, 805 p->generation, offset,
806 request->data, request->length, 806 request->data, request->length,
807 handler->callback_data); 807 handler->callback_data);
808} 808}
@@ -840,8 +840,8 @@ static void handle_fcp_region_request(struct fw_card *card,
840 if (is_enclosing_handler(handler, offset, request->length)) 840 if (is_enclosing_handler(handler, offset, request->length))
841 handler->address_callback(card, NULL, tcode, 841 handler->address_callback(card, NULL, tcode,
842 destination, source, 842 destination, source,
843 p->generation, p->speed, 843 p->generation, offset,
844 offset, request->data, 844 request->data,
845 request->length, 845 request->length,
846 handler->callback_data); 846 handler->callback_data);
847 } 847 }
@@ -951,8 +951,8 @@ static const struct fw_address_region topology_map_region =
951 951
952static void handle_topology_map(struct fw_card *card, struct fw_request *request, 952static void handle_topology_map(struct fw_card *card, struct fw_request *request,
953 int tcode, int destination, int source, int generation, 953 int tcode, int destination, int source, int generation,
954 int speed, unsigned long long offset, 954 unsigned long long offset, void *payload, size_t length,
955 void *payload, size_t length, void *callback_data) 955 void *callback_data)
956{ 956{
957 int start; 957 int start;
958 958
@@ -996,8 +996,8 @@ static void update_split_timeout(struct fw_card *card)
996 996
997static void handle_registers(struct fw_card *card, struct fw_request *request, 997static void handle_registers(struct fw_card *card, struct fw_request *request,
998 int tcode, int destination, int source, int generation, 998 int tcode, int destination, int source, int generation,
999 int speed, unsigned long long offset, 999 unsigned long long offset, void *payload, size_t length,
1000 void *payload, size_t length, void *callback_data) 1000 void *callback_data)
1001{ 1001{
1002 int reg = offset & ~CSR_REGISTER_BASE; 1002 int reg = offset & ~CSR_REGISTER_BASE;
1003 __be32 *data = payload; 1003 __be32 *data = payload;