diff options
author | Dominik Brodowski <linux@dominikbrodowski.net> | 2009-11-08 11:24:46 -0500 |
---|---|---|
committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2009-11-28 12:03:14 -0500 |
commit | 5fa9167a1bf5f5a4b7282f5e7ac56a4a5a1fa044 (patch) | |
tree | 2bf23e13308ef683302ff5a92af0ae8bc37c1b60 /drivers/char/pcmcia/ipwireless/main.c | |
parent | dd2e5a156525f11754d9b1e0583f6bb49c253d62 (diff) |
pcmcia: rework the irq_req_t typedef
Most of the irq_req_t typedef'd struct can be re-worked quite
easily:
(1) IRQInfo2 was unused in any case, so drop it.
(2) IRQInfo1 was used write-only, so drop it.
(3) Instance (private data to be passed to the IRQ handler):
Most PCMCIA drivers using pcmcia_request_irq() to actually
register an IRQ handler set the "dev_id" to the same pointer
as the "priv" pointer in struct pcmcia_device. Modify the two
exceptions (ipwireless, ibmtr_cs) to also work this waym and
set the IRQ handler's "dev_id" to p_dev->priv unconditionally.
(4) Handler is to be of type irq_handler_t.
(5) Handler != NULL already tells whether an IRQ handler is present.
Therefore, we do not need the IRQ_HANDLER_PRESENT flag in
irq_req_t.Attributes.
CC: netdev@vger.kernel.org
CC: linux-bluetooth@vger.kernel.org
CC: linux-ide@vger.kernel.org
CC: linux-wireless@vger.kernel.org
CC: linux-scsi@vger.kernel.org
CC: alsa-devel@alsa-project.org
CC: Jaroslav Kysela <perex@perex.cz>
CC: Jiri Kosina <jkosina@suse.cz>
CC: Karsten Keil <isdn@linux-pingi.de>
for the Bluetooth parts: Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/char/pcmcia/ipwireless/main.c')
-rw-r--r-- | drivers/char/pcmcia/ipwireless/main.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/char/pcmcia/ipwireless/main.c b/drivers/char/pcmcia/ipwireless/main.c index 082146a26c87..dff24dae1485 100644 --- a/drivers/char/pcmcia/ipwireless/main.c +++ b/drivers/char/pcmcia/ipwireless/main.c | |||
@@ -93,8 +93,6 @@ static int ipwireless_probe(struct pcmcia_device *p_dev, | |||
93 | p_dev->io.NumPorts1 = cfg->io.win[0].len; | 93 | p_dev->io.NumPorts1 = cfg->io.win[0].len; |
94 | p_dev->io.IOAddrLines = 16; | 94 | p_dev->io.IOAddrLines = 16; |
95 | 95 | ||
96 | p_dev->irq.IRQInfo1 = cfg->irq.IRQInfo1; | ||
97 | |||
98 | /* 0x40 causes it to generate level mode interrupts. */ | 96 | /* 0x40 causes it to generate level mode interrupts. */ |
99 | /* 0x04 enables IREQ pin. */ | 97 | /* 0x04 enables IREQ pin. */ |
100 | p_dev->conf.ConfigIndex = cfg->index | 0x44; | 98 | p_dev->conf.ConfigIndex = cfg->index | 0x44; |
@@ -197,9 +195,8 @@ static int config_ipwireless(struct ipw_dev *ipw) | |||
197 | link->conf.Attributes = CONF_ENABLE_IRQ; | 195 | link->conf.Attributes = CONF_ENABLE_IRQ; |
198 | link->conf.IntType = INT_MEMORY_AND_IO; | 196 | link->conf.IntType = INT_MEMORY_AND_IO; |
199 | 197 | ||
200 | link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING | IRQ_HANDLE_PRESENT; | 198 | link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING; |
201 | link->irq.Handler = ipwireless_interrupt; | 199 | link->irq.Handler = ipwireless_interrupt; |
202 | link->irq.Instance = ipw->hardware; | ||
203 | 200 | ||
204 | INIT_WORK(&ipw->work_reboot, signalled_reboot_work); | 201 | INIT_WORK(&ipw->work_reboot, signalled_reboot_work); |
205 | 202 | ||
@@ -315,7 +312,6 @@ static int ipwireless_attach(struct pcmcia_device *link) | |||
315 | 312 | ||
316 | ipw->link = link; | 313 | ipw->link = link; |
317 | link->priv = ipw; | 314 | link->priv = ipw; |
318 | link->irq.Instance = ipw; | ||
319 | 315 | ||
320 | /* Link this device into our device list. */ | 316 | /* Link this device into our device list. */ |
321 | link->dev_node = &ipw->nodes[0]; | 317 | link->dev_node = &ipw->nodes[0]; |