aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata/libata-sff.c
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2011-04-15 18:51:58 -0400
committerJeff Garzik <jgarzik@pobox.com>2011-07-23 17:57:36 -0400
commita44fec1fce5d5d14cc3ac4545b8da346394de666 (patch)
treefa3d16a4c8f1a6a7e9af867f16f7201a5b5442f9 /drivers/ata/libata-sff.c
parent02f8c6aee8df3cdc935e9bdd4f2d020306035dbe (diff)
ata: Convert dev_printk(KERN_<LEVEL> to dev_<level>(
Saves a bit of text as the call takes fewer args. Coalesce a few formats. Convert a few bare printks to pr_cont. $ size drivers/ata/built-in.o* text data bss dec hex filename 558429 73893 117864 750186 b726a drivers/ata/built-in.o.allyesconfig.new 559574 73893 117888 751355 b76fb drivers/ata/built-in.o.allyesconfig.old 149567 14689 4220 168476 2921c drivers/ata/built-in.o.defconfig.new 149851 14689 4220 168760 29338 drivers/ata/built-in.o.defconfig.old Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/libata-sff.c')
-rw-r--r--drivers/ata/libata-sff.c20
1 files changed, 8 insertions, 12 deletions
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index b1b926c55a72..e01d5cfba68a 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -2316,9 +2316,9 @@ int ata_pci_sff_init_host(struct ata_host *host)
2316 rc = pcim_iomap_regions(pdev, 0x3 << base, 2316 rc = pcim_iomap_regions(pdev, 0x3 << base,
2317 dev_driver_string(gdev)); 2317 dev_driver_string(gdev));
2318 if (rc) { 2318 if (rc) {
2319 dev_printk(KERN_WARNING, gdev, 2319 dev_warn(gdev,
2320 "failed to request/iomap BARs for port %d " 2320 "failed to request/iomap BARs for port %d (errno=%d)\n",
2321 "(errno=%d)\n", i, rc); 2321 i, rc);
2322 if (rc == -EBUSY) 2322 if (rc == -EBUSY)
2323 pcim_pin_device(pdev); 2323 pcim_pin_device(pdev);
2324 ap->ops = &ata_dummy_port_ops; 2324 ap->ops = &ata_dummy_port_ops;
@@ -2340,7 +2340,7 @@ int ata_pci_sff_init_host(struct ata_host *host)
2340 } 2340 }
2341 2341
2342 if (!mask) { 2342 if (!mask) {
2343 dev_printk(KERN_ERR, gdev, "no available native port\n"); 2343 dev_err(gdev, "no available native port\n");
2344 return -ENODEV; 2344 return -ENODEV;
2345 } 2345 }
2346 2346
@@ -2375,8 +2375,7 @@ int ata_pci_sff_prepare_host(struct pci_dev *pdev,
2375 2375
2376 host = ata_host_alloc_pinfo(&pdev->dev, ppi, 2); 2376 host = ata_host_alloc_pinfo(&pdev->dev, ppi, 2);
2377 if (!host) { 2377 if (!host) {
2378 dev_printk(KERN_ERR, &pdev->dev, 2378 dev_err(&pdev->dev, "failed to allocate ATA host\n");
2379 "failed to allocate ATA host\n");
2380 rc = -ENOMEM; 2379 rc = -ENOMEM;
2381 goto err_out; 2380 goto err_out;
2382 } 2381 }
@@ -2542,8 +2541,7 @@ int ata_pci_sff_init_one(struct pci_dev *pdev,
2542 2541
2543 pi = ata_sff_find_valid_pi(ppi); 2542 pi = ata_sff_find_valid_pi(ppi);
2544 if (!pi) { 2543 if (!pi) {
2545 dev_printk(KERN_ERR, &pdev->dev, 2544 dev_err(&pdev->dev, "no valid port_info specified\n");
2546 "no valid port_info specified\n");
2547 return -EINVAL; 2545 return -EINVAL;
2548 } 2546 }
2549 2547
@@ -3164,8 +3162,7 @@ static void ata_bmdma_nodma(struct ata_host *host, const char *reason)
3164{ 3162{
3165 int i; 3163 int i;
3166 3164
3167 dev_printk(KERN_ERR, host->dev, "BMDMA: %s, falling back to PIO\n", 3165 dev_err(host->dev, "BMDMA: %s, falling back to PIO\n", reason);
3168 reason);
3169 3166
3170 for (i = 0; i < 2; i++) { 3167 for (i = 0; i < 2; i++) {
3171 host->ports[i]->mwdma_mask = 0; 3168 host->ports[i]->mwdma_mask = 0;
@@ -3297,8 +3294,7 @@ int ata_pci_bmdma_init_one(struct pci_dev *pdev,
3297 3294
3298 pi = ata_sff_find_valid_pi(ppi); 3295 pi = ata_sff_find_valid_pi(ppi);
3299 if (!pi) { 3296 if (!pi) {
3300 dev_printk(KERN_ERR, &pdev->dev, 3297 dev_err(&pdev->dev, "no valid port_info specified\n");
3301 "no valid port_info specified\n");
3302 return -EINVAL; 3298 return -EINVAL;
3303 } 3299 }
3304 3300