crypto: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 3 deletions

diff --git a/crypto/rng.c b/crypto/rng.c
index 64f864fa8043..f3b7894dec00 100644
--- a/crypto/rng.c
+++ b/crypto/rng.c
@@ -69,9 +69,9 @@ static int crypto_rng_report(struct sk_buff *skb, struct crypto_alg *alg)
 
         rrng.seedsize = alg->cra_rng.seedsize;
 
-        NLA_PUT(skb, CRYPTOCFGA_REPORT_RNG,
-                sizeof(struct crypto_report_rng), &rrng);
-
+        if (nla_put(skb, CRYPTOCFGA_REPORT_RNG,
+                    sizeof(struct crypto_report_rng), &rrng))
+                goto nla_put_failure;
         return 0;
 
 nla_put_failure: