crypto: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 6 insertions, 6 deletions

diff --git a/crypto/aead.c b/crypto/aead.c
index 04add3dca6fe..c772b9c79ee7 100644
--- a/crypto/aead.c
+++ b/crypto/aead.c
@@ -125,9 +125,9 @@ static int crypto_aead_report(struct sk_buff *skb, struct crypto_alg *alg)
         raead.maxauthsize = aead->maxauthsize;
         raead.ivsize = aead->ivsize;
 
-        NLA_PUT(skb, CRYPTOCFGA_REPORT_AEAD,
-                sizeof(struct crypto_report_aead), &raead);
-
+        if (nla_put(skb, CRYPTOCFGA_REPORT_AEAD,
+                    sizeof(struct crypto_report_aead), &raead))
+                goto nla_put_failure;
         return 0;
 
 nla_put_failure:
@@ -210,9 +210,9 @@ static int crypto_nivaead_report(struct sk_buff *skb, struct crypto_alg *alg)
         raead.maxauthsize = aead->maxauthsize;
         raead.ivsize = aead->ivsize;
 
-        NLA_PUT(skb, CRYPTOCFGA_REPORT_AEAD,
-                sizeof(struct crypto_report_aead), &raead);
-
+        if (nla_put(skb, CRYPTOCFGA_REPORT_AEAD,
+                    sizeof(struct crypto_report_aead), &raead))
+                goto nla_put_failure;
         return 0;
 
 nla_put_failure: