diff options
author | H. Peter Anvin <hpa@linux.intel.com> | 2011-12-15 17:55:53 -0500 |
---|---|---|
committer | H. Peter Anvin <hpa@linux.intel.com> | 2011-12-15 18:04:07 -0500 |
commit | 83d99df7c4bf37176d8c7b199e3b129a51fa04c8 (patch) | |
tree | bd5783c1be0c0b899726d061554efe010e98d459 /arch/x86 | |
parent | cebef5beed3de3037de85a521495897256b2c5da (diff) |
x86, bitops: Move fls64.h inside __KERNEL__
We would include <asm-generic/bitops/fls64.h> even without __KERNEL__,
but that doesn't make sense, as:
1. That file provides fls64(), but the corresponding function fls() is
not exported to user space.
2. The implementation of fls64.h uses kernel-only symbols.
3. fls64.h is not exported to user space.
This appears to have been a bug introduced in checkin:
d57594c203b1 bitops: use __fls for fls64 on 64-bit archs
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: Alexander van Heukelum <heukelum@mailshack.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Link: http://lkml.kernel.org/r/4EEA77E1.6050009@zytor.com
Diffstat (limited to 'arch/x86')
-rw-r--r-- | arch/x86/include/asm/bitops.h | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h index 1775d6e5920e..4a6235b053cb 100644 --- a/arch/x86/include/asm/bitops.h +++ b/arch/x86/include/asm/bitops.h | |||
@@ -380,6 +380,8 @@ static inline unsigned long __fls(unsigned long word) | |||
380 | return word; | 380 | return word; |
381 | } | 381 | } |
382 | 382 | ||
383 | #undef ADDR | ||
384 | |||
383 | #ifdef __KERNEL__ | 385 | #ifdef __KERNEL__ |
384 | /** | 386 | /** |
385 | * ffs - find first set bit in word | 387 | * ffs - find first set bit in word |
@@ -434,11 +436,6 @@ static inline int fls(int x) | |||
434 | #endif | 436 | #endif |
435 | return r + 1; | 437 | return r + 1; |
436 | } | 438 | } |
437 | #endif /* __KERNEL__ */ | ||
438 | |||
439 | #undef ADDR | ||
440 | |||
441 | #ifdef __KERNEL__ | ||
442 | 439 | ||
443 | #include <asm-generic/bitops/find.h> | 440 | #include <asm-generic/bitops/find.h> |
444 | 441 | ||
@@ -450,12 +447,8 @@ static inline int fls(int x) | |||
450 | 447 | ||
451 | #include <asm-generic/bitops/const_hweight.h> | 448 | #include <asm-generic/bitops/const_hweight.h> |
452 | 449 | ||
453 | #endif /* __KERNEL__ */ | ||
454 | |||
455 | #include <asm-generic/bitops/fls64.h> | 450 | #include <asm-generic/bitops/fls64.h> |
456 | 451 | ||
457 | #ifdef __KERNEL__ | ||
458 | |||
459 | #include <asm-generic/bitops/le.h> | 452 | #include <asm-generic/bitops/le.h> |
460 | 453 | ||
461 | #include <asm-generic/bitops/ext2-atomic-setbit.h> | 454 | #include <asm-generic/bitops/ext2-atomic-setbit.h> |