diff options
author | Michael Ellerman <michael@ellerman.id.au> | 2007-08-28 04:47:54 -0400 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2007-09-13 11:33:20 -0400 |
commit | 52964f87c64e6c6ea671b5bf3030fb1494090a48 (patch) | |
tree | 2e20d81bc05b60b7108733daf5713ea640ad2477 /arch/powerpc/platforms/cell | |
parent | 0ae0b54565a8dcc2b98de694b998e765de15b713 (diff) |
[POWERPC] Add an optional device_node pointer to the irq_host
The majority of irq_host implementations (3 out of 4) are associated
with a device_node, and need to stash it somewhere. Rather than having
it somewhere different for each host, add an optional device_node pointer
to the irq_host structure.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc/platforms/cell')
-rw-r--r-- | arch/powerpc/platforms/cell/axon_msi.c | 14 | ||||
-rw-r--r-- | arch/powerpc/platforms/cell/interrupt.c | 2 | ||||
-rw-r--r-- | arch/powerpc/platforms/cell/spider-pic.c | 18 |
3 files changed, 13 insertions, 21 deletions
diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c index 4c9ab5b70bae..bdd97bb2446d 100644 --- a/arch/powerpc/platforms/cell/axon_msi.c +++ b/arch/powerpc/platforms/cell/axon_msi.c | |||
@@ -64,7 +64,6 @@ | |||
64 | 64 | ||
65 | 65 | ||
66 | struct axon_msic { | 66 | struct axon_msic { |
67 | struct device_node *dn; | ||
68 | struct irq_host *irq_host; | 67 | struct irq_host *irq_host; |
69 | __le32 *fifo; | 68 | __le32 *fifo; |
70 | dcr_host_t dcr_host; | 69 | dcr_host_t dcr_host; |
@@ -297,9 +296,7 @@ static int msic_host_map(struct irq_host *h, unsigned int virq, | |||
297 | 296 | ||
298 | static int msic_host_match(struct irq_host *host, struct device_node *dn) | 297 | static int msic_host_match(struct irq_host *host, struct device_node *dn) |
299 | { | 298 | { |
300 | struct axon_msic *msic = host->host_data; | 299 | return host->of_node == dn; |
301 | |||
302 | return msic->dn == dn; | ||
303 | } | 300 | } |
304 | 301 | ||
305 | static struct irq_host_ops msic_host_ops = { | 302 | static struct irq_host_ops msic_host_ops = { |
@@ -314,7 +311,8 @@ static int axon_msi_notify_reboot(struct notifier_block *nb, | |||
314 | u32 tmp; | 311 | u32 tmp; |
315 | 312 | ||
316 | list_for_each_entry(msic, &axon_msic_list, list) { | 313 | list_for_each_entry(msic, &axon_msic_list, list) { |
317 | pr_debug("axon_msi: disabling %s\n", msic->dn->full_name); | 314 | pr_debug("axon_msi: disabling %s\n", |
315 | msic->irq_host->of_node->full_name); | ||
318 | tmp = msic_dcr_read(msic, MSIC_CTRL_REG); | 316 | tmp = msic_dcr_read(msic, MSIC_CTRL_REG); |
319 | tmp &= ~MSIC_CTRL_ENABLE & ~MSIC_CTRL_IRQ_ENABLE; | 317 | tmp &= ~MSIC_CTRL_ENABLE & ~MSIC_CTRL_IRQ_ENABLE; |
320 | msic_dcr_write(msic, MSIC_CTRL_REG, tmp); | 318 | msic_dcr_write(msic, MSIC_CTRL_REG, tmp); |
@@ -370,8 +368,8 @@ static int axon_msi_setup_one(struct device_node *dn) | |||
370 | 368 | ||
371 | msic->fifo = page_address(page); | 369 | msic->fifo = page_address(page); |
372 | 370 | ||
373 | msic->irq_host = irq_alloc_host(IRQ_HOST_MAP_NOMAP, NR_IRQS, | 371 | msic->irq_host = irq_alloc_host(of_node_get(dn), IRQ_HOST_MAP_NOMAP, |
374 | &msic_host_ops, 0); | 372 | NR_IRQS, &msic_host_ops, 0); |
375 | if (!msic->irq_host) { | 373 | if (!msic->irq_host) { |
376 | printk(KERN_ERR "axon_msi: couldn't allocate irq_host for %s\n", | 374 | printk(KERN_ERR "axon_msi: couldn't allocate irq_host for %s\n", |
377 | dn->full_name); | 375 | dn->full_name); |
@@ -387,8 +385,6 @@ static int axon_msi_setup_one(struct device_node *dn) | |||
387 | goto out_free_host; | 385 | goto out_free_host; |
388 | } | 386 | } |
389 | 387 | ||
390 | msic->dn = of_node_get(dn); | ||
391 | |||
392 | set_irq_data(virq, msic); | 388 | set_irq_data(virq, msic); |
393 | set_irq_chained_handler(virq, axon_msi_cascade); | 389 | set_irq_chained_handler(virq, axon_msi_cascade); |
394 | pr_debug("axon_msi: irq 0x%x setup for axon_msi\n", virq); | 390 | pr_debug("axon_msi: irq 0x%x setup for axon_msi\n", virq); |
diff --git a/arch/powerpc/platforms/cell/interrupt.c b/arch/powerpc/platforms/cell/interrupt.c index 47264e722029..c29e634177fa 100644 --- a/arch/powerpc/platforms/cell/interrupt.c +++ b/arch/powerpc/platforms/cell/interrupt.c | |||
@@ -381,7 +381,7 @@ static int __init setup_iic(void) | |||
381 | void __init iic_init_IRQ(void) | 381 | void __init iic_init_IRQ(void) |
382 | { | 382 | { |
383 | /* Setup an irq host data structure */ | 383 | /* Setup an irq host data structure */ |
384 | iic_host = irq_alloc_host(IRQ_HOST_MAP_LINEAR, IIC_SOURCE_COUNT, | 384 | iic_host = irq_alloc_host(NULL, IRQ_HOST_MAP_LINEAR, IIC_SOURCE_COUNT, |
385 | &iic_host_ops, IIC_IRQ_INVALID); | 385 | &iic_host_ops, IIC_IRQ_INVALID); |
386 | BUG_ON(iic_host == NULL); | 386 | BUG_ON(iic_host == NULL); |
387 | irq_set_default_host(iic_host); | 387 | irq_set_default_host(iic_host); |
diff --git a/arch/powerpc/platforms/cell/spider-pic.c b/arch/powerpc/platforms/cell/spider-pic.c index 05f4b3d3d756..4309c2cbbeb9 100644 --- a/arch/powerpc/platforms/cell/spider-pic.c +++ b/arch/powerpc/platforms/cell/spider-pic.c | |||
@@ -63,7 +63,6 @@ enum { | |||
63 | 63 | ||
64 | struct spider_pic { | 64 | struct spider_pic { |
65 | struct irq_host *host; | 65 | struct irq_host *host; |
66 | struct device_node *of_node; | ||
67 | void __iomem *regs; | 66 | void __iomem *regs; |
68 | unsigned int node_id; | 67 | unsigned int node_id; |
69 | }; | 68 | }; |
@@ -178,8 +177,7 @@ static struct irq_chip spider_pic = { | |||
178 | 177 | ||
179 | static int spider_host_match(struct irq_host *h, struct device_node *node) | 178 | static int spider_host_match(struct irq_host *h, struct device_node *node) |
180 | { | 179 | { |
181 | struct spider_pic *pic = h->host_data; | 180 | return h->of_node == node; |
182 | return node == pic->of_node; | ||
183 | } | 181 | } |
184 | 182 | ||
185 | static int spider_host_map(struct irq_host *h, unsigned int virq, | 183 | static int spider_host_map(struct irq_host *h, unsigned int virq, |
@@ -247,18 +245,18 @@ static unsigned int __init spider_find_cascade_and_node(struct spider_pic *pic) | |||
247 | * tree in case the device-tree is ever fixed | 245 | * tree in case the device-tree is ever fixed |
248 | */ | 246 | */ |
249 | struct of_irq oirq; | 247 | struct of_irq oirq; |
250 | if (of_irq_map_one(pic->of_node, 0, &oirq) == 0) { | 248 | if (of_irq_map_one(pic->host->of_node, 0, &oirq) == 0) { |
251 | virq = irq_create_of_mapping(oirq.controller, oirq.specifier, | 249 | virq = irq_create_of_mapping(oirq.controller, oirq.specifier, |
252 | oirq.size); | 250 | oirq.size); |
253 | return virq; | 251 | return virq; |
254 | } | 252 | } |
255 | 253 | ||
256 | /* Now do the horrible hacks */ | 254 | /* Now do the horrible hacks */ |
257 | tmp = of_get_property(pic->of_node, "#interrupt-cells", NULL); | 255 | tmp = of_get_property(pic->host->of_node, "#interrupt-cells", NULL); |
258 | if (tmp == NULL) | 256 | if (tmp == NULL) |
259 | return NO_IRQ; | 257 | return NO_IRQ; |
260 | intsize = *tmp; | 258 | intsize = *tmp; |
261 | imap = of_get_property(pic->of_node, "interrupt-map", &imaplen); | 259 | imap = of_get_property(pic->host->of_node, "interrupt-map", &imaplen); |
262 | if (imap == NULL || imaplen < (intsize + 1)) | 260 | if (imap == NULL || imaplen < (intsize + 1)) |
263 | return NO_IRQ; | 261 | return NO_IRQ; |
264 | iic = of_find_node_by_phandle(imap[intsize]); | 262 | iic = of_find_node_by_phandle(imap[intsize]); |
@@ -308,15 +306,13 @@ static void __init spider_init_one(struct device_node *of_node, int chip, | |||
308 | panic("spider_pic: can't map registers !"); | 306 | panic("spider_pic: can't map registers !"); |
309 | 307 | ||
310 | /* Allocate a host */ | 308 | /* Allocate a host */ |
311 | pic->host = irq_alloc_host(IRQ_HOST_MAP_LINEAR, SPIDER_SRC_COUNT, | 309 | pic->host = irq_alloc_host(of_node_get(of_node), IRQ_HOST_MAP_LINEAR, |
312 | &spider_host_ops, SPIDER_IRQ_INVALID); | 310 | SPIDER_SRC_COUNT, &spider_host_ops, |
311 | SPIDER_IRQ_INVALID); | ||
313 | if (pic->host == NULL) | 312 | if (pic->host == NULL) |
314 | panic("spider_pic: can't allocate irq host !"); | 313 | panic("spider_pic: can't allocate irq host !"); |
315 | pic->host->host_data = pic; | 314 | pic->host->host_data = pic; |
316 | 315 | ||
317 | /* Fill out other bits */ | ||
318 | pic->of_node = of_node_get(of_node); | ||
319 | |||
320 | /* Go through all sources and disable them */ | 316 | /* Go through all sources and disable them */ |
321 | for (i = 0; i < SPIDER_SRC_COUNT; i++) { | 317 | for (i = 0; i < SPIDER_SRC_COUNT; i++) { |
322 | void __iomem *cfg = pic->regs + TIR_CFGA + 8 * i; | 318 | void __iomem *cfg = pic->regs + TIR_CFGA + 8 * i; |