diff options
author | Prarit Bhargava <prarit@redhat.com> | 2013-10-17 08:00:11 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-11-29 14:11:51 -0500 |
commit | a2db1eb6794f761bc90ae128c0694874bf572579 (patch) | |
tree | ed363b612b87b233ab6eadd5fd9b2b69036ebd00 /arch/powerpc/kernel | |
parent | ae4c6cbd0a56bcea14bf35168076b9ad5bd3203f (diff) |
powerpc/vio: use strcpy in modalias_show
commit 411cabf79e684171669ad29a0628c400b4431e95 upstream.
Commit e82b89a6f19bae73fb064d1b3dd91fcefbb478f4 used strcat instead of
strcpy which can result in an overflow of newlines on the buffer.
Signed-off-by: Prarit Bhargava
Cc: benh@kernel.crashing.org
Cc: ben@decadent.org.uk
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch/powerpc/kernel')
-rw-r--r-- | arch/powerpc/kernel/vio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c index 2d845d8199fc..56d2e72c85de 100644 --- a/arch/powerpc/kernel/vio.c +++ b/arch/powerpc/kernel/vio.c | |||
@@ -1530,12 +1530,12 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr, | |||
1530 | 1530 | ||
1531 | dn = dev->of_node; | 1531 | dn = dev->of_node; |
1532 | if (!dn) { | 1532 | if (!dn) { |
1533 | strcat(buf, "\n"); | 1533 | strcpy(buf, "\n"); |
1534 | return strlen(buf); | 1534 | return strlen(buf); |
1535 | } | 1535 | } |
1536 | cp = of_get_property(dn, "compatible", NULL); | 1536 | cp = of_get_property(dn, "compatible", NULL); |
1537 | if (!cp) { | 1537 | if (!cp) { |
1538 | strcat(buf, "\n"); | 1538 | strcpy(buf, "\n"); |
1539 | return strlen(buf); | 1539 | return strlen(buf); |
1540 | } | 1540 | } |
1541 | 1541 | ||