aboutsummaryrefslogtreecommitdiffstats
path: root/arch/arm/mach-omap2/vp.c
diff options
context:
space:
mode:
authorKevin Hilman <khilman@ti.com>2011-03-28 14:57:18 -0400
committerKevin Hilman <khilman@ti.com>2011-09-15 15:02:07 -0400
commit842ec22852cf843558828e6f7a6da2bf72f341a5 (patch)
tree4f9c5792b6694452bbc7ba8e89da9ae68ccb7c17 /arch/arm/mach-omap2/vp.c
parent58aaa599a97308c0f4a68ef07039157807fa8324 (diff)
OMAP3+ VP: replace transaction done check/clear with VP ops
Replace the VP tranxdone check/clear with helper functions from the PRM layer. In the process, remove prm_irqst_* voltage structure fields for IRQ status checking which are no longer needed. Since these reads/writes of the IRQ status bits were the only PRM accesses that were not to VC/VP registers, this allows the rest of the register accesses in the VC/VP code to use VC/VP specific register access functions (done in the following patch.) Signed-off-by: Kevin Hilman <khilman@ti.com>
Diffstat (limited to 'arch/arm/mach-omap2/vp.c')
-rw-r--r--arch/arm/mach-omap2/vp.c16
1 files changed, 5 insertions, 11 deletions
diff --git a/arch/arm/mach-omap2/vp.c b/arch/arm/mach-omap2/vp.c
index f3503de5d8fd..113c839f6e23 100644
--- a/arch/arm/mach-omap2/vp.c
+++ b/arch/arm/mach-omap2/vp.c
@@ -111,10 +111,8 @@ int omap_vp_forceupdate_scale(struct voltagedomain *voltdm,
111 * is <3us 111 * is <3us
112 */ 112 */
113 while (timeout++ < VP_TRANXDONE_TIMEOUT) { 113 while (timeout++ < VP_TRANXDONE_TIMEOUT) {
114 vdd->write_reg(vp->prm_irqst_data->tranxdone_status, 114 vp->vp_common->ops->clear_txdone(vp->id);
115 vdd->prm_irqst_mod, vdd->prm_irqst_reg); 115 if (!vp->vp_common->ops->check_txdone(vp->id))
116 if (!(vdd->read_reg(vdd->prm_irqst_mod, vdd->prm_irqst_reg) &
117 vp->prm_irqst_data->tranxdone_status))
118 break; 116 break;
119 udelay(1); 117 udelay(1);
120 } 118 }
@@ -146,9 +144,7 @@ int omap_vp_forceupdate_scale(struct voltagedomain *voltdm,
146 * Depends on SMPSWAITTIMEMIN/MAX and voltage change 144 * Depends on SMPSWAITTIMEMIN/MAX and voltage change
147 */ 145 */
148 timeout = 0; 146 timeout = 0;
149 omap_test_timeout((vdd->read_reg(vdd->prm_irqst_mod, 147 omap_test_timeout(vp->vp_common->ops->check_txdone(vp->id),
150 vdd->prm_irqst_reg) &
151 vp->prm_irqst_data->tranxdone_status),
152 VP_TRANXDONE_TIMEOUT, timeout); 148 VP_TRANXDONE_TIMEOUT, timeout);
153 if (timeout >= VP_TRANXDONE_TIMEOUT) 149 if (timeout >= VP_TRANXDONE_TIMEOUT)
154 pr_err("%s: vdd_%s TRANXDONE timeout exceeded." 150 pr_err("%s: vdd_%s TRANXDONE timeout exceeded."
@@ -163,10 +159,8 @@ int omap_vp_forceupdate_scale(struct voltagedomain *voltdm,
163 */ 159 */
164 timeout = 0; 160 timeout = 0;
165 while (timeout++ < VP_TRANXDONE_TIMEOUT) { 161 while (timeout++ < VP_TRANXDONE_TIMEOUT) {
166 vdd->write_reg(vp->prm_irqst_data->tranxdone_status, 162 vp->vp_common->ops->clear_txdone(vp->id);
167 vdd->prm_irqst_mod, vdd->prm_irqst_reg); 163 if (!vp->vp_common->ops->check_txdone(vp->id))
168 if (!(vdd->read_reg(vdd->prm_irqst_mod, vdd->prm_irqst_reg) &
169 vp->prm_irqst_data->tranxdone_status))
170 break; 164 break;
171 udelay(1); 165 udelay(1);
172 } 166 }