diff options
author | Paul Walmsley <paul@pwsan.com> | 2011-03-11 00:17:45 -0500 |
---|---|---|
committer | Paul Walmsley <paul@pwsan.com> | 2011-03-11 00:17:45 -0500 |
commit | c0718df4d666cc5fd8837ac93c82995a17bfdbf5 (patch) | |
tree | 32df3f7405be2be07bdb1c6b98ebc0b143cf6571 /arch/arm/mach-omap2/opp4xxx_data.c | |
parent | e1d6f4729e9fd46efa1029b6e806bb8b6c24e776 (diff) |
OMAP2+: voltage: reorganize, split code from data
This is a first pass at reorganizing mach-omap2/voltage.c:
- Separate almost all of the data from the code of mach-omap2/voltage.c.
The code remains in mach-omap2/voltage.c. The data goes into one
of several places, depending on what type of data it is:
- Silicon process/validation data: mach-omap2/opp*_data.c
- VC (Voltage Controller) data: mach-omap2/vc*_data.c
- VP (Voltage Processor) data: mach-omap2/vp*_data.c
- Voltage domain data: mach-omap2/voltagedomains*_data.c
The ultimate goal is for all this data to be autogenerated, the same
way we autogenerate the rest of our data.
- Separate VC and VP common data from VDD-specific VC and VP data.
- Separate common voltage.c code from SoC-specific code; reuse common code.
- Reorganize structures to avoid unnecessary memory loss due to unpacked
fields.
There is much left to be done. VC code and VP code should be separated out
into vc*.c and vp*.c files. Many fields in the existing structures are
superfluous, and should be removed. Some code in voltage.c seems to be
duplicated; that code should be moved into functions of its own. Proper
voltage domain code should be created, as was done with the powerdomain
and clockdomains, and powerdomains should reference voltagedomains.
Thanks to Shweta Gulati <shweta.gulati@ti.com> for comments. Thanks
to Rajendra Nayak <rnayak@ti.com> for finding and fixing some bugs
that prevented OMAP4 from booting:
https://patchwork.kernel.org/patch/587311/
His patch has been folded into this one to avoid breaking OMAP4
between patches. Thanks also to Kevin Hilman <khilman@ti.com> for
finding and fixing a compile problem when !CONFIG_PM:
http://www.spinics.net/lists/arm-kernel/msg118067.html
His patch has also been folded into this one to avoid breaking
!CONFIG_PM builds.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Shweta Gulati <shweta.gulati@ti.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
Diffstat (limited to 'arch/arm/mach-omap2/opp4xxx_data.c')
-rw-r--r-- | arch/arm/mach-omap2/opp4xxx_data.c | 43 |
1 files changed, 42 insertions, 1 deletions
diff --git a/arch/arm/mach-omap2/opp4xxx_data.c b/arch/arm/mach-omap2/opp4xxx_data.c index a11fa566d8ee..fdee8d4186ab 100644 --- a/arch/arm/mach-omap2/opp4xxx_data.c +++ b/arch/arm/mach-omap2/opp4xxx_data.c | |||
@@ -5,8 +5,9 @@ | |||
5 | * Nishanth Menon | 5 | * Nishanth Menon |
6 | * Kevin Hilman | 6 | * Kevin Hilman |
7 | * Thara Gopinath | 7 | * Thara Gopinath |
8 | * Copyright (C) 2010 Nokia Corporation. | 8 | * Copyright (C) 2010-2011 Nokia Corporation. |
9 | * Eduardo Valentin | 9 | * Eduardo Valentin |
10 | * Paul Walmsley | ||
10 | * | 11 | * |
11 | * This program is free software; you can redistribute it and/or modify | 12 | * This program is free software; you can redistribute it and/or modify |
12 | * it under the terms of the GNU General Public License version 2 as | 13 | * it under the terms of the GNU General Public License version 2 as |
@@ -21,8 +22,48 @@ | |||
21 | 22 | ||
22 | #include <plat/cpu.h> | 23 | #include <plat/cpu.h> |
23 | 24 | ||
25 | #include "control.h" | ||
24 | #include "omap_opp_data.h" | 26 | #include "omap_opp_data.h" |
25 | 27 | ||
28 | /* | ||
29 | * Structures containing OMAP4430 voltage supported and various | ||
30 | * voltage dependent data for each VDD. | ||
31 | */ | ||
32 | |||
33 | #define OMAP4430_VDD_MPU_OPP50_UV 930000 | ||
34 | #define OMAP4430_VDD_MPU_OPP100_UV 1100000 | ||
35 | #define OMAP4430_VDD_MPU_OPPTURBO_UV 1260000 | ||
36 | #define OMAP4430_VDD_MPU_OPPNITRO_UV 1350000 | ||
37 | |||
38 | struct omap_volt_data omap44xx_vdd_mpu_volt_data[] = { | ||
39 | VOLT_DATA_DEFINE(OMAP4430_VDD_MPU_OPP50_UV, OMAP44XX_CONTROL_FUSE_MPU_OPP50, 0xf4, 0x0c), | ||
40 | VOLT_DATA_DEFINE(OMAP4430_VDD_MPU_OPP100_UV, OMAP44XX_CONTROL_FUSE_MPU_OPP100, 0xf9, 0x16), | ||
41 | VOLT_DATA_DEFINE(OMAP4430_VDD_MPU_OPPTURBO_UV, OMAP44XX_CONTROL_FUSE_MPU_OPPTURBO, 0xfa, 0x23), | ||
42 | VOLT_DATA_DEFINE(OMAP4430_VDD_MPU_OPPNITRO_UV, OMAP44XX_CONTROL_FUSE_MPU_OPPNITRO, 0xfa, 0x27), | ||
43 | VOLT_DATA_DEFINE(0, 0, 0, 0), | ||
44 | }; | ||
45 | |||
46 | #define OMAP4430_VDD_IVA_OPP50_UV 930000 | ||
47 | #define OMAP4430_VDD_IVA_OPP100_UV 1100000 | ||
48 | #define OMAP4430_VDD_IVA_OPPTURBO_UV 1260000 | ||
49 | |||
50 | struct omap_volt_data omap44xx_vdd_iva_volt_data[] = { | ||
51 | VOLT_DATA_DEFINE(OMAP4430_VDD_IVA_OPP50_UV, OMAP44XX_CONTROL_FUSE_IVA_OPP50, 0xf4, 0x0c), | ||
52 | VOLT_DATA_DEFINE(OMAP4430_VDD_IVA_OPP100_UV, OMAP44XX_CONTROL_FUSE_IVA_OPP100, 0xf9, 0x16), | ||
53 | VOLT_DATA_DEFINE(OMAP4430_VDD_IVA_OPPTURBO_UV, OMAP44XX_CONTROL_FUSE_IVA_OPPTURBO, 0xfa, 0x23), | ||
54 | VOLT_DATA_DEFINE(0, 0, 0, 0), | ||
55 | }; | ||
56 | |||
57 | #define OMAP4430_VDD_CORE_OPP50_UV 930000 | ||
58 | #define OMAP4430_VDD_CORE_OPP100_UV 1100000 | ||
59 | |||
60 | struct omap_volt_data omap44xx_vdd_core_volt_data[] = { | ||
61 | VOLT_DATA_DEFINE(OMAP4430_VDD_CORE_OPP50_UV, OMAP44XX_CONTROL_FUSE_CORE_OPP50, 0xf4, 0x0c), | ||
62 | VOLT_DATA_DEFINE(OMAP4430_VDD_CORE_OPP100_UV, OMAP44XX_CONTROL_FUSE_CORE_OPP100, 0xf9, 0x16), | ||
63 | VOLT_DATA_DEFINE(0, 0, 0, 0), | ||
64 | }; | ||
65 | |||
66 | |||
26 | static struct omap_opp_def __initdata omap44xx_opp_def_list[] = { | 67 | static struct omap_opp_def __initdata omap44xx_opp_def_list[] = { |
27 | /* MPU OPP1 - OPP50 */ | 68 | /* MPU OPP1 - OPP50 */ |
28 | OPP_INITIALIZER("mpu", true, 300000000, 1100000), | 69 | OPP_INITIALIZER("mpu", true, 300000000, 1100000), |