diff options
| author | Benoît Thébaudeau <benoit.thebaudeau@advansee.com> | 2012-06-12 13:46:43 -0400 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2012-06-13 03:03:24 -0400 |
| commit | 33a264ddcded2120fc0baa7afe4bcc5b4df3c416 (patch) | |
| tree | dc04c6e89f00a27b4dd213cd322b034b4d96462f /arch/arm/mach-imx/mach-mx31_3ds.c | |
| parent | cfaf025112d3856637ff34a767ef785ef5cf2ca9 (diff) | |
ARM: imx: cleanup otg_mode
Cleanup the code for the otg_mode command line param:
* Use the bool type as it applies here.
* Qualify otg_mode_host with __initdata since this variable is only used in this
context.
* The __setup functions are not supposed to return a status code, but a boolean
indicating whether the param has been handled. See obsolete_checksetup() in
init/main.c.
Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'arch/arm/mach-imx/mach-mx31_3ds.c')
| -rw-r--r-- | arch/arm/mach-imx/mach-mx31_3ds.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/arm/mach-imx/mach-mx31_3ds.c b/arch/arm/mach-imx/mach-mx31_3ds.c index 4eafdf275ea2..ebcadd2e6be0 100644 --- a/arch/arm/mach-imx/mach-mx31_3ds.c +++ b/arch/arm/mach-imx/mach-mx31_3ds.c | |||
| @@ -671,18 +671,18 @@ static const struct fsl_usb2_platform_data usbotg_pdata __initconst = { | |||
| 671 | .phy_mode = FSL_USB2_PHY_ULPI, | 671 | .phy_mode = FSL_USB2_PHY_ULPI, |
| 672 | }; | 672 | }; |
| 673 | 673 | ||
| 674 | static int otg_mode_host; | 674 | static bool otg_mode_host __initdata; |
| 675 | 675 | ||
| 676 | static int __init mx31_3ds_otg_mode(char *options) | 676 | static int __init mx31_3ds_otg_mode(char *options) |
| 677 | { | 677 | { |
| 678 | if (!strcmp(options, "host")) | 678 | if (!strcmp(options, "host")) |
| 679 | otg_mode_host = 1; | 679 | otg_mode_host = true; |
| 680 | else if (!strcmp(options, "device")) | 680 | else if (!strcmp(options, "device")) |
| 681 | otg_mode_host = 0; | 681 | otg_mode_host = false; |
| 682 | else | 682 | else |
| 683 | pr_info("otg_mode neither \"host\" nor \"device\". " | 683 | pr_info("otg_mode neither \"host\" nor \"device\". " |
| 684 | "Defaulting to device\n"); | 684 | "Defaulting to device\n"); |
| 685 | return 0; | 685 | return 1; |
| 686 | } | 686 | } |
| 687 | __setup("otg_mode=", mx31_3ds_otg_mode); | 687 | __setup("otg_mode=", mx31_3ds_otg_mode); |
| 688 | 688 | ||