diff options
author | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2011-04-04 08:40:23 -0400 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2011-05-11 07:20:11 -0400 |
commit | e3502ce97f2d2d183735d9fae76b081a634ffd85 (patch) | |
tree | 69058daa11e867a0434f169f2998f3e479e9d5ea | |
parent | 7636b3b4e178f6c09d9e2650f206eab62a67453b (diff) |
OMAP: DSS2: Convert simple/strict_strto* to kstrto*
Convert simple/strict_strto* functions to kstrto* functions. Only simple
cases are converted.
simple_strto* uses are still left to places where it is used to parse
numbers from a list of numbers. These need some other solution than
kstrto*.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
-rw-r--r-- | drivers/video/omap2/displays/panel-tpo-td043mtea1.c | 8 | ||||
-rw-r--r-- | drivers/video/omap2/dss/display.c | 44 | ||||
-rw-r--r-- | drivers/video/omap2/dss/overlay.c | 22 | ||||
-rw-r--r-- | drivers/video/omap2/omapfb/omapfb-sysfs.c | 21 |
4 files changed, 66 insertions, 29 deletions
diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c index 62bff58e2bad..2462b9ec6662 100644 --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c | |||
@@ -144,13 +144,15 @@ static ssize_t tpo_td043_vmirror_store(struct device *dev, | |||
144 | struct device_attribute *attr, const char *buf, size_t count) | 144 | struct device_attribute *attr, const char *buf, size_t count) |
145 | { | 145 | { |
146 | struct tpo_td043_device *tpo_td043 = dev_get_drvdata(dev); | 146 | struct tpo_td043_device *tpo_td043 = dev_get_drvdata(dev); |
147 | long val; | 147 | int val; |
148 | int ret; | 148 | int ret; |
149 | 149 | ||
150 | ret = strict_strtol(buf, 0, &val); | 150 | ret = kstrtoint(buf, 0, &val); |
151 | if (ret < 0) | 151 | if (ret < 0) |
152 | return ret; | 152 | return ret; |
153 | 153 | ||
154 | val = !!val; | ||
155 | |||
154 | ret = tpo_td043_write_mirror(tpo_td043->spi, tpo_td043->hmirror, val); | 156 | ret = tpo_td043_write_mirror(tpo_td043->spi, tpo_td043->hmirror, val); |
155 | if (ret < 0) | 157 | if (ret < 0) |
156 | return ret; | 158 | return ret; |
@@ -175,7 +177,7 @@ static ssize_t tpo_td043_mode_store(struct device *dev, | |||
175 | long val; | 177 | long val; |
176 | int ret; | 178 | int ret; |
177 | 179 | ||
178 | ret = strict_strtol(buf, 0, &val); | 180 | ret = kstrtol(buf, 0, &val); |
179 | if (ret != 0 || val & ~7) | 181 | if (ret != 0 || val & ~7) |
180 | return -EINVAL; | 182 | return -EINVAL; |
181 | 183 | ||
diff --git a/drivers/video/omap2/dss/display.c b/drivers/video/omap2/dss/display.c index 696369ca745b..c2dfc8c50057 100644 --- a/drivers/video/omap2/dss/display.c +++ b/drivers/video/omap2/dss/display.c | |||
@@ -44,9 +44,13 @@ static ssize_t display_enabled_store(struct device *dev, | |||
44 | const char *buf, size_t size) | 44 | const char *buf, size_t size) |
45 | { | 45 | { |
46 | struct omap_dss_device *dssdev = to_dss_device(dev); | 46 | struct omap_dss_device *dssdev = to_dss_device(dev); |
47 | bool enabled, r; | 47 | int r, enabled; |
48 | 48 | ||
49 | enabled = simple_strtoul(buf, NULL, 10); | 49 | r = kstrtoint(buf, 0, &enabled); |
50 | if (r) | ||
51 | return r; | ||
52 | |||
53 | enabled = !!enabled; | ||
50 | 54 | ||
51 | if (enabled != (dssdev->state != OMAP_DSS_DISPLAY_DISABLED)) { | 55 | if (enabled != (dssdev->state != OMAP_DSS_DISPLAY_DISABLED)) { |
52 | if (enabled) { | 56 | if (enabled) { |
@@ -82,7 +86,9 @@ static ssize_t display_upd_mode_store(struct device *dev, | |||
82 | if (!dssdev->driver->set_update_mode) | 86 | if (!dssdev->driver->set_update_mode) |
83 | return -EINVAL; | 87 | return -EINVAL; |
84 | 88 | ||
85 | val = simple_strtoul(buf, NULL, 10); | 89 | r = kstrtoint(buf, 0, &val); |
90 | if (r) | ||
91 | return r; | ||
86 | 92 | ||
87 | switch (val) { | 93 | switch (val) { |
88 | case OMAP_DSS_UPDATE_DISABLED: | 94 | case OMAP_DSS_UPDATE_DISABLED: |
@@ -114,13 +120,16 @@ static ssize_t display_tear_store(struct device *dev, | |||
114 | struct device_attribute *attr, const char *buf, size_t size) | 120 | struct device_attribute *attr, const char *buf, size_t size) |
115 | { | 121 | { |
116 | struct omap_dss_device *dssdev = to_dss_device(dev); | 122 | struct omap_dss_device *dssdev = to_dss_device(dev); |
117 | unsigned long te; | 123 | int te, r; |
118 | int r; | ||
119 | 124 | ||
120 | if (!dssdev->driver->enable_te || !dssdev->driver->get_te) | 125 | if (!dssdev->driver->enable_te || !dssdev->driver->get_te) |
121 | return -ENOENT; | 126 | return -ENOENT; |
122 | 127 | ||
123 | te = simple_strtoul(buf, NULL, 0); | 128 | r = kstrtoint(buf, 0, &te); |
129 | if (r) | ||
130 | return r; | ||
131 | |||
132 | te = !!te; | ||
124 | 133 | ||
125 | r = dssdev->driver->enable_te(dssdev, te); | 134 | r = dssdev->driver->enable_te(dssdev, te); |
126 | if (r) | 135 | if (r) |
@@ -196,13 +205,14 @@ static ssize_t display_rotate_store(struct device *dev, | |||
196 | struct device_attribute *attr, const char *buf, size_t size) | 205 | struct device_attribute *attr, const char *buf, size_t size) |
197 | { | 206 | { |
198 | struct omap_dss_device *dssdev = to_dss_device(dev); | 207 | struct omap_dss_device *dssdev = to_dss_device(dev); |
199 | unsigned long rot; | 208 | int rot, r; |
200 | int r; | ||
201 | 209 | ||
202 | if (!dssdev->driver->set_rotate || !dssdev->driver->get_rotate) | 210 | if (!dssdev->driver->set_rotate || !dssdev->driver->get_rotate) |
203 | return -ENOENT; | 211 | return -ENOENT; |
204 | 212 | ||
205 | rot = simple_strtoul(buf, NULL, 0); | 213 | r = kstrtoint(buf, 0, &rot); |
214 | if (r) | ||
215 | return r; | ||
206 | 216 | ||
207 | r = dssdev->driver->set_rotate(dssdev, rot); | 217 | r = dssdev->driver->set_rotate(dssdev, rot); |
208 | if (r) | 218 | if (r) |
@@ -226,13 +236,16 @@ static ssize_t display_mirror_store(struct device *dev, | |||
226 | struct device_attribute *attr, const char *buf, size_t size) | 236 | struct device_attribute *attr, const char *buf, size_t size) |
227 | { | 237 | { |
228 | struct omap_dss_device *dssdev = to_dss_device(dev); | 238 | struct omap_dss_device *dssdev = to_dss_device(dev); |
229 | unsigned long mirror; | 239 | int mirror, r; |
230 | int r; | ||
231 | 240 | ||
232 | if (!dssdev->driver->set_mirror || !dssdev->driver->get_mirror) | 241 | if (!dssdev->driver->set_mirror || !dssdev->driver->get_mirror) |
233 | return -ENOENT; | 242 | return -ENOENT; |
234 | 243 | ||
235 | mirror = simple_strtoul(buf, NULL, 0); | 244 | r = kstrtoint(buf, 0, &mirror); |
245 | if (r) | ||
246 | return r; | ||
247 | |||
248 | mirror = !!mirror; | ||
236 | 249 | ||
237 | r = dssdev->driver->set_mirror(dssdev, mirror); | 250 | r = dssdev->driver->set_mirror(dssdev, mirror); |
238 | if (r) | 251 | if (r) |
@@ -259,14 +272,15 @@ static ssize_t display_wss_store(struct device *dev, | |||
259 | struct device_attribute *attr, const char *buf, size_t size) | 272 | struct device_attribute *attr, const char *buf, size_t size) |
260 | { | 273 | { |
261 | struct omap_dss_device *dssdev = to_dss_device(dev); | 274 | struct omap_dss_device *dssdev = to_dss_device(dev); |
262 | unsigned long wss; | 275 | u32 wss; |
263 | int r; | 276 | int r; |
264 | 277 | ||
265 | if (!dssdev->driver->get_wss || !dssdev->driver->set_wss) | 278 | if (!dssdev->driver->get_wss || !dssdev->driver->set_wss) |
266 | return -ENOENT; | 279 | return -ENOENT; |
267 | 280 | ||
268 | if (strict_strtoul(buf, 0, &wss)) | 281 | r = kstrtou32(buf, 0, &wss); |
269 | return -EINVAL; | 282 | if (r) |
283 | return r; | ||
270 | 284 | ||
271 | if (wss > 0xfffff) | 285 | if (wss > 0xfffff) |
272 | return -EINVAL; | 286 | return -EINVAL; |
diff --git a/drivers/video/omap2/dss/overlay.c b/drivers/video/omap2/dss/overlay.c index 0377d46acadb..0f08025b1f0e 100644 --- a/drivers/video/omap2/dss/overlay.c +++ b/drivers/video/omap2/dss/overlay.c | |||
@@ -201,12 +201,16 @@ static ssize_t overlay_enabled_show(struct omap_overlay *ovl, char *buf) | |||
201 | static ssize_t overlay_enabled_store(struct omap_overlay *ovl, const char *buf, | 201 | static ssize_t overlay_enabled_store(struct omap_overlay *ovl, const char *buf, |
202 | size_t size) | 202 | size_t size) |
203 | { | 203 | { |
204 | int r; | 204 | int r, enable; |
205 | struct omap_overlay_info info; | 205 | struct omap_overlay_info info; |
206 | 206 | ||
207 | ovl->get_overlay_info(ovl, &info); | 207 | ovl->get_overlay_info(ovl, &info); |
208 | 208 | ||
209 | info.enabled = simple_strtoul(buf, NULL, 10); | 209 | r = kstrtoint(buf, 0, &enable); |
210 | if (r) | ||
211 | return r; | ||
212 | |||
213 | info.enabled = !!enable; | ||
210 | 214 | ||
211 | r = ovl->set_overlay_info(ovl, &info); | 215 | r = ovl->set_overlay_info(ovl, &info); |
212 | if (r) | 216 | if (r) |
@@ -231,8 +235,13 @@ static ssize_t overlay_global_alpha_store(struct omap_overlay *ovl, | |||
231 | const char *buf, size_t size) | 235 | const char *buf, size_t size) |
232 | { | 236 | { |
233 | int r; | 237 | int r; |
238 | u8 alpha; | ||
234 | struct omap_overlay_info info; | 239 | struct omap_overlay_info info; |
235 | 240 | ||
241 | r = kstrtou8(buf, 0, &alpha); | ||
242 | if (r) | ||
243 | return r; | ||
244 | |||
236 | ovl->get_overlay_info(ovl, &info); | 245 | ovl->get_overlay_info(ovl, &info); |
237 | 246 | ||
238 | /* Video1 plane does not support global alpha | 247 | /* Video1 plane does not support global alpha |
@@ -242,7 +251,7 @@ static ssize_t overlay_global_alpha_store(struct omap_overlay *ovl, | |||
242 | ovl->id == OMAP_DSS_VIDEO1) | 251 | ovl->id == OMAP_DSS_VIDEO1) |
243 | info.global_alpha = 255; | 252 | info.global_alpha = 255; |
244 | else | 253 | else |
245 | info.global_alpha = simple_strtoul(buf, NULL, 10); | 254 | info.global_alpha = alpha; |
246 | 255 | ||
247 | r = ovl->set_overlay_info(ovl, &info); | 256 | r = ovl->set_overlay_info(ovl, &info); |
248 | if (r) | 257 | if (r) |
@@ -268,8 +277,13 @@ static ssize_t overlay_pre_mult_alpha_store(struct omap_overlay *ovl, | |||
268 | const char *buf, size_t size) | 277 | const char *buf, size_t size) |
269 | { | 278 | { |
270 | int r; | 279 | int r; |
280 | u8 alpha; | ||
271 | struct omap_overlay_info info; | 281 | struct omap_overlay_info info; |
272 | 282 | ||
283 | r = kstrtou8(buf, 0, &alpha); | ||
284 | if (r) | ||
285 | return r; | ||
286 | |||
273 | ovl->get_overlay_info(ovl, &info); | 287 | ovl->get_overlay_info(ovl, &info); |
274 | 288 | ||
275 | /* only GFX and Video2 plane support pre alpha multiplied | 289 | /* only GFX and Video2 plane support pre alpha multiplied |
@@ -279,7 +293,7 @@ static ssize_t overlay_pre_mult_alpha_store(struct omap_overlay *ovl, | |||
279 | ovl->id == OMAP_DSS_VIDEO1) | 293 | ovl->id == OMAP_DSS_VIDEO1) |
280 | info.pre_mult_alpha = 0; | 294 | info.pre_mult_alpha = 0; |
281 | else | 295 | else |
282 | info.pre_mult_alpha = simple_strtoul(buf, NULL, 10); | 296 | info.pre_mult_alpha = alpha; |
283 | 297 | ||
284 | r = ovl->set_overlay_info(ovl, &info); | 298 | r = ovl->set_overlay_info(ovl, &info); |
285 | if (r) | 299 | if (r) |
diff --git a/drivers/video/omap2/omapfb/omapfb-sysfs.c b/drivers/video/omap2/omapfb/omapfb-sysfs.c index 3be76466a0ff..2f5e817b2a9a 100644 --- a/drivers/video/omap2/omapfb/omapfb-sysfs.c +++ b/drivers/video/omap2/omapfb/omapfb-sysfs.c | |||
@@ -50,10 +50,12 @@ static ssize_t store_rotate_type(struct device *dev, | |||
50 | struct fb_info *fbi = dev_get_drvdata(dev); | 50 | struct fb_info *fbi = dev_get_drvdata(dev); |
51 | struct omapfb_info *ofbi = FB2OFB(fbi); | 51 | struct omapfb_info *ofbi = FB2OFB(fbi); |
52 | struct omapfb2_mem_region *rg; | 52 | struct omapfb2_mem_region *rg; |
53 | enum omap_dss_rotation_type rot_type; | 53 | int rot_type; |
54 | int r; | 54 | int r; |
55 | 55 | ||
56 | rot_type = simple_strtoul(buf, NULL, 0); | 56 | r = kstrtoint(buf, 0, &rot_type); |
57 | if (r) | ||
58 | return r; | ||
57 | 59 | ||
58 | if (rot_type != OMAP_DSS_ROT_DMA && rot_type != OMAP_DSS_ROT_VRFB) | 60 | if (rot_type != OMAP_DSS_ROT_DMA && rot_type != OMAP_DSS_ROT_VRFB) |
59 | return -EINVAL; | 61 | return -EINVAL; |
@@ -102,14 +104,15 @@ static ssize_t store_mirror(struct device *dev, | |||
102 | { | 104 | { |
103 | struct fb_info *fbi = dev_get_drvdata(dev); | 105 | struct fb_info *fbi = dev_get_drvdata(dev); |
104 | struct omapfb_info *ofbi = FB2OFB(fbi); | 106 | struct omapfb_info *ofbi = FB2OFB(fbi); |
105 | unsigned long mirror; | 107 | int mirror; |
106 | int r; | 108 | int r; |
107 | struct fb_var_screeninfo new_var; | 109 | struct fb_var_screeninfo new_var; |
108 | 110 | ||
109 | mirror = simple_strtoul(buf, NULL, 0); | 111 | r = kstrtoint(buf, 0, &mirror); |
112 | if (r) | ||
113 | return r; | ||
110 | 114 | ||
111 | if (mirror != 0 && mirror != 1) | 115 | mirror = !!mirror; |
112 | return -EINVAL; | ||
113 | 116 | ||
114 | if (!lock_fb_info(fbi)) | 117 | if (!lock_fb_info(fbi)) |
115 | return -ENODEV; | 118 | return -ENODEV; |
@@ -445,7 +448,11 @@ static ssize_t store_size(struct device *dev, struct device_attribute *attr, | |||
445 | int r; | 448 | int r; |
446 | int i; | 449 | int i; |
447 | 450 | ||
448 | size = PAGE_ALIGN(simple_strtoul(buf, NULL, 0)); | 451 | r = kstrtoul(buf, 0, &size); |
452 | if (r) | ||
453 | return r; | ||
454 | |||
455 | size = PAGE_ALIGN(size); | ||
449 | 456 | ||
450 | if (!lock_fb_info(fbi)) | 457 | if (!lock_fb_info(fbi)) |
451 | return -ENODEV; | 458 | return -ENODEV; |