diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2007-12-21 09:07:53 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:00:01 -0500 |
commit | dfd4f0ae2e111e2b93c295938c0e64ebbb69ae6e (patch) | |
tree | 0ce2c35f0ffce2553d897116e9370fdaf0433f12 | |
parent | 8beb5c5f12c8484c59edf9b691f2c4bb4d31f3a0 (diff) |
[TCP]: Avoid two divides in __tcp_grow_window()
tcp_win_from_space() being signed, compiler might emit an integer divide
to compute tcp_win_from_space()/2 .
Using right shifts is OK here and less expensive.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv4/tcp_input.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index bc2d5f70966e..519bd24e0d3b 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c | |||
@@ -289,8 +289,8 @@ static int __tcp_grow_window(const struct sock *sk, const struct sk_buff *skb) | |||
289 | { | 289 | { |
290 | struct tcp_sock *tp = tcp_sk(sk); | 290 | struct tcp_sock *tp = tcp_sk(sk); |
291 | /* Optimize this! */ | 291 | /* Optimize this! */ |
292 | int truesize = tcp_win_from_space(skb->truesize)/2; | 292 | int truesize = tcp_win_from_space(skb->truesize) >> 1; |
293 | int window = tcp_win_from_space(sysctl_tcp_rmem[2])/2; | 293 | int window = tcp_win_from_space(sysctl_tcp_rmem[2]) >> 1; |
294 | 294 | ||
295 | while (tp->rcv_ssthresh <= window) { | 295 | while (tp->rcv_ssthresh <= window) { |
296 | if (truesize <= skb->len) | 296 | if (truesize <= skb->len) |