diff options
author | Joe Perches <joe@perches.com> | 2012-11-29 09:37:03 -0500 |
---|---|---|
committer | Alex Elder <elder@inktank.com> | 2012-12-13 09:13:07 -0500 |
commit | d2cc4dde9206aa2c7fb237aa689d3277cc070547 (patch) | |
tree | 8e0c48be01ac4bd07c19a526a08fbb30c6bac11b | |
parent | 83aff95eb9d60aff5497e9f44a2ae906b86d8e88 (diff) |
bdi_register: add __printf verification, fix arg mismatch
__printf is useful to verify format and arguments.
Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Alex Elder <elder@inktank.com>
-rw-r--r-- | fs/ceph/super.c | 2 | ||||
-rw-r--r-- | include/linux/backing-dev.h | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/fs/ceph/super.c b/fs/ceph/super.c index fcda1c73a1e5..1a144001b2e1 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c | |||
@@ -842,7 +842,7 @@ static int ceph_register_bdi(struct super_block *sb, | |||
842 | fsc->backing_dev_info.ra_pages = | 842 | fsc->backing_dev_info.ra_pages = |
843 | default_backing_dev_info.ra_pages; | 843 | default_backing_dev_info.ra_pages; |
844 | 844 | ||
845 | err = bdi_register(&fsc->backing_dev_info, NULL, "ceph-%d", | 845 | err = bdi_register(&fsc->backing_dev_info, NULL, "ceph-%ld", |
846 | atomic_long_inc_return(&bdi_seq)); | 846 | atomic_long_inc_return(&bdi_seq)); |
847 | if (!err) | 847 | if (!err) |
848 | sb->s_bdi = &fsc->backing_dev_info; | 848 | sb->s_bdi = &fsc->backing_dev_info; |
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h index 2a9a9abc9126..12731a19ef06 100644 --- a/include/linux/backing-dev.h +++ b/include/linux/backing-dev.h | |||
@@ -114,6 +114,7 @@ struct backing_dev_info { | |||
114 | int bdi_init(struct backing_dev_info *bdi); | 114 | int bdi_init(struct backing_dev_info *bdi); |
115 | void bdi_destroy(struct backing_dev_info *bdi); | 115 | void bdi_destroy(struct backing_dev_info *bdi); |
116 | 116 | ||
117 | __printf(3, 4) | ||
117 | int bdi_register(struct backing_dev_info *bdi, struct device *parent, | 118 | int bdi_register(struct backing_dev_info *bdi, struct device *parent, |
118 | const char *fmt, ...); | 119 | const char *fmt, ...); |
119 | int bdi_register_dev(struct backing_dev_info *bdi, dev_t dev); | 120 | int bdi_register_dev(struct backing_dev_info *bdi, dev_t dev); |