diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2012-07-27 15:48:36 -0400 |
---|---|---|
committer | Ben Hutchings <bhutchings@solarflare.com> | 2012-08-24 15:10:21 -0400 |
commit | b812f8b7a9b657367eaacab8c34e6711a657a48b (patch) | |
tree | 6d3da71309bb03e02b957a0416fa861c166e954c | |
parent | 8b7325b4e29256881117aff8a162e829c79b47e9 (diff) |
sfc: Improve log messages in case we abort probe due to a pending reset
The current informational message doesn't properly explain what
happens, and could also appear if we defer a reset during
suspend/resume.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
-rw-r--r-- | drivers/net/ethernet/sfc/efx.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 977fc3a591e9..5555e9f98162 100644 --- a/drivers/net/ethernet/sfc/efx.c +++ b/drivers/net/ethernet/sfc/efx.c | |||
@@ -2311,11 +2311,8 @@ static void efx_reset_work(struct work_struct *data) | |||
2311 | 2311 | ||
2312 | /* If we're not READY then don't reset. Leave the reset_pending | 2312 | /* If we're not READY then don't reset. Leave the reset_pending |
2313 | * flags set so that efx_pci_probe_main will be retried */ | 2313 | * flags set so that efx_pci_probe_main will be retried */ |
2314 | if (efx->state != STATE_READY) { | 2314 | if (efx->state != STATE_READY) |
2315 | netif_info(efx, drv, efx->net_dev, | ||
2316 | "scheduled reset quenched; NIC not ready\n"); | ||
2317 | return; | 2315 | return; |
2318 | } | ||
2319 | 2316 | ||
2320 | rtnl_lock(); | 2317 | rtnl_lock(); |
2321 | (void)efx_reset(efx, fls(pending) - 1); | 2318 | (void)efx_reset(efx, fls(pending) - 1); |
@@ -2703,6 +2700,8 @@ static int __devinit efx_pci_probe(struct pci_dev *pci_dev, | |||
2703 | * probably hosed anyway. | 2700 | * probably hosed anyway. |
2704 | */ | 2701 | */ |
2705 | if (efx->reset_pending) { | 2702 | if (efx->reset_pending) { |
2703 | netif_err(efx, probe, efx->net_dev, | ||
2704 | "aborting probe due to scheduled reset\n"); | ||
2706 | rc = -EIO; | 2705 | rc = -EIO; |
2707 | goto fail4; | 2706 | goto fail4; |
2708 | } | 2707 | } |