diff options
author | Liu Ying <Ying.Liu@freescale.com> | 2014-03-16 23:28:53 -0400 |
---|---|---|
committer | Nitin Garg <nitin.garg@freescale.com> | 2014-04-16 09:58:00 -0400 |
commit | b63ce9a8b3bb1fa14090ea26b4b63f1260ea6f8d (patch) | |
tree | 1542e0126dcde3bb7bd8cb823e2f452ab521c0f9 | |
parent | 4e7c655740468be56a2a5d0f0980a940ae8ea908 (diff) |
ENGR00303663 mxc v4l2 capture: Don't return error if we cannot get mipi csi2
The mipi csi2 code is ugly present in the capture pipeline setup/disable
routions with '#ifdef CONFIG_MXC_MIPI_CSI2/#endif' protected. Whenever
it finds mipi_csi2_info is not gotten correctly, it will return error to
callers. This breaks the normally routines in which mipi csi2 is not used
and mipi csi2 driver is disabled in its devicetree node(but with the
Kconfig CONFIG_MXC_MIPI_CSI2 defined). A real example is the capture
feature on the MX6 Sabreauto platforms. We have only parallel CSI input
on it and the mipi csi2 driver is disabled in its devicetree node but with
the Kconfig CONFIG_MXC_MIPI_CSI2 defined. So, a reasonable choice at present
is not to return error if mipi_csi2_info cannot be gotten, though we could
eventually re-organize the capture code for a better total solution in the
future.
Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
6 files changed, 6 insertions, 54 deletions
diff --git a/drivers/media/platform/mxc/capture/ipu_bg_overlay_sdc.c b/drivers/media/platform/mxc/capture/ipu_bg_overlay_sdc.c index ad5e1c860e01..4a975b54a977 100644 --- a/drivers/media/platform/mxc/capture/ipu_bg_overlay_sdc.c +++ b/drivers/media/platform/mxc/capture/ipu_bg_overlay_sdc.c | |||
@@ -1,6 +1,6 @@ | |||
1 | 1 | ||
2 | /* | 2 | /* |
3 | * Copyright 2004-2013 Freescale Semiconductor, Inc. All Rights Reserved. | 3 | * Copyright 2004-2014 Freescale Semiconductor, Inc. All Rights Reserved. |
4 | */ | 4 | */ |
5 | 5 | ||
6 | /* | 6 | /* |
@@ -189,10 +189,6 @@ static int csi_enc_setup(cam_data *cam) | |||
189 | params.csi_mem.mipi_vc = 0; | 189 | params.csi_mem.mipi_vc = 0; |
190 | params.csi_mem.mipi_id = 0; | 190 | params.csi_mem.mipi_id = 0; |
191 | } | 191 | } |
192 | } else { | ||
193 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
194 | __func__, __FILE__); | ||
195 | return -EPERM; | ||
196 | } | 192 | } |
197 | #endif | 193 | #endif |
198 | 194 | ||
@@ -411,10 +407,6 @@ static int bg_overlay_stop(void *private) | |||
411 | && cam->csi == csi_id) | 407 | && cam->csi == csi_id) |
412 | mipi_csi2_pixelclk_disable(mipi_csi2_info); | 408 | mipi_csi2_pixelclk_disable(mipi_csi2_info); |
413 | } | 409 | } |
414 | } else { | ||
415 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
416 | __func__, __FILE__); | ||
417 | return -EPERM; | ||
418 | } | 410 | } |
419 | #endif | 411 | #endif |
420 | 412 | ||
diff --git a/drivers/media/platform/mxc/capture/ipu_csi_enc.c b/drivers/media/platform/mxc/capture/ipu_csi_enc.c index 4752f7701c04..fb3c6a24322a 100644 --- a/drivers/media/platform/mxc/capture/ipu_csi_enc.c +++ b/drivers/media/platform/mxc/capture/ipu_csi_enc.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright 2009-2013 Freescale Semiconductor, Inc. All Rights Reserved. | 2 | * Copyright 2009-2014 Freescale Semiconductor, Inc. All Rights Reserved. |
3 | */ | 3 | */ |
4 | 4 | ||
5 | /* | 5 | /* |
@@ -157,10 +157,6 @@ static int csi_enc_setup(cam_data *cam) | |||
157 | params.csi_mem.mipi_vc = 0; | 157 | params.csi_mem.mipi_vc = 0; |
158 | params.csi_mem.mipi_id = 0; | 158 | params.csi_mem.mipi_id = 0; |
159 | } | 159 | } |
160 | } else { | ||
161 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
162 | __func__, __FILE__); | ||
163 | return -EPERM; | ||
164 | } | 160 | } |
165 | #endif | 161 | #endif |
166 | 162 | ||
@@ -309,10 +305,6 @@ static int csi_enc_disabling_tasks(void *private) | |||
309 | && cam->csi == csi_id) | 305 | && cam->csi == csi_id) |
310 | mipi_csi2_pixelclk_disable(mipi_csi2_info); | 306 | mipi_csi2_pixelclk_disable(mipi_csi2_info); |
311 | } | 307 | } |
312 | } else { | ||
313 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
314 | __func__, __FILE__); | ||
315 | return -EPERM; | ||
316 | } | 308 | } |
317 | #endif | 309 | #endif |
318 | 310 | ||
diff --git a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c index 416b40b8046c..80136156ceaf 100644 --- a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c +++ b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright 2004-2013 Freescale Semiconductor, Inc. All Rights Reserved. | 2 | * Copyright 2004-2014 Freescale Semiconductor, Inc. All Rights Reserved. |
3 | */ | 3 | */ |
4 | /* * The code contained herein is licensed under the GNU General Public | 4 | /* * The code contained herein is licensed under the GNU General Public |
5 | * License. You may obtain a copy of the GNU General Public License | 5 | * License. You may obtain a copy of the GNU General Public License |
@@ -195,10 +195,6 @@ static int csi_enc_setup(cam_data *cam) | |||
195 | params.csi_mem.mipi_vc = 0; | 195 | params.csi_mem.mipi_vc = 0; |
196 | params.csi_mem.mipi_id = 0; | 196 | params.csi_mem.mipi_id = 0; |
197 | } | 197 | } |
198 | } else { | ||
199 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
200 | __func__, __FILE__); | ||
201 | return -EPERM; | ||
202 | } | 198 | } |
203 | #endif | 199 | #endif |
204 | 200 | ||
@@ -508,10 +504,6 @@ static int foreground_stop(void *private) | |||
508 | && cam->csi == csi_id) | 504 | && cam->csi == csi_id) |
509 | mipi_csi2_pixelclk_disable(mipi_csi2_info); | 505 | mipi_csi2_pixelclk_disable(mipi_csi2_info); |
510 | } | 506 | } |
511 | } else { | ||
512 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
513 | __func__, __FILE__); | ||
514 | return -EPERM; | ||
515 | } | 507 | } |
516 | #endif | 508 | #endif |
517 | 509 | ||
diff --git a/drivers/media/platform/mxc/capture/ipu_prp_enc.c b/drivers/media/platform/mxc/capture/ipu_prp_enc.c index c16312761d7d..af419e356e6d 100644 --- a/drivers/media/platform/mxc/capture/ipu_prp_enc.c +++ b/drivers/media/platform/mxc/capture/ipu_prp_enc.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright 2004-2013 Freescale Semiconductor, Inc. All Rights Reserved. | 2 | * Copyright 2004-2014 Freescale Semiconductor, Inc. All Rights Reserved. |
3 | */ | 3 | */ |
4 | 4 | ||
5 | /* | 5 | /* |
@@ -161,10 +161,6 @@ static int prp_enc_setup(cam_data *cam) | |||
161 | enc.csi_prp_enc_mem.mipi_vc = 0; | 161 | enc.csi_prp_enc_mem.mipi_vc = 0; |
162 | enc.csi_prp_enc_mem.mipi_id = 0; | 162 | enc.csi_prp_enc_mem.mipi_id = 0; |
163 | } | 163 | } |
164 | } else { | ||
165 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
166 | __func__, __FILE__); | ||
167 | return -EPERM; | ||
168 | } | 164 | } |
169 | #endif | 165 | #endif |
170 | 166 | ||
@@ -471,10 +467,6 @@ static int prp_enc_disabling_tasks(void *private) | |||
471 | && cam->csi == csi_id) | 467 | && cam->csi == csi_id) |
472 | mipi_csi2_pixelclk_disable(mipi_csi2_info); | 468 | mipi_csi2_pixelclk_disable(mipi_csi2_info); |
473 | } | 469 | } |
474 | } else { | ||
475 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
476 | __func__, __FILE__); | ||
477 | return -EPERM; | ||
478 | } | 470 | } |
479 | #endif | 471 | #endif |
480 | 472 | ||
diff --git a/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c b/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c index 8bf5344df684..b9610f1ed820 100644 --- a/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c +++ b/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright 2004-2013 Freescale Semiconductor, Inc. All Rights Reserved. | 2 | * Copyright 2004-2014 Freescale Semiconductor, Inc. All Rights Reserved. |
3 | */ | 3 | */ |
4 | /* * The code contained herein is licensed under the GNU General Public | 4 | /* * The code contained herein is licensed under the GNU General Public |
5 | * License. You may obtain a copy of the GNU General Public License | 5 | * License. You may obtain a copy of the GNU General Public License |
@@ -196,10 +196,6 @@ static int prpvf_start(void *private) | |||
196 | vf.csi_prp_vf_mem.mipi_vc = 0; | 196 | vf.csi_prp_vf_mem.mipi_vc = 0; |
197 | vf.csi_prp_vf_mem.mipi_id = 0; | 197 | vf.csi_prp_vf_mem.mipi_id = 0; |
198 | } | 198 | } |
199 | } else { | ||
200 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
201 | __func__, __FILE__); | ||
202 | return -EPERM; | ||
203 | } | 199 | } |
204 | #endif | 200 | #endif |
205 | 201 | ||
@@ -458,10 +454,6 @@ static int prpvf_stop(void *private) | |||
458 | && cam->csi == csi_id) | 454 | && cam->csi == csi_id) |
459 | mipi_csi2_pixelclk_disable(mipi_csi2_info); | 455 | mipi_csi2_pixelclk_disable(mipi_csi2_info); |
460 | } | 456 | } |
461 | } else { | ||
462 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
463 | __func__, __FILE__); | ||
464 | return -EPERM; | ||
465 | } | 457 | } |
466 | #endif | 458 | #endif |
467 | 459 | ||
diff --git a/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc_bg.c b/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc_bg.c index 2667fca81a76..a24d82dfca63 100644 --- a/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc_bg.c +++ b/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc_bg.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright 2004-2013 Freescale Semiconductor, Inc. All Rights Reserved. | 2 | * Copyright 2004-2014 Freescale Semiconductor, Inc. All Rights Reserved. |
3 | */ | 3 | */ |
4 | 4 | ||
5 | /* | 5 | /* |
@@ -181,10 +181,6 @@ static int prpvf_start(void *private) | |||
181 | vf.csi_prp_vf_mem.mipi_vc = 0; | 181 | vf.csi_prp_vf_mem.mipi_vc = 0; |
182 | vf.csi_prp_vf_mem.mipi_id = 0; | 182 | vf.csi_prp_vf_mem.mipi_id = 0; |
183 | } | 183 | } |
184 | } else { | ||
185 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
186 | __func__, __FILE__); | ||
187 | return -EPERM; | ||
188 | } | 184 | } |
189 | #endif | 185 | #endif |
190 | 186 | ||
@@ -387,10 +383,6 @@ static int prpvf_stop(void *private) | |||
387 | && cam->csi == csi_id) | 383 | && cam->csi == csi_id) |
388 | mipi_csi2_pixelclk_disable(mipi_csi2_info); | 384 | mipi_csi2_pixelclk_disable(mipi_csi2_info); |
389 | } | 385 | } |
390 | } else { | ||
391 | printk(KERN_ERR "%s() in %s: Fail to get mipi_csi2_info!\n", | ||
392 | __func__, __FILE__); | ||
393 | return -EPERM; | ||
394 | } | 386 | } |
395 | #endif | 387 | #endif |
396 | 388 | ||