diff options
author | Liu Bo <bo.li.liu@oracle.com> | 2013-03-14 10:57:45 -0400 |
---|---|---|
committer | Josef Bacik <jbacik@fusionio.com> | 2013-05-06 15:54:14 -0400 |
commit | b0496686ba0da69cfd2433ef55fb2d1dc7465084 (patch) | |
tree | 78239a9c6f3a7015416f261968a8bbc359c067a8 | |
parent | 087488109afb4cc1bbdd3557779129c34045609a (diff) |
Btrfs: cleanup unused arguments of btrfs_csum_data
Argument 'root' is no more used in btrfs_csum_data().
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
-rw-r--r-- | fs/btrfs/compression.c | 3 | ||||
-rw-r--r-- | fs/btrfs/disk-io.c | 6 | ||||
-rw-r--r-- | fs/btrfs/disk-io.h | 2 | ||||
-rw-r--r-- | fs/btrfs/file-item.c | 3 | ||||
-rw-r--r-- | fs/btrfs/free-space-cache.c | 4 | ||||
-rw-r--r-- | fs/btrfs/inode.c | 5 | ||||
-rw-r--r-- | fs/btrfs/scrub.c | 13 |
7 files changed, 15 insertions, 21 deletions
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index 15b94089abc4..b9c565028605 100644 --- a/fs/btrfs/compression.c +++ b/fs/btrfs/compression.c | |||
@@ -106,7 +106,6 @@ static int check_compressed_csum(struct inode *inode, | |||
106 | u64 disk_start) | 106 | u64 disk_start) |
107 | { | 107 | { |
108 | int ret; | 108 | int ret; |
109 | struct btrfs_root *root = BTRFS_I(inode)->root; | ||
110 | struct page *page; | 109 | struct page *page; |
111 | unsigned long i; | 110 | unsigned long i; |
112 | char *kaddr; | 111 | char *kaddr; |
@@ -121,7 +120,7 @@ static int check_compressed_csum(struct inode *inode, | |||
121 | csum = ~(u32)0; | 120 | csum = ~(u32)0; |
122 | 121 | ||
123 | kaddr = kmap_atomic(page); | 122 | kaddr = kmap_atomic(page); |
124 | csum = btrfs_csum_data(root, kaddr, csum, PAGE_CACHE_SIZE); | 123 | csum = btrfs_csum_data(kaddr, csum, PAGE_CACHE_SIZE); |
125 | btrfs_csum_final(csum, (char *)&csum); | 124 | btrfs_csum_final(csum, (char *)&csum); |
126 | kunmap_atomic(kaddr); | 125 | kunmap_atomic(kaddr); |
127 | 126 | ||
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 6d19a0a554aa..7bb28691ed98 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c | |||
@@ -238,7 +238,7 @@ out: | |||
238 | return em; | 238 | return em; |
239 | } | 239 | } |
240 | 240 | ||
241 | u32 btrfs_csum_data(struct btrfs_root *root, char *data, u32 seed, size_t len) | 241 | u32 btrfs_csum_data(char *data, u32 seed, size_t len) |
242 | { | 242 | { |
243 | return crc32c(seed, data, len); | 243 | return crc32c(seed, data, len); |
244 | } | 244 | } |
@@ -274,7 +274,7 @@ static int csum_tree_block(struct btrfs_root *root, struct extent_buffer *buf, | |||
274 | if (err) | 274 | if (err) |
275 | return 1; | 275 | return 1; |
276 | cur_len = min(len, map_len - (offset - map_start)); | 276 | cur_len = min(len, map_len - (offset - map_start)); |
277 | crc = btrfs_csum_data(root, kaddr + offset - map_start, | 277 | crc = btrfs_csum_data(kaddr + offset - map_start, |
278 | crc, cur_len); | 278 | crc, cur_len); |
279 | len -= cur_len; | 279 | len -= cur_len; |
280 | offset += cur_len; | 280 | offset += cur_len; |
@@ -2919,7 +2919,7 @@ static int write_dev_supers(struct btrfs_device *device, | |||
2919 | btrfs_set_super_bytenr(sb, bytenr); | 2919 | btrfs_set_super_bytenr(sb, bytenr); |
2920 | 2920 | ||
2921 | crc = ~(u32)0; | 2921 | crc = ~(u32)0; |
2922 | crc = btrfs_csum_data(NULL, (char *)sb + | 2922 | crc = btrfs_csum_data((char *)sb + |
2923 | BTRFS_CSUM_SIZE, crc, | 2923 | BTRFS_CSUM_SIZE, crc, |
2924 | BTRFS_SUPER_INFO_SIZE - | 2924 | BTRFS_SUPER_INFO_SIZE - |
2925 | BTRFS_CSUM_SIZE); | 2925 | BTRFS_CSUM_SIZE); |
diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h index 853c91d7212b..85c23e6c8fec 100644 --- a/fs/btrfs/disk-io.h +++ b/fs/btrfs/disk-io.h | |||
@@ -77,7 +77,7 @@ int btrfs_buffer_uptodate(struct extent_buffer *buf, u64 parent_transid, | |||
77 | int atomic); | 77 | int atomic); |
78 | int btrfs_set_buffer_uptodate(struct extent_buffer *buf); | 78 | int btrfs_set_buffer_uptodate(struct extent_buffer *buf); |
79 | int btrfs_read_buffer(struct extent_buffer *buf, u64 parent_transid); | 79 | int btrfs_read_buffer(struct extent_buffer *buf, u64 parent_transid); |
80 | u32 btrfs_csum_data(struct btrfs_root *root, char *data, u32 seed, size_t len); | 80 | u32 btrfs_csum_data(char *data, u32 seed, size_t len); |
81 | void btrfs_csum_final(u32 crc, char *result); | 81 | void btrfs_csum_final(u32 crc, char *result); |
82 | int btrfs_bio_wq_end_io(struct btrfs_fs_info *info, struct bio *bio, | 82 | int btrfs_bio_wq_end_io(struct btrfs_fs_info *info, struct bio *bio, |
83 | int metadata); | 83 | int metadata); |
diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c index c4628a201cb3..bc3c92466045 100644 --- a/fs/btrfs/file-item.c +++ b/fs/btrfs/file-item.c | |||
@@ -484,8 +484,7 @@ int btrfs_csum_one_bio(struct btrfs_root *root, struct inode *inode, | |||
484 | 484 | ||
485 | data = kmap_atomic(bvec->bv_page); | 485 | data = kmap_atomic(bvec->bv_page); |
486 | sector_sum->sum = ~(u32)0; | 486 | sector_sum->sum = ~(u32)0; |
487 | sector_sum->sum = btrfs_csum_data(root, | 487 | sector_sum->sum = btrfs_csum_data(data + bvec->bv_offset, |
488 | data + bvec->bv_offset, | ||
489 | sector_sum->sum, | 488 | sector_sum->sum, |
490 | bvec->bv_len); | 489 | bvec->bv_len); |
491 | kunmap_atomic(data); | 490 | kunmap_atomic(data); |
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index 1d80afa6d3db..6be083b6433e 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c | |||
@@ -431,7 +431,7 @@ static void io_ctl_set_crc(struct io_ctl *io_ctl, int index) | |||
431 | if (index == 0) | 431 | if (index == 0) |
432 | offset = sizeof(u32) * io_ctl->num_pages; | 432 | offset = sizeof(u32) * io_ctl->num_pages; |
433 | 433 | ||
434 | crc = btrfs_csum_data(io_ctl->root, io_ctl->orig + offset, crc, | 434 | crc = btrfs_csum_data(io_ctl->orig + offset, crc, |
435 | PAGE_CACHE_SIZE - offset); | 435 | PAGE_CACHE_SIZE - offset); |
436 | btrfs_csum_final(crc, (char *)&crc); | 436 | btrfs_csum_final(crc, (char *)&crc); |
437 | io_ctl_unmap_page(io_ctl); | 437 | io_ctl_unmap_page(io_ctl); |
@@ -461,7 +461,7 @@ static int io_ctl_check_crc(struct io_ctl *io_ctl, int index) | |||
461 | kunmap(io_ctl->pages[0]); | 461 | kunmap(io_ctl->pages[0]); |
462 | 462 | ||
463 | io_ctl_map_page(io_ctl, 0); | 463 | io_ctl_map_page(io_ctl, 0); |
464 | crc = btrfs_csum_data(io_ctl->root, io_ctl->orig + offset, crc, | 464 | crc = btrfs_csum_data(io_ctl->orig + offset, crc, |
465 | PAGE_CACHE_SIZE - offset); | 465 | PAGE_CACHE_SIZE - offset); |
466 | btrfs_csum_final(crc, (char *)&crc); | 466 | btrfs_csum_final(crc, (char *)&crc); |
467 | if (val != crc) { | 467 | if (val != crc) { |
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 09c58a35b429..24e8a356a36c 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c | |||
@@ -2819,7 +2819,7 @@ static int btrfs_readpage_end_io_hook(struct page *page, u64 start, u64 end, | |||
2819 | if (ret) | 2819 | if (ret) |
2820 | goto zeroit; | 2820 | goto zeroit; |
2821 | 2821 | ||
2822 | csum = btrfs_csum_data(root, kaddr + offset, csum, end - start + 1); | 2822 | csum = btrfs_csum_data(kaddr + offset, csum, end - start + 1); |
2823 | btrfs_csum_final(csum, (char *)&csum); | 2823 | btrfs_csum_final(csum, (char *)&csum); |
2824 | if (csum != private) | 2824 | if (csum != private) |
2825 | goto zeroit; | 2825 | goto zeroit; |
@@ -6919,7 +6919,6 @@ static void btrfs_endio_direct_read(struct bio *bio, int err) | |||
6919 | struct bio_vec *bvec_end = bio->bi_io_vec + bio->bi_vcnt - 1; | 6919 | struct bio_vec *bvec_end = bio->bi_io_vec + bio->bi_vcnt - 1; |
6920 | struct bio_vec *bvec = bio->bi_io_vec; | 6920 | struct bio_vec *bvec = bio->bi_io_vec; |
6921 | struct inode *inode = dip->inode; | 6921 | struct inode *inode = dip->inode; |
6922 | struct btrfs_root *root = BTRFS_I(inode)->root; | ||
6923 | u64 start; | 6922 | u64 start; |
6924 | 6923 | ||
6925 | start = dip->logical_offset; | 6924 | start = dip->logical_offset; |
@@ -6936,7 +6935,7 @@ static void btrfs_endio_direct_read(struct bio *bio, int err) | |||
6936 | goto failed; | 6935 | goto failed; |
6937 | local_irq_save(flags); | 6936 | local_irq_save(flags); |
6938 | kaddr = kmap_atomic(page); | 6937 | kaddr = kmap_atomic(page); |
6939 | csum = btrfs_csum_data(root, kaddr + bvec->bv_offset, | 6938 | csum = btrfs_csum_data(kaddr + bvec->bv_offset, |
6940 | csum, bvec->bv_len); | 6939 | csum, bvec->bv_len); |
6941 | btrfs_csum_final(csum, (char *)&csum); | 6940 | btrfs_csum_final(csum, (char *)&csum); |
6942 | kunmap_atomic(kaddr); | 6941 | kunmap_atomic(kaddr); |
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index 85e072b956d5..3d29d60bdaf8 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c | |||
@@ -1336,7 +1336,6 @@ static void scrub_recheck_block_checksum(struct btrfs_fs_info *fs_info, | |||
1336 | int page_num; | 1336 | int page_num; |
1337 | u8 calculated_csum[BTRFS_CSUM_SIZE]; | 1337 | u8 calculated_csum[BTRFS_CSUM_SIZE]; |
1338 | u32 crc = ~(u32)0; | 1338 | u32 crc = ~(u32)0; |
1339 | struct btrfs_root *root = fs_info->extent_root; | ||
1340 | void *mapped_buffer; | 1339 | void *mapped_buffer; |
1341 | 1340 | ||
1342 | WARN_ON(!sblock->pagev[0]->page); | 1341 | WARN_ON(!sblock->pagev[0]->page); |
@@ -1365,12 +1364,11 @@ static void scrub_recheck_block_checksum(struct btrfs_fs_info *fs_info, | |||
1365 | 1364 | ||
1366 | for (page_num = 0;;) { | 1365 | for (page_num = 0;;) { |
1367 | if (page_num == 0 && is_metadata) | 1366 | if (page_num == 0 && is_metadata) |
1368 | crc = btrfs_csum_data(root, | 1367 | crc = btrfs_csum_data( |
1369 | ((u8 *)mapped_buffer) + BTRFS_CSUM_SIZE, | 1368 | ((u8 *)mapped_buffer) + BTRFS_CSUM_SIZE, |
1370 | crc, PAGE_SIZE - BTRFS_CSUM_SIZE); | 1369 | crc, PAGE_SIZE - BTRFS_CSUM_SIZE); |
1371 | else | 1370 | else |
1372 | crc = btrfs_csum_data(root, mapped_buffer, crc, | 1371 | crc = btrfs_csum_data(mapped_buffer, crc, PAGE_SIZE); |
1373 | PAGE_SIZE); | ||
1374 | 1372 | ||
1375 | kunmap_atomic(mapped_buffer); | 1373 | kunmap_atomic(mapped_buffer); |
1376 | page_num++; | 1374 | page_num++; |
@@ -1657,7 +1655,6 @@ static int scrub_checksum_data(struct scrub_block *sblock) | |||
1657 | void *buffer; | 1655 | void *buffer; |
1658 | u32 crc = ~(u32)0; | 1656 | u32 crc = ~(u32)0; |
1659 | int fail = 0; | 1657 | int fail = 0; |
1660 | struct btrfs_root *root = sctx->dev_root; | ||
1661 | u64 len; | 1658 | u64 len; |
1662 | int index; | 1659 | int index; |
1663 | 1660 | ||
@@ -1674,7 +1671,7 @@ static int scrub_checksum_data(struct scrub_block *sblock) | |||
1674 | for (;;) { | 1671 | for (;;) { |
1675 | u64 l = min_t(u64, len, PAGE_SIZE); | 1672 | u64 l = min_t(u64, len, PAGE_SIZE); |
1676 | 1673 | ||
1677 | crc = btrfs_csum_data(root, buffer, crc, l); | 1674 | crc = btrfs_csum_data(buffer, crc, l); |
1678 | kunmap_atomic(buffer); | 1675 | kunmap_atomic(buffer); |
1679 | len -= l; | 1676 | len -= l; |
1680 | if (len == 0) | 1677 | if (len == 0) |
@@ -1744,7 +1741,7 @@ static int scrub_checksum_tree_block(struct scrub_block *sblock) | |||
1744 | for (;;) { | 1741 | for (;;) { |
1745 | u64 l = min_t(u64, len, mapped_size); | 1742 | u64 l = min_t(u64, len, mapped_size); |
1746 | 1743 | ||
1747 | crc = btrfs_csum_data(root, p, crc, l); | 1744 | crc = btrfs_csum_data(p, crc, l); |
1748 | kunmap_atomic(mapped_buffer); | 1745 | kunmap_atomic(mapped_buffer); |
1749 | len -= l; | 1746 | len -= l; |
1750 | if (len == 0) | 1747 | if (len == 0) |
@@ -1805,7 +1802,7 @@ static int scrub_checksum_super(struct scrub_block *sblock) | |||
1805 | for (;;) { | 1802 | for (;;) { |
1806 | u64 l = min_t(u64, len, mapped_size); | 1803 | u64 l = min_t(u64, len, mapped_size); |
1807 | 1804 | ||
1808 | crc = btrfs_csum_data(root, p, crc, l); | 1805 | crc = btrfs_csum_data(p, crc, l); |
1809 | kunmap_atomic(mapped_buffer); | 1806 | kunmap_atomic(mapped_buffer); |
1810 | len -= l; | 1807 | len -= l; |
1811 | if (len == 0) | 1808 | if (len == 0) |