diff options
author | Linus Walleij <linus.walleij@linaro.org> | 2012-12-20 04:20:15 -0500 |
---|---|---|
committer | Samuel Ortiz <sameo@linux.intel.com> | 2013-01-21 19:25:56 -0500 |
commit | 89d9b1c99374997d68910ba49d5b7df80e7f2061 (patch) | |
tree | b75c26777037141fbb6ad1d720f56e1cf12fb1be | |
parent | ee487114f0274ed62c92a727787cd6fa4d465157 (diff) |
mfd: db8500-prcmu: Fix irqdomain usage
This fixes two issues with the DB8500 PRCMU irqdomain:
- You have to state the irq base 0 to get a linear domain
for the DT case from irq_domain_add_simple()
- The irqdomain was not used to translate the initial irq
request using irq_create_mapping() making the linear
case fail as it was lacking a proper descriptor.
I took this opportunity to fix two lines of whitespace
errors in related code as I was anyway messing around with
it.
Cc: stable@kernel.org
Acked-by Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
-rw-r--r-- | drivers/mfd/db8500-prcmu.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c index dc8826d8d69d..268f45d42394 100644 --- a/drivers/mfd/db8500-prcmu.c +++ b/drivers/mfd/db8500-prcmu.c | |||
@@ -2524,7 +2524,7 @@ static bool read_mailbox_0(void) | |||
2524 | 2524 | ||
2525 | for (n = 0; n < NUM_PRCMU_WAKEUPS; n++) { | 2525 | for (n = 0; n < NUM_PRCMU_WAKEUPS; n++) { |
2526 | if (ev & prcmu_irq_bit[n]) | 2526 | if (ev & prcmu_irq_bit[n]) |
2527 | generic_handle_irq(IRQ_PRCMU_BASE + n); | 2527 | generic_handle_irq(irq_find_mapping(db8500_irq_domain, n)); |
2528 | } | 2528 | } |
2529 | r = true; | 2529 | r = true; |
2530 | break; | 2530 | break; |
@@ -2737,13 +2737,14 @@ static int db8500_irq_map(struct irq_domain *d, unsigned int virq, | |||
2737 | } | 2737 | } |
2738 | 2738 | ||
2739 | static struct irq_domain_ops db8500_irq_ops = { | 2739 | static struct irq_domain_ops db8500_irq_ops = { |
2740 | .map = db8500_irq_map, | 2740 | .map = db8500_irq_map, |
2741 | .xlate = irq_domain_xlate_twocell, | 2741 | .xlate = irq_domain_xlate_twocell, |
2742 | }; | 2742 | }; |
2743 | 2743 | ||
2744 | static int db8500_irq_init(struct device_node *np) | 2744 | static int db8500_irq_init(struct device_node *np) |
2745 | { | 2745 | { |
2746 | int irq_base = -1; | 2746 | int irq_base = 0; |
2747 | int i; | ||
2747 | 2748 | ||
2748 | /* In the device tree case, just take some IRQs */ | 2749 | /* In the device tree case, just take some IRQs */ |
2749 | if (!np) | 2750 | if (!np) |
@@ -2758,6 +2759,10 @@ static int db8500_irq_init(struct device_node *np) | |||
2758 | return -ENOSYS; | 2759 | return -ENOSYS; |
2759 | } | 2760 | } |
2760 | 2761 | ||
2762 | /* All wakeups will be used, so create mappings for all */ | ||
2763 | for (i = 0; i < NUM_PRCMU_WAKEUPS; i++) | ||
2764 | irq_create_mapping(db8500_irq_domain, i); | ||
2765 | |||
2761 | return 0; | 2766 | return 0; |
2762 | } | 2767 | } |
2763 | 2768 | ||