aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Huewe <peterhuewe@gmx.de>2012-11-29 16:08:41 -0500
committerKent Yoder <key@linux.vnet.ibm.com>2013-02-05 10:38:22 -0500
commit73249695f0cb10bb9fc8b294f3f8c4b001889e42 (patch)
treee674bcf6bfac8d5dacb57b5131c7670d9c742c59
parent348df8db301d9fa01fb51e5eaca1e9f3b27bd4c8 (diff)
char/tpm: Use true and false for bools
Bool initializations should use true and false. Bool tests don't need comparisons. Based on contributions from Joe Perches, Rusty Russell and Bruce W Allan. The semantic patch that makes this output is available in scripts/coccinelle/misc/boolinit.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Kent Yoder <key@linux.vnet.ibm.com>
-rw-r--r--drivers/char/tpm/tpm_tis.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index ea31dafbcac2..74ce2d1f08b4 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -374,7 +374,7 @@ static int probe_itpm(struct tpm_chip *chip)
374 if (vendor != TPM_VID_INTEL) 374 if (vendor != TPM_VID_INTEL)
375 return 0; 375 return 0;
376 376
377 itpm = 0; 377 itpm = false;
378 378
379 rc = tpm_tis_send_data(chip, cmd_getticks, len); 379 rc = tpm_tis_send_data(chip, cmd_getticks, len);
380 if (rc == 0) 380 if (rc == 0)
@@ -383,7 +383,7 @@ static int probe_itpm(struct tpm_chip *chip)
383 tpm_tis_ready(chip); 383 tpm_tis_ready(chip);
384 release_locality(chip, chip->vendor.locality, 0); 384 release_locality(chip, chip->vendor.locality, 0);
385 385
386 itpm = 1; 386 itpm = true;
387 387
388 rc = tpm_tis_send_data(chip, cmd_getticks, len); 388 rc = tpm_tis_send_data(chip, cmd_getticks, len);
389 if (rc == 0) { 389 if (rc == 0) {
@@ -502,7 +502,7 @@ static irqreturn_t tis_int_handler(int dummy, void *dev_id)
502 return IRQ_HANDLED; 502 return IRQ_HANDLED;
503} 503}
504 504
505static bool interrupts = 1; 505static bool interrupts = true;
506module_param(interrupts, bool, 0444); 506module_param(interrupts, bool, 0444);
507MODULE_PARM_DESC(interrupts, "Enable interrupts"); 507MODULE_PARM_DESC(interrupts, "Enable interrupts");
508 508
@@ -545,7 +545,7 @@ static int tpm_tis_init(struct device *dev, resource_size_t start,
545 rc = -ENODEV; 545 rc = -ENODEV;
546 goto out_err; 546 goto out_err;
547 } 547 }
548 itpm = (probe == 0) ? 0 : 1; 548 itpm = !!probe;
549 } 549 }
550 550
551 if (itpm) 551 if (itpm)
@@ -741,10 +741,10 @@ static int tpm_tis_pnp_init(struct pnp_dev *pnp_dev,
741 if (pnp_irq_valid(pnp_dev, 0)) 741 if (pnp_irq_valid(pnp_dev, 0))
742 irq = pnp_irq(pnp_dev, 0); 742 irq = pnp_irq(pnp_dev, 0);
743 else 743 else
744 interrupts = 0; 744 interrupts = false;
745 745
746 if (is_itpm(pnp_dev)) 746 if (is_itpm(pnp_dev))
747 itpm = 1; 747 itpm = true;
748 748
749 return tpm_tis_init(&pnp_dev->dev, start, len, irq); 749 return tpm_tis_init(&pnp_dev->dev, start, len, irq);
750} 750}