diff options
| author | Russell King <rmk+kernel@arm.linux.org.uk> | 2011-10-31 10:34:31 -0400 |
|---|---|---|
| committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2011-11-17 12:09:30 -0500 |
| commit | 6a6f1efaced2ca7f8cd581a220af428c6bfc909d (patch) | |
| tree | e1059901f3972c5870831cb301a131c953bd7464 | |
| parent | 1ea6b8f48918282bdca0b32a34095504ee65bab5 (diff) | |
ARM: restart: remove local_irq_disable() from within arch_reset()
IRQs are already disabled by the time arch_reset() is called, so these
calls to local_irq_disable() instead arch_reset() are redundant. Remove
them.
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
| -rw-r--r-- | arch/arm/mach-ep93xx/include/mach/system.h | 2 | ||||
| -rw-r--r-- | arch/arm/mach-iop32x/include/mach/system.h | 2 | ||||
| -rw-r--r-- | arch/arm/mach-ixp2000/include/mach/system.h | 2 | ||||
| -rw-r--r-- | arch/arm/mach-lpc32xx/include/mach/system.h | 3 | ||||
| -rw-r--r-- | arch/arm/mach-shark/core.c | 1 | ||||
| -rw-r--r-- | arch/arm/mach-u300/include/mach/system.h | 2 |
6 files changed, 0 insertions, 12 deletions
diff --git a/arch/arm/mach-ep93xx/include/mach/system.h b/arch/arm/mach-ep93xx/include/mach/system.h index 6d661fe9d66c..bdf6c4f1feef 100644 --- a/arch/arm/mach-ep93xx/include/mach/system.h +++ b/arch/arm/mach-ep93xx/include/mach/system.h | |||
| @@ -11,8 +11,6 @@ static inline void arch_idle(void) | |||
| 11 | 11 | ||
| 12 | static inline void arch_reset(char mode, const char *cmd) | 12 | static inline void arch_reset(char mode, const char *cmd) |
| 13 | { | 13 | { |
| 14 | local_irq_disable(); | ||
| 15 | |||
| 16 | /* | 14 | /* |
| 17 | * Set then clear the SWRST bit to initiate a software reset | 15 | * Set then clear the SWRST bit to initiate a software reset |
| 18 | */ | 16 | */ |
diff --git a/arch/arm/mach-iop32x/include/mach/system.h b/arch/arm/mach-iop32x/include/mach/system.h index a4b808fe0d81..5987196b89c4 100644 --- a/arch/arm/mach-iop32x/include/mach/system.h +++ b/arch/arm/mach-iop32x/include/mach/system.h | |||
| @@ -18,8 +18,6 @@ static inline void arch_idle(void) | |||
| 18 | 18 | ||
| 19 | static inline void arch_reset(char mode, const char *cmd) | 19 | static inline void arch_reset(char mode, const char *cmd) |
| 20 | { | 20 | { |
| 21 | local_irq_disable(); | ||
| 22 | |||
| 23 | if (machine_is_n2100()) { | 21 | if (machine_is_n2100()) { |
| 24 | gpio_line_set(N2100_HARDWARE_RESET, GPIO_LOW); | 22 | gpio_line_set(N2100_HARDWARE_RESET, GPIO_LOW); |
| 25 | gpio_line_config(N2100_HARDWARE_RESET, GPIO_OUT); | 23 | gpio_line_config(N2100_HARDWARE_RESET, GPIO_OUT); |
diff --git a/arch/arm/mach-ixp2000/include/mach/system.h b/arch/arm/mach-ixp2000/include/mach/system.h index de370992c848..810df7b93982 100644 --- a/arch/arm/mach-ixp2000/include/mach/system.h +++ b/arch/arm/mach-ixp2000/include/mach/system.h | |||
| @@ -19,8 +19,6 @@ static inline void arch_idle(void) | |||
| 19 | 19 | ||
| 20 | static inline void arch_reset(char mode, const char *cmd) | 20 | static inline void arch_reset(char mode, const char *cmd) |
| 21 | { | 21 | { |
| 22 | local_irq_disable(); | ||
| 23 | |||
| 24 | /* | 22 | /* |
| 25 | * Reset flash banking register so that we are pointing at | 23 | * Reset flash banking register so that we are pointing at |
| 26 | * RedBoot bank. | 24 | * RedBoot bank. |
diff --git a/arch/arm/mach-lpc32xx/include/mach/system.h b/arch/arm/mach-lpc32xx/include/mach/system.h index df3b0dea4d7b..d47f3b1c24b8 100644 --- a/arch/arm/mach-lpc32xx/include/mach/system.h +++ b/arch/arm/mach-lpc32xx/include/mach/system.h | |||
| @@ -33,9 +33,6 @@ static inline void arch_reset(char mode, const char *cmd) | |||
| 33 | case 'h': | 33 | case 'h': |
| 34 | printk(KERN_CRIT "RESET: Rebooting system\n"); | 34 | printk(KERN_CRIT "RESET: Rebooting system\n"); |
| 35 | 35 | ||
| 36 | /* Disable interrupts */ | ||
| 37 | local_irq_disable(); | ||
| 38 | |||
| 39 | lpc32xx_watchdog_reset(); | 36 | lpc32xx_watchdog_reset(); |
| 40 | break; | 37 | break; |
| 41 | 38 | ||
diff --git a/arch/arm/mach-shark/core.c b/arch/arm/mach-shark/core.c index feda3ca7fc95..f4b25d875f3d 100644 --- a/arch/arm/mach-shark/core.c +++ b/arch/arm/mach-shark/core.c | |||
| @@ -29,7 +29,6 @@ | |||
| 29 | void arch_reset(char mode, const char *cmd) | 29 | void arch_reset(char mode, const char *cmd) |
| 30 | { | 30 | { |
| 31 | short temp; | 31 | short temp; |
| 32 | local_irq_disable(); | ||
| 33 | /* Reset the Machine via pc[3] of the sequoia chipset */ | 32 | /* Reset the Machine via pc[3] of the sequoia chipset */ |
| 34 | outw(0x09,0x24); | 33 | outw(0x09,0x24); |
| 35 | temp=inw(0x26); | 34 | temp=inw(0x26); |
diff --git a/arch/arm/mach-u300/include/mach/system.h b/arch/arm/mach-u300/include/mach/system.h index 8daf13634ce0..6b6fef7a438c 100644 --- a/arch/arm/mach-u300/include/mach/system.h +++ b/arch/arm/mach-u300/include/mach/system.h | |||
| @@ -27,8 +27,6 @@ static void arch_reset(char mode, const char *cmd) | |||
| 27 | case 's': | 27 | case 's': |
| 28 | case 'h': | 28 | case 'h': |
| 29 | printk(KERN_CRIT "RESET: shutting down/rebooting system\n"); | 29 | printk(KERN_CRIT "RESET: shutting down/rebooting system\n"); |
| 30 | /* Disable interrupts */ | ||
| 31 | local_irq_disable(); | ||
| 32 | #ifdef CONFIG_COH901327_WATCHDOG | 30 | #ifdef CONFIG_COH901327_WATCHDOG |
| 33 | coh901327_watchdog_reset(); | 31 | coh901327_watchdog_reset(); |
| 34 | #endif | 32 | #endif |
