aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2012-12-10 14:04:40 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2012-12-11 15:17:17 -0500
commit62b807f64948f55776b1cc57298966d915b1a402 (patch)
tree4301639365d944146267862f70b3028ad033ebc2
parent3a5afaec593954a399967155db47f72cb8828a6a (diff)
perf evsel: No need to always ask for PERF_FORMAT_TOTAL_TIME_{ENABLED,RUNNING}
This is needed, so far, just in 'perf stat', to scale counters, so don't unconditionally ask for them in the perf_evsel__config() method. Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-ujpujgscq2f2oodxuso5nobc@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/tests/attr/base-record2
-rw-r--r--tools/perf/tests/attr/test-record-group4
-rw-r--r--tools/perf/tests/attr/test-record-group14
-rw-r--r--tools/perf/util/evsel.c2
4 files changed, 5 insertions, 7 deletions
diff --git a/tools/perf/tests/attr/base-record b/tools/perf/tests/attr/base-record
index f9d04643109e..5bc3880f7be5 100644
--- a/tools/perf/tests/attr/base-record
+++ b/tools/perf/tests/attr/base-record
@@ -7,7 +7,7 @@ size=96
7config=0 7config=0
8sample_period=4000 8sample_period=4000
9sample_type=263 9sample_type=263
10read_format=3 10read_format=0
11disabled=1 11disabled=1
12inherit=1 12inherit=1
13pinned=0 13pinned=0
diff --git a/tools/perf/tests/attr/test-record-group b/tools/perf/tests/attr/test-record-group
index 0df34cab3e42..57739cacdb2a 100644
--- a/tools/perf/tests/attr/test-record-group
+++ b/tools/perf/tests/attr/test-record-group
@@ -6,14 +6,14 @@ args = --group -e cycles,instructions kill >/dev/null 2>&1
6fd=1 6fd=1
7group_fd=-1 7group_fd=-1
8sample_type=327 8sample_type=327
9read_format=7 9read_format=4
10 10
11[event-2:base-record] 11[event-2:base-record]
12fd=2 12fd=2
13group_fd=1 13group_fd=1
14config=1 14config=1
15sample_type=327 15sample_type=327
16read_format=7 16read_format=4
17mmap=0 17mmap=0
18comm=0 18comm=0
19enable_on_exec=0 19enable_on_exec=0
diff --git a/tools/perf/tests/attr/test-record-group1 b/tools/perf/tests/attr/test-record-group1
index 18bd926ff6cb..4d688a13fd2f 100644
--- a/tools/perf/tests/attr/test-record-group1
+++ b/tools/perf/tests/attr/test-record-group1
@@ -6,7 +6,7 @@ args = -e '{cycles,instructions}' kill >/tmp/krava 2>&1
6fd=1 6fd=1
7group_fd=-1 7group_fd=-1
8sample_type=327 8sample_type=327
9read_format=7 9read_format=4
10 10
11[event-2:base-record] 11[event-2:base-record]
12fd=2 12fd=2
@@ -14,7 +14,7 @@ group_fd=1
14type=0 14type=0
15config=1 15config=1
16sample_type=327 16sample_type=327
17read_format=7 17read_format=4
18mmap=0 18mmap=0
19comm=0 19comm=0
20enable_on_exec=0 20enable_on_exec=0
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index e62d3aef9cd6..2492d329a5f5 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -465,8 +465,6 @@ void perf_evsel__config(struct perf_evsel *evsel,
465 465
466 attr->sample_id_all = opts->sample_id_all_missing ? 0 : 1; 466 attr->sample_id_all = opts->sample_id_all_missing ? 0 : 1;
467 attr->inherit = !opts->no_inherit; 467 attr->inherit = !opts->no_inherit;
468 attr->read_format = PERF_FORMAT_TOTAL_TIME_ENABLED |
469 PERF_FORMAT_TOTAL_TIME_RUNNING;
470 468
471 perf_evsel__set_sample_bit(evsel, IP); 469 perf_evsel__set_sample_bit(evsel, IP);
472 perf_evsel__set_sample_bit(evsel, TID); 470 perf_evsel__set_sample_bit(evsel, TID);