aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2012-08-18 16:25:56 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-09-14 10:10:59 -0400
commit612cd9e87496cc34c29ff3a3c0adb52cd816c3b6 (patch)
treef771ec03a41d2a443d0337b5aca11310671c8a22
parentb25b895805dd415f218cfd4892d17aeb2db425f7 (diff)
[media] mt9m032.c: introduce missing initialization
The result of one call to a function is tested, and then at the second call to the same function, the previous result, and not the current result, is tested again. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression ret; identifier f; statement S1,S2; @@ *ret = f(...); if (\(ret != 0\|ret < 0\|ret == NULL\)) S1 ... when any *f(...); if (\(ret != 0\|ret < 0\|ret == NULL\)) S2 // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/media/i2c/mt9m032.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/mt9m032.c b/drivers/media/i2c/mt9m032.c
index 445359c96113..f80c1d7ec884 100644
--- a/drivers/media/i2c/mt9m032.c
+++ b/drivers/media/i2c/mt9m032.c
@@ -781,7 +781,7 @@ static int mt9m032_probe(struct i2c_client *client,
781 ret = mt9m032_write(client, MT9M032_RESET, 1); /* reset on */ 781 ret = mt9m032_write(client, MT9M032_RESET, 1); /* reset on */
782 if (ret < 0) 782 if (ret < 0)
783 goto error_entity; 783 goto error_entity;
784 mt9m032_write(client, MT9M032_RESET, 0); /* reset off */ 784 ret = mt9m032_write(client, MT9M032_RESET, 0); /* reset off */
785 if (ret < 0) 785 if (ret < 0)
786 goto error_entity; 786 goto error_entity;
787 787