diff options
author | Michael Krufky <mkrufky@linuxtv.org> | 2011-12-15 08:30:38 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-12-30 12:58:01 -0500 |
commit | 54828d19f82be0d62e22fbd5a6354136c50a20eb (patch) | |
tree | 69bb1f27ed1fc6d217cee0d106dbe530692ed5a6 | |
parent | 26110dac8b3b30a99555d85fc1308a21fba5b746 (diff) |
[media] lgdt330x: warn on errors blasting modulation config to the lgdt3303
fix the following build warning:
lgdt330x.c: In function "lgdt330x_set_parameters":
lgdt330x.c:346:6: warning: variable "err" set but not used
[-Wunused-but-set-variable]
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/media/dvb/frontends/lgdt330x.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/media/dvb/frontends/lgdt330x.c b/drivers/media/dvb/frontends/lgdt330x.c index d45827158a24..c39d8d63979b 100644 --- a/drivers/media/dvb/frontends/lgdt330x.c +++ b/drivers/media/dvb/frontends/lgdt330x.c | |||
@@ -347,7 +347,7 @@ static int lgdt330x_set_parameters(struct dvb_frontend* fe, | |||
347 | 347 | ||
348 | static u8 top_ctrl_cfg[] = { TOP_CONTROL, 0x03 }; | 348 | static u8 top_ctrl_cfg[] = { TOP_CONTROL, 0x03 }; |
349 | 349 | ||
350 | int err; | 350 | int err = 0; |
351 | /* Change only if we are actually changing the modulation */ | 351 | /* Change only if we are actually changing the modulation */ |
352 | if (state->current_modulation != param->u.vsb.modulation) { | 352 | if (state->current_modulation != param->u.vsb.modulation) { |
353 | switch(param->u.vsb.modulation) { | 353 | switch(param->u.vsb.modulation) { |
@@ -402,6 +402,11 @@ static int lgdt330x_set_parameters(struct dvb_frontend* fe, | |||
402 | printk(KERN_WARNING "lgdt330x: %s: Modulation type(%d) UNSUPPORTED\n", __func__, param->u.vsb.modulation); | 402 | printk(KERN_WARNING "lgdt330x: %s: Modulation type(%d) UNSUPPORTED\n", __func__, param->u.vsb.modulation); |
403 | return -1; | 403 | return -1; |
404 | } | 404 | } |
405 | if (err < 0) | ||
406 | printk(KERN_WARNING "lgdt330x: %s: error blasting " | ||
407 | "bytes to lgdt3303 for modulation type(%d)\n", | ||
408 | __func__, param->u.vsb.modulation); | ||
409 | |||
405 | /* | 410 | /* |
406 | * select serial or parallel MPEG harware interface | 411 | * select serial or parallel MPEG harware interface |
407 | * Serial: 0x04 for LGDT3302 or 0x40 for LGDT3303 | 412 | * Serial: 0x04 for LGDT3302 or 0x40 for LGDT3303 |