diff options
author | Jiri Olsa <jolsa@redhat.com> | 2012-10-27 17:18:29 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-10-29 09:35:32 -0400 |
commit | 4383db88a7afb2664941ef1e82d41f5aad8be2ec (patch) | |
tree | 70989864c52fbf222304718ef9be6d879a6dc6f3 | |
parent | ebb296c276ca19798c3116220eb8d0b2c0975ae0 (diff) |
perf tools: Move BUILD_ID_SIZE into build-id object
Moving BUILD_ID_SIZE define into build-id object, plus include related
changes.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Namhyung Kim <namhyung@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1351372712-21104-3-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/builtin-buildid-cache.c | 1 | ||||
-rw-r--r-- | tools/perf/util/annotate.c | 1 | ||||
-rw-r--r-- | tools/perf/util/build-id.h | 6 | ||||
-rw-r--r-- | tools/perf/util/event.h | 3 | ||||
-rw-r--r-- | tools/perf/util/symbol.h | 3 |
5 files changed, 9 insertions, 5 deletions
diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c index edb26ea78dd3..fae8b250b2ca 100644 --- a/tools/perf/builtin-buildid-cache.c +++ b/tools/perf/builtin-buildid-cache.c | |||
@@ -14,6 +14,7 @@ | |||
14 | #include "util/parse-options.h" | 14 | #include "util/parse-options.h" |
15 | #include "util/strlist.h" | 15 | #include "util/strlist.h" |
16 | #include "util/build-id.h" | 16 | #include "util/build-id.h" |
17 | #include "util/symbol.h" | ||
17 | 18 | ||
18 | static int build_id_cache__add_file(const char *filename, const char *debugdir) | 19 | static int build_id_cache__add_file(const char *filename, const char *debugdir) |
19 | { | 20 | { |
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index f0a910371377..7a34dd18b74c 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c | |||
@@ -15,6 +15,7 @@ | |||
15 | #include "debug.h" | 15 | #include "debug.h" |
16 | #include "annotate.h" | 16 | #include "annotate.h" |
17 | #include <pthread.h> | 17 | #include <pthread.h> |
18 | #include <linux/bitops.h> | ||
18 | 19 | ||
19 | const char *disassembler_style; | 20 | const char *disassembler_style; |
20 | const char *objdump_path; | 21 | const char *objdump_path; |
diff --git a/tools/perf/util/build-id.h b/tools/perf/util/build-id.h index f6d9ff9cab20..a811f5c62e18 100644 --- a/tools/perf/util/build-id.h +++ b/tools/perf/util/build-id.h | |||
@@ -1,9 +1,13 @@ | |||
1 | #ifndef PERF_BUILD_ID_H_ | 1 | #ifndef PERF_BUILD_ID_H_ |
2 | #define PERF_BUILD_ID_H_ 1 | 2 | #define PERF_BUILD_ID_H_ 1 |
3 | 3 | ||
4 | #include "session.h" | 4 | #define BUILD_ID_SIZE 20 |
5 | |||
6 | #include "tool.h" | ||
7 | #include "types.h" | ||
5 | 8 | ||
6 | extern struct perf_tool build_id__mark_dso_hit_ops; | 9 | extern struct perf_tool build_id__mark_dso_hit_ops; |
10 | struct dso; | ||
7 | 11 | ||
8 | int build_id__sprintf(const u8 *build_id, int len, char *bf); | 12 | int build_id__sprintf(const u8 *build_id, int len, char *bf); |
9 | char *dso__build_id_filename(struct dso *self, char *bf, size_t size); | 13 | char *dso__build_id_filename(struct dso *self, char *bf, size_t size); |
diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h index da97aff5bd75..0d573ff4771a 100644 --- a/tools/perf/util/event.h +++ b/tools/perf/util/event.h | |||
@@ -6,6 +6,7 @@ | |||
6 | 6 | ||
7 | #include "../perf.h" | 7 | #include "../perf.h" |
8 | #include "map.h" | 8 | #include "map.h" |
9 | #include "build-id.h" | ||
9 | 10 | ||
10 | /* | 11 | /* |
11 | * PERF_SAMPLE_IP | PERF_SAMPLE_TID | * | 12 | * PERF_SAMPLE_IP | PERF_SAMPLE_TID | * |
@@ -96,8 +97,6 @@ struct perf_sample { | |||
96 | struct stack_dump user_stack; | 97 | struct stack_dump user_stack; |
97 | }; | 98 | }; |
98 | 99 | ||
99 | #define BUILD_ID_SIZE 20 | ||
100 | |||
101 | struct build_id_event { | 100 | struct build_id_event { |
102 | struct perf_event_header header; | 101 | struct perf_event_header header; |
103 | pid_t pid; | 102 | pid_t pid; |
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index d70f6764524e..6eb7d3b9c88e 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h | |||
@@ -11,6 +11,7 @@ | |||
11 | #include <stdio.h> | 11 | #include <stdio.h> |
12 | #include <byteswap.h> | 12 | #include <byteswap.h> |
13 | #include <libgen.h> | 13 | #include <libgen.h> |
14 | #include "build-id.h" | ||
14 | 15 | ||
15 | #ifdef LIBELF_SUPPORT | 16 | #ifdef LIBELF_SUPPORT |
16 | #include <libelf.h> | 17 | #include <libelf.h> |
@@ -57,8 +58,6 @@ char *strxfrchar(char *s, char from, char to); | |||
57 | #define DMGL_ANSI (1 << 1) /* Include const, volatile, etc */ | 58 | #define DMGL_ANSI (1 << 1) /* Include const, volatile, etc */ |
58 | #endif | 59 | #endif |
59 | 60 | ||
60 | #define BUILD_ID_SIZE 20 | ||
61 | |||
62 | /** struct symbol - symtab entry | 61 | /** struct symbol - symtab entry |
63 | * | 62 | * |
64 | * @ignore - resolvable but tools ignore it (e.g. idle routines) | 63 | * @ignore - resolvable but tools ignore it (e.g. idle routines) |