aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelipe Balbi <balbi@ti.com>2012-09-12 06:57:57 -0400
committerWolfram Sang <w.sang@pengutronix.de>2012-09-12 09:01:59 -0400
commit2049b5bcdd2172424c1ffc9b87d8f40020e9ebd6 (patch)
treeb385e53a23a5757941af39f73ba31db5de33367e
parentbaf3d7b7210c705bf8ca7afb03cd7f0b61d27058 (diff)
i2c: omap: decrease indentation level on data handling
The patch intends to decrease the indentation level on the data handling by using the fact that else of if (dev->buf_len) is same as if (!dev->buf_len) if (dev->buf_len) { aaa; } else { bbb; break; } to if (!dev->buf_len) { bbb; break; } aaa; Hence no functional changes. Signed-off-by: Felipe Balbi <balbi@ti.com> Reviewed-by : Santosh Shilimkar <santosh.shilimkar@ti.com> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
-rw-r--r--drivers/i2c/busses/i2c-omap.c63
1 files changed, 31 insertions, 32 deletions
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 236cb38bb859..0dd647abb89d 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -813,22 +813,7 @@ complete:
813 >> 8) & 0x3F; 813 >> 8) & 0x3F;
814 } 814 }
815 while (num_bytes--) { 815 while (num_bytes--) {
816 w = omap_i2c_read_reg(dev, OMAP_I2C_DATA_REG); 816 if (!dev->buf_len) {
817 if (dev->buf_len) {
818 *dev->buf++ = w;
819 dev->buf_len--;
820 /*
821 * Data reg in 2430, omap3 and
822 * omap4 is 8 bit wide
823 */
824 if (dev->flags &
825 OMAP_I2C_FLAG_16BIT_DATA_REG) {
826 if (dev->buf_len) {
827 *dev->buf++ = w >> 8;
828 dev->buf_len--;
829 }
830 }
831 } else {
832 if (stat & OMAP_I2C_STAT_RRDY) 817 if (stat & OMAP_I2C_STAT_RRDY)
833 dev_err(dev->dev, 818 dev_err(dev->dev,
834 "RRDY IRQ while no data" 819 "RRDY IRQ while no data"
@@ -839,6 +824,21 @@ complete:
839 " requested\n"); 824 " requested\n");
840 break; 825 break;
841 } 826 }
827
828 w = omap_i2c_read_reg(dev, OMAP_I2C_DATA_REG);
829 *dev->buf++ = w;
830 dev->buf_len--;
831 /*
832 * Data reg in 2430, omap3 and
833 * omap4 is 8 bit wide
834 */
835 if (dev->flags &
836 OMAP_I2C_FLAG_16BIT_DATA_REG) {
837 if (dev->buf_len) {
838 *dev->buf++ = w >> 8;
839 dev->buf_len--;
840 }
841 }
842 } 842 }
843 omap_i2c_ack_stat(dev, 843 omap_i2c_ack_stat(dev,
844 stat & (OMAP_I2C_STAT_RRDY | OMAP_I2C_STAT_RDR)); 844 stat & (OMAP_I2C_STAT_RRDY | OMAP_I2C_STAT_RDR));
@@ -855,22 +855,7 @@ complete:
855 & 0x3F; 855 & 0x3F;
856 } 856 }
857 while (num_bytes--) { 857 while (num_bytes--) {
858 w = 0; 858 if (!dev->buf_len) {
859 if (dev->buf_len) {
860 w = *dev->buf++;
861 dev->buf_len--;
862 /*
863 * Data reg in 2430, omap3 and
864 * omap4 is 8 bit wide
865 */
866 if (dev->flags &
867 OMAP_I2C_FLAG_16BIT_DATA_REG) {
868 if (dev->buf_len) {
869 w |= *dev->buf++ << 8;
870 dev->buf_len--;
871 }
872 }
873 } else {
874 if (stat & OMAP_I2C_STAT_XRDY) 859 if (stat & OMAP_I2C_STAT_XRDY)
875 dev_err(dev->dev, 860 dev_err(dev->dev,
876 "XRDY IRQ while no " 861 "XRDY IRQ while no "
@@ -882,6 +867,20 @@ complete:
882 break; 867 break;
883 } 868 }
884 869
870 w = *dev->buf++;
871 dev->buf_len--;
872 /*
873 * Data reg in 2430, omap3 and
874 * omap4 is 8 bit wide
875 */
876 if (dev->flags &
877 OMAP_I2C_FLAG_16BIT_DATA_REG) {
878 if (dev->buf_len) {
879 w |= *dev->buf++ << 8;
880 dev->buf_len--;
881 }
882 }
883
885 if ((dev->errata & I2C_OMAP_ERRATA_I462) && 884 if ((dev->errata & I2C_OMAP_ERRATA_I462) &&
886 errata_omap3_i462(dev, &stat, &err)) 885 errata_omap3_i462(dev, &stat, &err))
887 goto complete; 886 goto complete;