diff options
author | Eliad Peller <eliad@wizery.com> | 2011-12-06 05:15:06 -0500 |
---|---|---|
committer | Luciano Coelho <coelho@ti.com> | 2011-12-08 05:32:36 -0500 |
commit | 188e7f54c38b9bf144ddc81b4b734cb6ea49f31e (patch) | |
tree | 122549897d4ba40cf9c7f4cf125ad85ec6d92774 | |
parent | abc47470ef63cdde2efdf358ae373afb16f358c0 (diff) |
wl12xx: remove redundant commands from plt init
During plt init we configure some redundant commands,
which are not needed for plt (specifically, we shouldn't
configure any role-specific params, as there are no
active roles). remove them.
Signed-off-by: Eliad Peller <eliad@wizery.com>
Signed-off-by: Luciano Coelho <coelho@ti.com>
-rw-r--r-- | drivers/net/wireless/wl12xx/main.c | 61 |
1 files changed, 1 insertions, 60 deletions
diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c index d1416752feea..2f7bfa86c8cd 100644 --- a/drivers/net/wireless/wl12xx/main.c +++ b/drivers/net/wireless/wl12xx/main.c | |||
@@ -641,9 +641,7 @@ static void wl1271_conf_init(struct wl1271 *wl) | |||
641 | 641 | ||
642 | static int wl1271_plt_init(struct wl1271 *wl) | 642 | static int wl1271_plt_init(struct wl1271 *wl) |
643 | { | 643 | { |
644 | struct conf_tx_ac_category *conf_ac; | 644 | int ret; |
645 | struct conf_tx_tid *conf_tid; | ||
646 | int ret, i; | ||
647 | 645 | ||
648 | if (wl->chip.id == CHIP_ID_1283_PG20) | 646 | if (wl->chip.id == CHIP_ID_1283_PG20) |
649 | ret = wl128x_cmd_general_parms(wl); | 647 | ret = wl128x_cmd_general_parms(wl); |
@@ -672,10 +670,6 @@ static int wl1271_plt_init(struct wl1271 *wl) | |||
672 | if (ret < 0) | 670 | if (ret < 0) |
673 | return ret; | 671 | return ret; |
674 | 672 | ||
675 | ret = wl1271_init_templates_config(wl); | ||
676 | if (ret < 0) | ||
677 | return ret; | ||
678 | |||
679 | ret = wl1271_acx_init_mem_config(wl); | 673 | ret = wl1271_acx_init_mem_config(wl); |
680 | if (ret < 0) | 674 | if (ret < 0) |
681 | return ret; | 675 | return ret; |
@@ -685,63 +679,10 @@ static int wl1271_plt_init(struct wl1271 *wl) | |||
685 | if (ret < 0) | 679 | if (ret < 0) |
686 | goto out_free_memmap; | 680 | goto out_free_memmap; |
687 | 681 | ||
688 | ret = wl1271_acx_dco_itrim_params(wl); | ||
689 | if (ret < 0) | ||
690 | goto out_free_memmap; | ||
691 | |||
692 | /* Initialize connection monitoring thresholds */ | ||
693 | ret = wl1271_acx_conn_monit_params(wl, NULL, false); /* TODO: fix */ | ||
694 | if (ret < 0) | ||
695 | goto out_free_memmap; | ||
696 | |||
697 | /* Bluetooth WLAN coexistence */ | ||
698 | ret = wl1271_init_pta(wl); | ||
699 | if (ret < 0) | ||
700 | goto out_free_memmap; | ||
701 | |||
702 | /* FM WLAN coexistence */ | ||
703 | ret = wl1271_acx_fm_coex(wl); | ||
704 | if (ret < 0) | ||
705 | goto out_free_memmap; | ||
706 | |||
707 | /* Energy detection */ | ||
708 | ret = wl1271_init_energy_detection(wl); | ||
709 | if (ret < 0) | ||
710 | goto out_free_memmap; | ||
711 | |||
712 | ret = wl12xx_acx_mem_cfg(wl); | 682 | ret = wl12xx_acx_mem_cfg(wl); |
713 | if (ret < 0) | 683 | if (ret < 0) |
714 | goto out_free_memmap; | 684 | goto out_free_memmap; |
715 | 685 | ||
716 | /* Default fragmentation threshold */ | ||
717 | ret = wl1271_acx_frag_threshold(wl, wl->conf.tx.frag_threshold); | ||
718 | if (ret < 0) | ||
719 | goto out_free_memmap; | ||
720 | |||
721 | /* Default TID/AC configuration */ | ||
722 | BUG_ON(wl->conf.tx.tid_conf_count != wl->conf.tx.ac_conf_count); | ||
723 | for (i = 0; i < wl->conf.tx.tid_conf_count; i++) { | ||
724 | conf_ac = &wl->conf.tx.ac_conf[i]; | ||
725 | /* TODO: fix */ | ||
726 | ret = wl1271_acx_ac_cfg(wl, NULL, conf_ac->ac, conf_ac->cw_min, | ||
727 | conf_ac->cw_max, conf_ac->aifsn, | ||
728 | conf_ac->tx_op_limit); | ||
729 | if (ret < 0) | ||
730 | goto out_free_memmap; | ||
731 | |||
732 | conf_tid = &wl->conf.tx.tid_conf[i]; | ||
733 | /* TODO: fix */ | ||
734 | ret = wl1271_acx_tid_cfg(wl, NULL, conf_tid->queue_id, | ||
735 | conf_tid->channel_type, | ||
736 | conf_tid->tsid, | ||
737 | conf_tid->ps_scheme, | ||
738 | conf_tid->ack_policy, | ||
739 | conf_tid->apsd_conf[0], | ||
740 | conf_tid->apsd_conf[1]); | ||
741 | if (ret < 0) | ||
742 | goto out_free_memmap; | ||
743 | } | ||
744 | |||
745 | /* Enable data path */ | 686 | /* Enable data path */ |
746 | ret = wl1271_cmd_data_path(wl, 1); | 687 | ret = wl1271_cmd_data_path(wl, 1); |
747 | if (ret < 0) | 688 | if (ret < 0) |