aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrank Schaefer <fschaefer.oss@googlemail.com>2013-03-03 13:37:34 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2013-03-04 13:48:47 -0500
commit12d7ce185a6d86758c8feecc91f3c029c39730c6 (patch)
tree82d11d7d2cbd4a75aaae9004596536c028735dbd
parentd7a80eaa9a2adce908ad0707faea4f776199a48a (diff)
[media] em28xx-i2c: replace printk() with the corresponding em28xx macros
Reduces the number of characters/lines, unifies the code and improves readability. Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/media/usb/em28xx/em28xx-i2c.c55
1 files changed, 24 insertions, 31 deletions
diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
index 4ffcafb6ac9a..ebe1ec626892 100644
--- a/drivers/media/usb/em28xx/em28xx-i2c.c
+++ b/drivers/media/usb/em28xx/em28xx-i2c.c
@@ -394,7 +394,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned char *eedata, int len)
394 /* Check if board has eeprom */ 394 /* Check if board has eeprom */
395 err = i2c_master_recv(&dev->i2c_client, &buf, 0); 395 err = i2c_master_recv(&dev->i2c_client, &buf, 0);
396 if (err < 0) { 396 if (err < 0) {
397 em28xx_errdev("board has no eeprom\n"); 397 em28xx_info("board has no eeprom\n");
398 memset(eedata, 0, len); 398 memset(eedata, 0, len);
399 return -ENODEV; 399 return -ENODEV;
400 } 400 }
@@ -403,8 +403,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned char *eedata, int len)
403 403
404 err = i2c_master_send(&dev->i2c_client, &buf, 1); 404 err = i2c_master_send(&dev->i2c_client, &buf, 1);
405 if (err != 1) { 405 if (err != 1) {
406 printk(KERN_INFO "%s: Huh, no eeprom present (err=%d)?\n", 406 em28xx_errdev("failed to read eeprom (err=%d)\n", err);
407 dev->name, err);
408 return err; 407 return err;
409 } 408 }
410 409
@@ -421,9 +420,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned char *eedata, int len)
421 420
422 if (block != 421 if (block !=
423 (err = i2c_master_recv(&dev->i2c_client, p, block))) { 422 (err = i2c_master_recv(&dev->i2c_client, p, block))) {
424 printk(KERN_WARNING 423 em28xx_errdev("i2c eeprom read error (err=%d)\n", err);
425 "%s: i2c eeprom read error (err=%d)\n",
426 dev->name, err);
427 return err; 424 return err;
428 } 425 }
429 size -= block; 426 size -= block;
@@ -431,7 +428,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned char *eedata, int len)
431 } 428 }
432 for (i = 0; i < len; i++) { 429 for (i = 0; i < len; i++) {
433 if (0 == (i % 16)) 430 if (0 == (i % 16))
434 printk(KERN_INFO "%s: i2c eeprom %02x:", dev->name, i); 431 em28xx_info("i2c eeprom %02x:", i);
435 printk(" %02x", eedata[i]); 432 printk(" %02x", eedata[i]);
436 if (15 == (i % 16)) 433 if (15 == (i % 16))
437 printk("\n"); 434 printk("\n");
@@ -440,55 +437,51 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned char *eedata, int len)
440 if (em_eeprom->id == 0x9567eb1a) 437 if (em_eeprom->id == 0x9567eb1a)
441 dev->hash = em28xx_hash_mem(eedata, len, 32); 438 dev->hash = em28xx_hash_mem(eedata, len, 32);
442 439
443 printk(KERN_INFO "%s: EEPROM ID= 0x%08x, EEPROM hash = 0x%08lx\n", 440 em28xx_info("EEPROM ID = 0x%08x, EEPROM hash = 0x%08lx\n",
444 dev->name, em_eeprom->id, dev->hash); 441 em_eeprom->id, dev->hash);
445 442
446 printk(KERN_INFO "%s: EEPROM info:\n", dev->name); 443 em28xx_info("EEPROM info:\n");
447 444
448 switch (em_eeprom->chip_conf >> 4 & 0x3) { 445 switch (em_eeprom->chip_conf >> 4 & 0x3) {
449 case 0: 446 case 0:
450 printk(KERN_INFO "%s:\tNo audio on board.\n", dev->name); 447 em28xx_info("\tNo audio on board.\n");
451 break; 448 break;
452 case 1: 449 case 1:
453 printk(KERN_INFO "%s:\tAC97 audio (5 sample rates)\n", 450 em28xx_info("\tAC97 audio (5 sample rates)\n");
454 dev->name);
455 break; 451 break;
456 case 2: 452 case 2:
457 printk(KERN_INFO "%s:\tI2S audio, sample rate=32k\n", 453 em28xx_info("\tI2S audio, sample rate=32k\n");
458 dev->name);
459 break; 454 break;
460 case 3: 455 case 3:
461 printk(KERN_INFO "%s:\tI2S audio, 3 sample rates\n", 456 em28xx_info("\tI2S audio, 3 sample rates\n");
462 dev->name);
463 break; 457 break;
464 } 458 }
465 459
466 if (em_eeprom->chip_conf & 1 << 3) 460 if (em_eeprom->chip_conf & 1 << 3)
467 printk(KERN_INFO "%s:\tUSB Remote wakeup capable\n", dev->name); 461 em28xx_info("\tUSB Remote wakeup capable\n");
468 462
469 if (em_eeprom->chip_conf & 1 << 2) 463 if (em_eeprom->chip_conf & 1 << 2)
470 printk(KERN_INFO "%s:\tUSB Self power capable\n", dev->name); 464 em28xx_info("\tUSB Self power capable\n");
471 465
472 switch (em_eeprom->chip_conf & 0x3) { 466 switch (em_eeprom->chip_conf & 0x3) {
473 case 0: 467 case 0:
474 printk(KERN_INFO "%s:\t500mA max power\n", dev->name); 468 em28xx_info("\t500mA max power\n");
475 break; 469 break;
476 case 1: 470 case 1:
477 printk(KERN_INFO "%s:\t400mA max power\n", dev->name); 471 em28xx_info("\t400mA max power\n");
478 break; 472 break;
479 case 2: 473 case 2:
480 printk(KERN_INFO "%s:\t300mA max power\n", dev->name); 474 em28xx_info("\t300mA max power\n");
481 break; 475 break;
482 case 3: 476 case 3:
483 printk(KERN_INFO "%s:\t200mA max power\n", dev->name); 477 em28xx_info("\t200mA max power\n");
484 break; 478 break;
485 } 479 }
486 printk(KERN_INFO "%s:\tTable at 0x%02x, strings=0x%04x, 0x%04x, 0x%04x\n", 480 em28xx_info("\tTable at offset 0x%02x, strings=0x%04x, 0x%04x, 0x%04x\n",
487 dev->name, 481 em_eeprom->string_idx_table,
488 em_eeprom->string_idx_table, 482 em_eeprom->string1,
489 em_eeprom->string1, 483 em_eeprom->string2,
490 em_eeprom->string2, 484 em_eeprom->string3);
491 em_eeprom->string3);
492 485
493 return 0; 486 return 0;
494} 487}
@@ -565,8 +558,8 @@ void em28xx_do_i2c_scan(struct em28xx *dev)
565 if (rc < 0) 558 if (rc < 0)
566 continue; 559 continue;
567 i2c_devicelist[i] = i; 560 i2c_devicelist[i] = i;
568 printk(KERN_INFO "%s: found i2c device @ 0x%x [%s]\n", 561 em28xx_info("found i2c device @ 0x%x [%s]\n",
569 dev->name, i << 1, i2c_devs[i] ? i2c_devs[i] : "???"); 562 i << 1, i2c_devs[i] ? i2c_devs[i] : "???");
570 } 563 }
571 564
572 dev->i2c_hash = em28xx_hash_mem(i2c_devicelist, 565 dev->i2c_hash = em28xx_hash_mem(i2c_devicelist,