diff options
author | Wu Fengguang <fengguang.wu@intel.com> | 2009-06-16 18:32:30 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-06-16 22:47:39 -0400 |
commit | 08d9ae7cbbd0c5c07573d072ec771e997a9a39e0 (patch) | |
tree | e669cd3eb5a84842c798af936c9e5642765b556f | |
parent | 6e08a369ee10b361ac1cdcdf4fabd420fd08beb3 (diff) |
vmscan: don't export nr_saved_scan in /proc/zoneinfo
The lru->nr_saved_scan's are not meaningful counters for even kernel
developers. They typically are smaller than 32 and are always 0 for large
lists. So remove them from /proc/zoneinfo.
Hopefully this interface change won't break too many scripts.
/proc/zoneinfo is too unstructured to be script friendly, and I wonder the
affected scripts - if there are any - are still bleeding since the not
long ago commit "vmscan: split LRU lists into anon & file sets", which
also touched the "scanned" line :)
If we are to re-export accumulated vmscan counts in the future, they can
go to new lines in /proc/zoneinfo instead of the current form, or to
/sys/devices/system/node/node0/meminfo?
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Acked-by: Rik van Riel <riel@redhat.com>
Cc: Nick Piggin <npiggin@suse.de>
Acked-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | mm/vmstat.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/mm/vmstat.c b/mm/vmstat.c index 84c055556911..1e151cf6bf86 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c | |||
@@ -710,7 +710,7 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat, | |||
710 | "\n min %lu" | 710 | "\n min %lu" |
711 | "\n low %lu" | 711 | "\n low %lu" |
712 | "\n high %lu" | 712 | "\n high %lu" |
713 | "\n scanned %lu (aa: %lu ia: %lu af: %lu if: %lu)" | 713 | "\n scanned %lu" |
714 | "\n spanned %lu" | 714 | "\n spanned %lu" |
715 | "\n present %lu", | 715 | "\n present %lu", |
716 | zone_page_state(zone, NR_FREE_PAGES), | 716 | zone_page_state(zone, NR_FREE_PAGES), |
@@ -718,10 +718,6 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat, | |||
718 | low_wmark_pages(zone), | 718 | low_wmark_pages(zone), |
719 | high_wmark_pages(zone), | 719 | high_wmark_pages(zone), |
720 | zone->pages_scanned, | 720 | zone->pages_scanned, |
721 | zone->lru[LRU_ACTIVE_ANON].nr_saved_scan, | ||
722 | zone->lru[LRU_INACTIVE_ANON].nr_saved_scan, | ||
723 | zone->lru[LRU_ACTIVE_FILE].nr_saved_scan, | ||
724 | zone->lru[LRU_INACTIVE_FILE].nr_saved_scan, | ||
725 | zone->spanned_pages, | 721 | zone->spanned_pages, |
726 | zone->present_pages); | 722 | zone->present_pages); |
727 | 723 | ||