diff options
author | Daniel Borkmann <dborkman@redhat.com> | 2013-08-29 17:55:05 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-09-14 09:54:56 -0400 |
commit | 00897febb83864e2dd388d719b256cb362198e27 (patch) | |
tree | f1e55e27880cdc7fd7dab1857cd5a02b9881ea53 | |
parent | 56a12acebcbd08342f7287a5870fe7ec2c0de91a (diff) |
net: bridge: convert MLDv2 Query MRC into msecs_to_jiffies for max_delay
[ Upstream commit 2d98c29b6fb3de44d9eaa73c09f9cf7209346383 ]
While looking into MLDv1/v2 code, I noticed that bridging code does
not convert it's max delay into jiffies for MLDv2 messages as we do
in core IPv6' multicast code.
RFC3810, 5.1.3. Maximum Response Code says:
The Maximum Response Code field specifies the maximum time allowed
before sending a responding Report. The actual time allowed, called
the Maximum Response Delay, is represented in units of milliseconds,
and is derived from the Maximum Response Code as follows: [...]
As we update timers that work with jiffies, we need to convert it.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Cc: Linus Lüssing <linus.luessing@web.de>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | net/bridge/br_multicast.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index 75a81281c979..d82058f6fc79 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c | |||
@@ -1193,7 +1193,8 @@ static int br_ip6_multicast_query(struct net_bridge *br, | |||
1193 | mld2q = (struct mld2_query *)icmp6_hdr(skb); | 1193 | mld2q = (struct mld2_query *)icmp6_hdr(skb); |
1194 | if (!mld2q->mld2q_nsrcs) | 1194 | if (!mld2q->mld2q_nsrcs) |
1195 | group = &mld2q->mld2q_mca; | 1195 | group = &mld2q->mld2q_mca; |
1196 | max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(ntohs(mld2q->mld2q_mrc)) : 1; | 1196 | |
1197 | max_delay = max(msecs_to_jiffies(MLDV2_MRC(ntohs(mld2q->mld2q_mrc))), 1UL); | ||
1197 | } | 1198 | } |
1198 | 1199 | ||
1199 | if (!group) | 1200 | if (!group) |