aboutsummaryrefslogtreecommitdiffstats
path: root/net/tipc
diff options
context:
space:
mode:
Diffstat (limited to 'net/tipc')
-rw-r--r--net/tipc/bearer.c140
-rw-r--r--net/tipc/bearer.h8
-rw-r--r--net/tipc/discover.c38
-rw-r--r--net/tipc/link.c4
-rw-r--r--net/tipc/link.h2
-rw-r--r--net/tipc/node.c74
6 files changed, 133 insertions, 133 deletions
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index 648f2a67f314..802ffad3200d 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -71,7 +71,7 @@ static const struct nla_policy tipc_nl_media_policy[TIPC_NLA_MEDIA_MAX + 1] = {
71 [TIPC_NLA_MEDIA_PROP] = { .type = NLA_NESTED } 71 [TIPC_NLA_MEDIA_PROP] = { .type = NLA_NESTED }
72}; 72};
73 73
74static void bearer_disable(struct net *net, struct tipc_bearer *b_ptr); 74static void bearer_disable(struct net *net, struct tipc_bearer *b);
75 75
76/** 76/**
77 * tipc_media_find - locates specified media object by name 77 * tipc_media_find - locates specified media object by name
@@ -107,13 +107,13 @@ static struct tipc_media *media_find_id(u8 type)
107void tipc_media_addr_printf(char *buf, int len, struct tipc_media_addr *a) 107void tipc_media_addr_printf(char *buf, int len, struct tipc_media_addr *a)
108{ 108{
109 char addr_str[MAX_ADDR_STR]; 109 char addr_str[MAX_ADDR_STR];
110 struct tipc_media *m_ptr; 110 struct tipc_media *m;
111 int ret; 111 int ret;
112 112
113 m_ptr = media_find_id(a->media_id); 113 m = media_find_id(a->media_id);
114 114
115 if (m_ptr && !m_ptr->addr2str(a, addr_str, sizeof(addr_str))) 115 if (m && !m->addr2str(a, addr_str, sizeof(addr_str)))
116 ret = scnprintf(buf, len, "%s(%s)", m_ptr->name, addr_str); 116 ret = scnprintf(buf, len, "%s(%s)", m->name, addr_str);
117 else { 117 else {
118 u32 i; 118 u32 i;
119 119
@@ -175,13 +175,13 @@ static int bearer_name_validate(const char *name,
175struct tipc_bearer *tipc_bearer_find(struct net *net, const char *name) 175struct tipc_bearer *tipc_bearer_find(struct net *net, const char *name)
176{ 176{
177 struct tipc_net *tn = net_generic(net, tipc_net_id); 177 struct tipc_net *tn = net_generic(net, tipc_net_id);
178 struct tipc_bearer *b_ptr; 178 struct tipc_bearer *b;
179 u32 i; 179 u32 i;
180 180
181 for (i = 0; i < MAX_BEARERS; i++) { 181 for (i = 0; i < MAX_BEARERS; i++) {
182 b_ptr = rtnl_dereference(tn->bearer_list[i]); 182 b = rtnl_dereference(tn->bearer_list[i]);
183 if (b_ptr && (!strcmp(b_ptr->name, name))) 183 if (b && (!strcmp(b->name, name)))
184 return b_ptr; 184 return b;
185 } 185 }
186 return NULL; 186 return NULL;
187} 187}
@@ -189,24 +189,24 @@ struct tipc_bearer *tipc_bearer_find(struct net *net, const char *name)
189void tipc_bearer_add_dest(struct net *net, u32 bearer_id, u32 dest) 189void tipc_bearer_add_dest(struct net *net, u32 bearer_id, u32 dest)
190{ 190{
191 struct tipc_net *tn = net_generic(net, tipc_net_id); 191 struct tipc_net *tn = net_generic(net, tipc_net_id);
192 struct tipc_bearer *b_ptr; 192 struct tipc_bearer *b;
193 193
194 rcu_read_lock(); 194 rcu_read_lock();
195 b_ptr = rcu_dereference_rtnl(tn->bearer_list[bearer_id]); 195 b = rcu_dereference_rtnl(tn->bearer_list[bearer_id]);
196 if (b_ptr) 196 if (b)
197 tipc_disc_add_dest(b_ptr->link_req); 197 tipc_disc_add_dest(b->link_req);
198 rcu_read_unlock(); 198 rcu_read_unlock();
199} 199}
200 200
201void tipc_bearer_remove_dest(struct net *net, u32 bearer_id, u32 dest) 201void tipc_bearer_remove_dest(struct net *net, u32 bearer_id, u32 dest)
202{ 202{
203 struct tipc_net *tn = net_generic(net, tipc_net_id); 203 struct tipc_net *tn = net_generic(net, tipc_net_id);
204 struct tipc_bearer *b_ptr; 204 struct tipc_bearer *b;
205 205
206 rcu_read_lock(); 206 rcu_read_lock();
207 b_ptr = rcu_dereference_rtnl(tn->bearer_list[bearer_id]); 207 b = rcu_dereference_rtnl(tn->bearer_list[bearer_id]);
208 if (b_ptr) 208 if (b)
209 tipc_disc_remove_dest(b_ptr->link_req); 209 tipc_disc_remove_dest(b->link_req);
210 rcu_read_unlock(); 210 rcu_read_unlock();
211} 211}
212 212
@@ -218,8 +218,8 @@ static int tipc_enable_bearer(struct net *net, const char *name,
218 struct nlattr *attr[]) 218 struct nlattr *attr[])
219{ 219{
220 struct tipc_net *tn = net_generic(net, tipc_net_id); 220 struct tipc_net *tn = net_generic(net, tipc_net_id);
221 struct tipc_bearer *b_ptr; 221 struct tipc_bearer *b;
222 struct tipc_media *m_ptr; 222 struct tipc_media *m;
223 struct tipc_bearer_names b_names; 223 struct tipc_bearer_names b_names;
224 char addr_string[16]; 224 char addr_string[16];
225 u32 bearer_id; 225 u32 bearer_id;
@@ -255,31 +255,31 @@ static int tipc_enable_bearer(struct net *net, const char *name,
255 return -EINVAL; 255 return -EINVAL;
256 } 256 }
257 257
258 m_ptr = tipc_media_find(b_names.media_name); 258 m = tipc_media_find(b_names.media_name);
259 if (!m_ptr) { 259 if (!m) {
260 pr_warn("Bearer <%s> rejected, media <%s> not registered\n", 260 pr_warn("Bearer <%s> rejected, media <%s> not registered\n",
261 name, b_names.media_name); 261 name, b_names.media_name);
262 return -EINVAL; 262 return -EINVAL;
263 } 263 }
264 264
265 if (priority == TIPC_MEDIA_LINK_PRI) 265 if (priority == TIPC_MEDIA_LINK_PRI)
266 priority = m_ptr->priority; 266 priority = m->priority;
267 267
268restart: 268restart:
269 bearer_id = MAX_BEARERS; 269 bearer_id = MAX_BEARERS;
270 with_this_prio = 1; 270 with_this_prio = 1;
271 for (i = MAX_BEARERS; i-- != 0; ) { 271 for (i = MAX_BEARERS; i-- != 0; ) {
272 b_ptr = rtnl_dereference(tn->bearer_list[i]); 272 b = rtnl_dereference(tn->bearer_list[i]);
273 if (!b_ptr) { 273 if (!b) {
274 bearer_id = i; 274 bearer_id = i;
275 continue; 275 continue;
276 } 276 }
277 if (!strcmp(name, b_ptr->name)) { 277 if (!strcmp(name, b->name)) {
278 pr_warn("Bearer <%s> rejected, already enabled\n", 278 pr_warn("Bearer <%s> rejected, already enabled\n",
279 name); 279 name);
280 return -EINVAL; 280 return -EINVAL;
281 } 281 }
282 if ((b_ptr->priority == priority) && 282 if ((b->priority == priority) &&
283 (++with_this_prio > 2)) { 283 (++with_this_prio > 2)) {
284 if (priority-- == 0) { 284 if (priority-- == 0) {
285 pr_warn("Bearer <%s> rejected, duplicate priority\n", 285 pr_warn("Bearer <%s> rejected, duplicate priority\n",
@@ -297,35 +297,35 @@ restart:
297 return -EINVAL; 297 return -EINVAL;
298 } 298 }
299 299
300 b_ptr = kzalloc(sizeof(*b_ptr), GFP_ATOMIC); 300 b = kzalloc(sizeof(*b), GFP_ATOMIC);
301 if (!b_ptr) 301 if (!b)
302 return -ENOMEM; 302 return -ENOMEM;
303 303
304 strcpy(b_ptr->name, name); 304 strcpy(b->name, name);
305 b_ptr->media = m_ptr; 305 b->media = m;
306 res = m_ptr->enable_media(net, b_ptr, attr); 306 res = m->enable_media(net, b, attr);
307 if (res) { 307 if (res) {
308 pr_warn("Bearer <%s> rejected, enable failure (%d)\n", 308 pr_warn("Bearer <%s> rejected, enable failure (%d)\n",
309 name, -res); 309 name, -res);
310 return -EINVAL; 310 return -EINVAL;
311 } 311 }
312 312
313 b_ptr->identity = bearer_id; 313 b->identity = bearer_id;
314 b_ptr->tolerance = m_ptr->tolerance; 314 b->tolerance = m->tolerance;
315 b_ptr->window = m_ptr->window; 315 b->window = m->window;
316 b_ptr->domain = disc_domain; 316 b->domain = disc_domain;
317 b_ptr->net_plane = bearer_id + 'A'; 317 b->net_plane = bearer_id + 'A';
318 b_ptr->priority = priority; 318 b->priority = priority;
319 319
320 res = tipc_disc_create(net, b_ptr, &b_ptr->bcast_addr); 320 res = tipc_disc_create(net, b, &b->bcast_addr);
321 if (res) { 321 if (res) {
322 bearer_disable(net, b_ptr); 322 bearer_disable(net, b);
323 pr_warn("Bearer <%s> rejected, discovery object creation failed\n", 323 pr_warn("Bearer <%s> rejected, discovery object creation failed\n",
324 name); 324 name);
325 return -EINVAL; 325 return -EINVAL;
326 } 326 }
327 327
328 rcu_assign_pointer(tn->bearer_list[bearer_id], b_ptr); 328 rcu_assign_pointer(tn->bearer_list[bearer_id], b);
329 329
330 pr_info("Enabled bearer <%s>, discovery domain %s, priority %u\n", 330 pr_info("Enabled bearer <%s>, discovery domain %s, priority %u\n",
331 name, 331 name,
@@ -336,11 +336,11 @@ restart:
336/** 336/**
337 * tipc_reset_bearer - Reset all links established over this bearer 337 * tipc_reset_bearer - Reset all links established over this bearer
338 */ 338 */
339static int tipc_reset_bearer(struct net *net, struct tipc_bearer *b_ptr) 339static int tipc_reset_bearer(struct net *net, struct tipc_bearer *b)
340{ 340{
341 pr_info("Resetting bearer <%s>\n", b_ptr->name); 341 pr_info("Resetting bearer <%s>\n", b->name);
342 tipc_node_delete_links(net, b_ptr->identity); 342 tipc_node_delete_links(net, b->identity);
343 tipc_disc_reset(net, b_ptr); 343 tipc_disc_reset(net, b);
344 return 0; 344 return 0;
345} 345}
346 346
@@ -349,26 +349,26 @@ static int tipc_reset_bearer(struct net *net, struct tipc_bearer *b_ptr)
349 * 349 *
350 * Note: This routine assumes caller holds RTNL lock. 350 * Note: This routine assumes caller holds RTNL lock.
351 */ 351 */
352static void bearer_disable(struct net *net, struct tipc_bearer *b_ptr) 352static void bearer_disable(struct net *net, struct tipc_bearer *b)
353{ 353{
354 struct tipc_net *tn = net_generic(net, tipc_net_id); 354 struct tipc_net *tn = net_generic(net, tipc_net_id);
355 u32 i; 355 u32 i;
356 356
357 pr_info("Disabling bearer <%s>\n", b_ptr->name); 357 pr_info("Disabling bearer <%s>\n", b->name);
358 b_ptr->media->disable_media(b_ptr); 358 b->media->disable_media(b);
359 359
360 tipc_node_delete_links(net, b_ptr->identity); 360 tipc_node_delete_links(net, b->identity);
361 RCU_INIT_POINTER(b_ptr->media_ptr, NULL); 361 RCU_INIT_POINTER(b->media_ptr, NULL);
362 if (b_ptr->link_req) 362 if (b->link_req)
363 tipc_disc_delete(b_ptr->link_req); 363 tipc_disc_delete(b->link_req);
364 364
365 for (i = 0; i < MAX_BEARERS; i++) { 365 for (i = 0; i < MAX_BEARERS; i++) {
366 if (b_ptr == rtnl_dereference(tn->bearer_list[i])) { 366 if (b == rtnl_dereference(tn->bearer_list[i])) {
367 RCU_INIT_POINTER(tn->bearer_list[i], NULL); 367 RCU_INIT_POINTER(tn->bearer_list[i], NULL);
368 break; 368 break;
369 } 369 }
370 } 370 }
371 kfree_rcu(b_ptr, rcu); 371 kfree_rcu(b, rcu);
372} 372}
373 373
374int tipc_enable_l2_media(struct net *net, struct tipc_bearer *b, 374int tipc_enable_l2_media(struct net *net, struct tipc_bearer *b,
@@ -411,7 +411,7 @@ void tipc_disable_l2_media(struct tipc_bearer *b)
411/** 411/**
412 * tipc_l2_send_msg - send a TIPC packet out over an L2 interface 412 * tipc_l2_send_msg - send a TIPC packet out over an L2 interface
413 * @buf: the packet to be sent 413 * @buf: the packet to be sent
414 * @b_ptr: the bearer through which the packet is to be sent 414 * @b: the bearer through which the packet is to be sent
415 * @dest: peer destination address 415 * @dest: peer destination address
416 */ 416 */
417int tipc_l2_send_msg(struct net *net, struct sk_buff *skb, 417int tipc_l2_send_msg(struct net *net, struct sk_buff *skb,
@@ -532,14 +532,14 @@ void tipc_bearer_bc_xmit(struct net *net, u32 bearer_id,
532static int tipc_l2_rcv_msg(struct sk_buff *buf, struct net_device *dev, 532static int tipc_l2_rcv_msg(struct sk_buff *buf, struct net_device *dev,
533 struct packet_type *pt, struct net_device *orig_dev) 533 struct packet_type *pt, struct net_device *orig_dev)
534{ 534{
535 struct tipc_bearer *b_ptr; 535 struct tipc_bearer *b;
536 536
537 rcu_read_lock(); 537 rcu_read_lock();
538 b_ptr = rcu_dereference_rtnl(dev->tipc_ptr); 538 b = rcu_dereference_rtnl(dev->tipc_ptr);
539 if (likely(b_ptr)) { 539 if (likely(b)) {
540 if (likely(buf->pkt_type <= PACKET_BROADCAST)) { 540 if (likely(buf->pkt_type <= PACKET_BROADCAST)) {
541 buf->next = NULL; 541 buf->next = NULL;
542 tipc_rcv(dev_net(dev), buf, b_ptr); 542 tipc_rcv(dev_net(dev), buf, b);
543 rcu_read_unlock(); 543 rcu_read_unlock();
544 return NET_RX_SUCCESS; 544 return NET_RX_SUCCESS;
545 } 545 }
@@ -564,13 +564,13 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,
564{ 564{
565 struct net_device *dev = netdev_notifier_info_to_dev(ptr); 565 struct net_device *dev = netdev_notifier_info_to_dev(ptr);
566 struct net *net = dev_net(dev); 566 struct net *net = dev_net(dev);
567 struct tipc_bearer *b_ptr; 567 struct tipc_bearer *b;
568 568
569 b_ptr = rtnl_dereference(dev->tipc_ptr); 569 b = rtnl_dereference(dev->tipc_ptr);
570 if (!b_ptr) 570 if (!b)
571 return NOTIFY_DONE; 571 return NOTIFY_DONE;
572 572
573 b_ptr->mtu = dev->mtu; 573 b->mtu = dev->mtu;
574 574
575 switch (evt) { 575 switch (evt) {
576 case NETDEV_CHANGE: 576 case NETDEV_CHANGE:
@@ -578,16 +578,16 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,
578 break; 578 break;
579 case NETDEV_GOING_DOWN: 579 case NETDEV_GOING_DOWN:
580 case NETDEV_CHANGEMTU: 580 case NETDEV_CHANGEMTU:
581 tipc_reset_bearer(net, b_ptr); 581 tipc_reset_bearer(net, b);
582 break; 582 break;
583 case NETDEV_CHANGEADDR: 583 case NETDEV_CHANGEADDR:
584 b_ptr->media->raw2addr(b_ptr, &b_ptr->addr, 584 b->media->raw2addr(b, &b->addr,
585 (char *)dev->dev_addr); 585 (char *)dev->dev_addr);
586 tipc_reset_bearer(net, b_ptr); 586 tipc_reset_bearer(net, b);
587 break; 587 break;
588 case NETDEV_UNREGISTER: 588 case NETDEV_UNREGISTER:
589 case NETDEV_CHANGENAME: 589 case NETDEV_CHANGENAME:
590 bearer_disable(dev_net(dev), b_ptr); 590 bearer_disable(dev_net(dev), b);
591 break; 591 break;
592 } 592 }
593 return NOTIFY_OK; 593 return NOTIFY_OK;
@@ -623,13 +623,13 @@ void tipc_bearer_cleanup(void)
623void tipc_bearer_stop(struct net *net) 623void tipc_bearer_stop(struct net *net)
624{ 624{
625 struct tipc_net *tn = net_generic(net, tipc_net_id); 625 struct tipc_net *tn = net_generic(net, tipc_net_id);
626 struct tipc_bearer *b_ptr; 626 struct tipc_bearer *b;
627 u32 i; 627 u32 i;
628 628
629 for (i = 0; i < MAX_BEARERS; i++) { 629 for (i = 0; i < MAX_BEARERS; i++) {
630 b_ptr = rtnl_dereference(tn->bearer_list[i]); 630 b = rtnl_dereference(tn->bearer_list[i]);
631 if (b_ptr) { 631 if (b) {
632 bearer_disable(net, b_ptr); 632 bearer_disable(net, b);
633 tn->bearer_list[i] = NULL; 633 tn->bearer_list[i] = NULL;
634 } 634 }
635 } 635 }
diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h
index 552185bc4773..e31820516774 100644
--- a/net/tipc/bearer.h
+++ b/net/tipc/bearer.h
@@ -103,11 +103,11 @@ struct tipc_bearer;
103 */ 103 */
104struct tipc_media { 104struct tipc_media {
105 int (*send_msg)(struct net *net, struct sk_buff *buf, 105 int (*send_msg)(struct net *net, struct sk_buff *buf,
106 struct tipc_bearer *b_ptr, 106 struct tipc_bearer *b,
107 struct tipc_media_addr *dest); 107 struct tipc_media_addr *dest);
108 int (*enable_media)(struct net *net, struct tipc_bearer *b_ptr, 108 int (*enable_media)(struct net *net, struct tipc_bearer *b,
109 struct nlattr *attr[]); 109 struct nlattr *attr[]);
110 void (*disable_media)(struct tipc_bearer *b_ptr); 110 void (*disable_media)(struct tipc_bearer *b);
111 int (*addr2str)(struct tipc_media_addr *addr, 111 int (*addr2str)(struct tipc_media_addr *addr,
112 char *strbuf, 112 char *strbuf,
113 int bufsz); 113 int bufsz);
@@ -176,7 +176,7 @@ struct tipc_bearer_names {
176 * TIPC routines available to supported media types 176 * TIPC routines available to supported media types
177 */ 177 */
178 178
179void tipc_rcv(struct net *net, struct sk_buff *skb, struct tipc_bearer *b_ptr); 179void tipc_rcv(struct net *net, struct sk_buff *skb, struct tipc_bearer *b);
180 180
181/* 181/*
182 * Routines made available to TIPC by supported media types 182 * Routines made available to TIPC by supported media types
diff --git a/net/tipc/discover.c b/net/tipc/discover.c
index afe8c47c4085..f1e738e80535 100644
--- a/net/tipc/discover.c
+++ b/net/tipc/discover.c
@@ -75,14 +75,14 @@ struct tipc_link_req {
75 * tipc_disc_init_msg - initialize a link setup message 75 * tipc_disc_init_msg - initialize a link setup message
76 * @net: the applicable net namespace 76 * @net: the applicable net namespace
77 * @type: message type (request or response) 77 * @type: message type (request or response)
78 * @b_ptr: ptr to bearer issuing message 78 * @b: ptr to bearer issuing message
79 */ 79 */
80static void tipc_disc_init_msg(struct net *net, struct sk_buff *buf, u32 type, 80static void tipc_disc_init_msg(struct net *net, struct sk_buff *buf, u32 type,
81 struct tipc_bearer *b_ptr) 81 struct tipc_bearer *b)
82{ 82{
83 struct tipc_net *tn = net_generic(net, tipc_net_id); 83 struct tipc_net *tn = net_generic(net, tipc_net_id);
84 struct tipc_msg *msg; 84 struct tipc_msg *msg;
85 u32 dest_domain = b_ptr->domain; 85 u32 dest_domain = b->domain;
86 86
87 msg = buf_msg(buf); 87 msg = buf_msg(buf);
88 tipc_msg_init(tn->own_addr, msg, LINK_CONFIG, type, 88 tipc_msg_init(tn->own_addr, msg, LINK_CONFIG, type,
@@ -92,16 +92,16 @@ static void tipc_disc_init_msg(struct net *net, struct sk_buff *buf, u32 type,
92 msg_set_node_capabilities(msg, TIPC_NODE_CAPABILITIES); 92 msg_set_node_capabilities(msg, TIPC_NODE_CAPABILITIES);
93 msg_set_dest_domain(msg, dest_domain); 93 msg_set_dest_domain(msg, dest_domain);
94 msg_set_bc_netid(msg, tn->net_id); 94 msg_set_bc_netid(msg, tn->net_id);
95 b_ptr->media->addr2msg(msg_media_addr(msg), &b_ptr->addr); 95 b->media->addr2msg(msg_media_addr(msg), &b->addr);
96} 96}
97 97
98/** 98/**
99 * disc_dupl_alert - issue node address duplication alert 99 * disc_dupl_alert - issue node address duplication alert
100 * @b_ptr: pointer to bearer detecting duplication 100 * @b: pointer to bearer detecting duplication
101 * @node_addr: duplicated node address 101 * @node_addr: duplicated node address
102 * @media_addr: media address advertised by duplicated node 102 * @media_addr: media address advertised by duplicated node
103 */ 103 */
104static void disc_dupl_alert(struct tipc_bearer *b_ptr, u32 node_addr, 104static void disc_dupl_alert(struct tipc_bearer *b, u32 node_addr,
105 struct tipc_media_addr *media_addr) 105 struct tipc_media_addr *media_addr)
106{ 106{
107 char node_addr_str[16]; 107 char node_addr_str[16];
@@ -111,7 +111,7 @@ static void disc_dupl_alert(struct tipc_bearer *b_ptr, u32 node_addr,
111 tipc_media_addr_printf(media_addr_str, sizeof(media_addr_str), 111 tipc_media_addr_printf(media_addr_str, sizeof(media_addr_str),
112 media_addr); 112 media_addr);
113 pr_warn("Duplicate %s using %s seen on <%s>\n", node_addr_str, 113 pr_warn("Duplicate %s using %s seen on <%s>\n", node_addr_str,
114 media_addr_str, b_ptr->name); 114 media_addr_str, b->name);
115} 115}
116 116
117/** 117/**
@@ -261,13 +261,13 @@ exit:
261/** 261/**
262 * tipc_disc_create - create object to send periodic link setup requests 262 * tipc_disc_create - create object to send periodic link setup requests
263 * @net: the applicable net namespace 263 * @net: the applicable net namespace
264 * @b_ptr: ptr to bearer issuing requests 264 * @b: ptr to bearer issuing requests
265 * @dest: destination address for request messages 265 * @dest: destination address for request messages
266 * @dest_domain: network domain to which links can be established 266 * @dest_domain: network domain to which links can be established
267 * 267 *
268 * Returns 0 if successful, otherwise -errno. 268 * Returns 0 if successful, otherwise -errno.
269 */ 269 */
270int tipc_disc_create(struct net *net, struct tipc_bearer *b_ptr, 270int tipc_disc_create(struct net *net, struct tipc_bearer *b,
271 struct tipc_media_addr *dest) 271 struct tipc_media_addr *dest)
272{ 272{
273 struct tipc_link_req *req; 273 struct tipc_link_req *req;
@@ -282,17 +282,17 @@ int tipc_disc_create(struct net *net, struct tipc_bearer *b_ptr,
282 return -ENOMEM; 282 return -ENOMEM;
283 } 283 }
284 284
285 tipc_disc_init_msg(net, req->buf, DSC_REQ_MSG, b_ptr); 285 tipc_disc_init_msg(net, req->buf, DSC_REQ_MSG, b);
286 memcpy(&req->dest, dest, sizeof(*dest)); 286 memcpy(&req->dest, dest, sizeof(*dest));
287 req->net = net; 287 req->net = net;
288 req->bearer_id = b_ptr->identity; 288 req->bearer_id = b->identity;
289 req->domain = b_ptr->domain; 289 req->domain = b->domain;
290 req->num_nodes = 0; 290 req->num_nodes = 0;
291 req->timer_intv = TIPC_LINK_REQ_INIT; 291 req->timer_intv = TIPC_LINK_REQ_INIT;
292 spin_lock_init(&req->lock); 292 spin_lock_init(&req->lock);
293 setup_timer(&req->timer, disc_timeout, (unsigned long)req); 293 setup_timer(&req->timer, disc_timeout, (unsigned long)req);
294 mod_timer(&req->timer, jiffies + req->timer_intv); 294 mod_timer(&req->timer, jiffies + req->timer_intv);
295 b_ptr->link_req = req; 295 b->link_req = req;
296 skb = skb_clone(req->buf, GFP_ATOMIC); 296 skb = skb_clone(req->buf, GFP_ATOMIC);
297 if (skb) 297 if (skb)
298 tipc_bearer_xmit_skb(net, req->bearer_id, skb, &req->dest); 298 tipc_bearer_xmit_skb(net, req->bearer_id, skb, &req->dest);
@@ -313,19 +313,19 @@ void tipc_disc_delete(struct tipc_link_req *req)
313/** 313/**
314 * tipc_disc_reset - reset object to send periodic link setup requests 314 * tipc_disc_reset - reset object to send periodic link setup requests
315 * @net: the applicable net namespace 315 * @net: the applicable net namespace
316 * @b_ptr: ptr to bearer issuing requests 316 * @b: ptr to bearer issuing requests
317 * @dest_domain: network domain to which links can be established 317 * @dest_domain: network domain to which links can be established
318 */ 318 */
319void tipc_disc_reset(struct net *net, struct tipc_bearer *b_ptr) 319void tipc_disc_reset(struct net *net, struct tipc_bearer *b)
320{ 320{
321 struct tipc_link_req *req = b_ptr->link_req; 321 struct tipc_link_req *req = b->link_req;
322 struct sk_buff *skb; 322 struct sk_buff *skb;
323 323
324 spin_lock_bh(&req->lock); 324 spin_lock_bh(&req->lock);
325 tipc_disc_init_msg(net, req->buf, DSC_REQ_MSG, b_ptr); 325 tipc_disc_init_msg(net, req->buf, DSC_REQ_MSG, b);
326 req->net = net; 326 req->net = net;
327 req->bearer_id = b_ptr->identity; 327 req->bearer_id = b->identity;
328 req->domain = b_ptr->domain; 328 req->domain = b->domain;
329 req->num_nodes = 0; 329 req->num_nodes = 0;
330 req->timer_intv = TIPC_LINK_REQ_INIT; 330 req->timer_intv = TIPC_LINK_REQ_INIT;
331 mod_timer(&req->timer, jiffies + req->timer_intv); 331 mod_timer(&req->timer, jiffies + req->timer_intv);
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 4380eb119796..b11afe71dfc1 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
@@ -245,7 +245,7 @@ static int tipc_link_proto_rcv(struct tipc_link *l, struct sk_buff *skb,
245static void tipc_link_build_proto_msg(struct tipc_link *l, int mtyp, bool probe, 245static void tipc_link_build_proto_msg(struct tipc_link *l, int mtyp, bool probe,
246 u16 rcvgap, int tolerance, int priority, 246 u16 rcvgap, int tolerance, int priority,
247 struct sk_buff_head *xmitq); 247 struct sk_buff_head *xmitq);
248static void link_print(struct tipc_link *l_ptr, const char *str); 248static void link_print(struct tipc_link *l, const char *str);
249static void tipc_link_build_nack_msg(struct tipc_link *l, 249static void tipc_link_build_nack_msg(struct tipc_link *l,
250 struct sk_buff_head *xmitq); 250 struct sk_buff_head *xmitq);
251static void tipc_link_build_bc_init_msg(struct tipc_link *l, 251static void tipc_link_build_bc_init_msg(struct tipc_link *l,
@@ -1707,7 +1707,7 @@ void tipc_link_set_queue_limits(struct tipc_link *l, u32 win)
1707 1707
1708/** 1708/**
1709 * link_reset_stats - reset link statistics 1709 * link_reset_stats - reset link statistics
1710 * @l_ptr: pointer to link 1710 * @l: pointer to link
1711 */ 1711 */
1712void tipc_link_reset_stats(struct tipc_link *l) 1712void tipc_link_reset_stats(struct tipc_link *l)
1713{ 1713{
diff --git a/net/tipc/link.h b/net/tipc/link.h
index 616fc808f23a..b2ae0f4276af 100644
--- a/net/tipc/link.h
+++ b/net/tipc/link.h
@@ -99,7 +99,7 @@ bool tipc_link_is_synching(struct tipc_link *l);
99bool tipc_link_is_failingover(struct tipc_link *l); 99bool tipc_link_is_failingover(struct tipc_link *l);
100bool tipc_link_is_blocked(struct tipc_link *l); 100bool tipc_link_is_blocked(struct tipc_link *l);
101void tipc_link_set_active(struct tipc_link *l, bool active); 101void tipc_link_set_active(struct tipc_link *l, bool active);
102void tipc_link_reset(struct tipc_link *l_ptr); 102void tipc_link_reset(struct tipc_link *l);
103void tipc_link_reset_stats(struct tipc_link *l); 103void tipc_link_reset_stats(struct tipc_link *l);
104int tipc_link_xmit(struct tipc_link *link, struct sk_buff_head *list, 104int tipc_link_xmit(struct tipc_link *link, struct sk_buff_head *list,
105 struct sk_buff_head *xmitq); 105 struct sk_buff_head *xmitq);
diff --git a/net/tipc/node.c b/net/tipc/node.c
index 82c05e9dd0ee..3f7a4ed71990 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -319,62 +319,62 @@ static void tipc_node_write_unlock(struct tipc_node *n)
319struct tipc_node *tipc_node_create(struct net *net, u32 addr, u16 capabilities) 319struct tipc_node *tipc_node_create(struct net *net, u32 addr, u16 capabilities)
320{ 320{
321 struct tipc_net *tn = net_generic(net, tipc_net_id); 321 struct tipc_net *tn = net_generic(net, tipc_net_id);
322 struct tipc_node *n_ptr, *temp_node; 322 struct tipc_node *n, *temp_node;
323 int i; 323 int i;
324 324
325 spin_lock_bh(&tn->node_list_lock); 325 spin_lock_bh(&tn->node_list_lock);
326 n_ptr = tipc_node_find(net, addr); 326 n = tipc_node_find(net, addr);
327 if (n_ptr) 327 if (n)
328 goto exit; 328 goto exit;
329 n_ptr = kzalloc(sizeof(*n_ptr), GFP_ATOMIC); 329 n = kzalloc(sizeof(*n), GFP_ATOMIC);
330 if (!n_ptr) { 330 if (!n) {
331 pr_warn("Node creation failed, no memory\n"); 331 pr_warn("Node creation failed, no memory\n");
332 goto exit; 332 goto exit;
333 } 333 }
334 n_ptr->addr = addr; 334 n->addr = addr;
335 n_ptr->net = net; 335 n->net = net;
336 n_ptr->capabilities = capabilities; 336 n->capabilities = capabilities;
337 kref_init(&n_ptr->kref); 337 kref_init(&n->kref);
338 rwlock_init(&n_ptr->lock); 338 rwlock_init(&n->lock);
339 INIT_HLIST_NODE(&n_ptr->hash); 339 INIT_HLIST_NODE(&n->hash);
340 INIT_LIST_HEAD(&n_ptr->list); 340 INIT_LIST_HEAD(&n->list);
341 INIT_LIST_HEAD(&n_ptr->publ_list); 341 INIT_LIST_HEAD(&n->publ_list);
342 INIT_LIST_HEAD(&n_ptr->conn_sks); 342 INIT_LIST_HEAD(&n->conn_sks);
343 skb_queue_head_init(&n_ptr->bc_entry.namedq); 343 skb_queue_head_init(&n->bc_entry.namedq);
344 skb_queue_head_init(&n_ptr->bc_entry.inputq1); 344 skb_queue_head_init(&n->bc_entry.inputq1);
345 __skb_queue_head_init(&n_ptr->bc_entry.arrvq); 345 __skb_queue_head_init(&n->bc_entry.arrvq);
346 skb_queue_head_init(&n_ptr->bc_entry.inputq2); 346 skb_queue_head_init(&n->bc_entry.inputq2);
347 for (i = 0; i < MAX_BEARERS; i++) 347 for (i = 0; i < MAX_BEARERS; i++)
348 spin_lock_init(&n_ptr->links[i].lock); 348 spin_lock_init(&n->links[i].lock);
349 hlist_add_head_rcu(&n_ptr->hash, &tn->node_htable[tipc_hashfn(addr)]); 349 hlist_add_head_rcu(&n->hash, &tn->node_htable[tipc_hashfn(addr)]);
350 list_for_each_entry_rcu(temp_node, &tn->node_list, list) { 350 list_for_each_entry_rcu(temp_node, &tn->node_list, list) {
351 if (n_ptr->addr < temp_node->addr) 351 if (n->addr < temp_node->addr)
352 break; 352 break;
353 } 353 }
354 list_add_tail_rcu(&n_ptr->list, &temp_node->list); 354 list_add_tail_rcu(&n->list, &temp_node->list);
355 n_ptr->state = SELF_DOWN_PEER_LEAVING; 355 n->state = SELF_DOWN_PEER_LEAVING;
356 n_ptr->signature = INVALID_NODE_SIG; 356 n->signature = INVALID_NODE_SIG;
357 n_ptr->active_links[0] = INVALID_BEARER_ID; 357 n->active_links[0] = INVALID_BEARER_ID;
358 n_ptr->active_links[1] = INVALID_BEARER_ID; 358 n->active_links[1] = INVALID_BEARER_ID;
359 if (!tipc_link_bc_create(net, tipc_own_addr(net), n_ptr->addr, 359 if (!tipc_link_bc_create(net, tipc_own_addr(net), n->addr,
360 U16_MAX, 360 U16_MAX,
361 tipc_link_window(tipc_bc_sndlink(net)), 361 tipc_link_window(tipc_bc_sndlink(net)),
362 n_ptr->capabilities, 362 n->capabilities,
363 &n_ptr->bc_entry.inputq1, 363 &n->bc_entry.inputq1,
364 &n_ptr->bc_entry.namedq, 364 &n->bc_entry.namedq,
365 tipc_bc_sndlink(net), 365 tipc_bc_sndlink(net),
366 &n_ptr->bc_entry.link)) { 366 &n->bc_entry.link)) {
367 pr_warn("Broadcast rcv link creation failed, no memory\n"); 367 pr_warn("Broadcast rcv link creation failed, no memory\n");
368 kfree(n_ptr); 368 kfree(n);
369 n_ptr = NULL; 369 n = NULL;
370 goto exit; 370 goto exit;
371 } 371 }
372 tipc_node_get(n_ptr); 372 tipc_node_get(n);
373 setup_timer(&n_ptr->timer, tipc_node_timeout, (unsigned long)n_ptr); 373 setup_timer(&n->timer, tipc_node_timeout, (unsigned long)n);
374 n_ptr->keepalive_intv = U32_MAX; 374 n->keepalive_intv = U32_MAX;
375exit: 375exit:
376 spin_unlock_bh(&tn->node_list_lock); 376 spin_unlock_bh(&tn->node_list_lock);
377 return n_ptr; 377 return n;
378} 378}
379 379
380static void tipc_node_calculate_timer(struct tipc_node *n, struct tipc_link *l) 380static void tipc_node_calculate_timer(struct tipc_node *n, struct tipc_link *l)