1 files changed, 16 insertions, 55 deletions

diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index 4bb5c13777f1..0a71a312d0d8 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -115,11 +115,10 @@ static void udp_v6_rehash(struct sock *sk)
         udp_lib_rehash(sk, new_hash);
 }
 
-static inline int compute_score(struct sock *sk, struct net *net,
-                                unsigned short hnum,
-                                const struct in6_addr *saddr, __be16 sport,
-                                const struct in6_addr *daddr, __be16 dport,
-                                int dif)
+static int compute_score(struct sock *sk, struct net *net,
+                         const struct in6_addr *saddr, __be16 sport,
+                         const struct in6_addr *daddr, unsigned short hnum,
+                         int dif)
 {
         int score;
         struct inet_sock *inet;
@@ -162,54 +161,11 @@ static inline int compute_score(struct sock *sk, struct net *net,
         return score;
 }
 
-static inline int compute_score2(struct sock *sk, struct net *net,
-                                 const struct in6_addr *saddr, __be16 sport,
-                                 const struct in6_addr *daddr,
-                                 unsigned short hnum, int dif)
-{
-        int score;
-        struct inet_sock *inet;
-
-        if (!net_eq(sock_net(sk), net) ||
-            udp_sk(sk)->udp_port_hash != hnum ||
-            sk->sk_family != PF_INET6)
-                return -1;
-
-        if (!ipv6_addr_equal(&sk->sk_v6_rcv_saddr, daddr))
-                return -1;
-
-        score = 0;
-        inet = inet_sk(sk);
-
-        if (inet->inet_dport) {
-                if (inet->inet_dport != sport)
-                        return -1;
-                score++;
-        }
-
-        if (!ipv6_addr_any(&sk->sk_v6_daddr)) {
-                if (!ipv6_addr_equal(&sk->sk_v6_daddr, saddr))
-                        return -1;
-                score++;
-        }
-
-        if (sk->sk_bound_dev_if) {
-                if (sk->sk_bound_dev_if != dif)
-                        return -1;
-                score++;
-        }
-
-        if (sk->sk_incoming_cpu == raw_smp_processor_id())
-                score++;
-
-        return score;
-}
-
-/* called with read_rcu_lock() */
+/* called with rcu_read_lock() */
 static struct sock *udp6_lib_lookup2(struct net *net,
                 const struct in6_addr *saddr, __be16 sport,
                 const struct in6_addr *daddr, unsigned int hnum, int dif,
-                struct udp_hslot *hslot2, unsigned int slot2,
+                struct udp_hslot *hslot2,
                 struct sk_buff *skb)
 {
         struct sock *sk, *result;
@@ -219,7 +175,7 @@ static struct sock *udp6_lib_lookup2(struct net *net,
         result = NULL;
         badness = -1;
         udp_portaddr_for_each_entry_rcu(sk, &hslot2->head) {
-                score = compute_score2(sk, net, saddr, sport,
+                score = compute_score(sk, net, saddr, sport,
                                       daddr, hnum, dif);
                 if (score > badness) {
                         reuseport = sk->sk_reuseport;
@@ -268,17 +224,22 @@ struct sock *__udp6_lib_lookup(struct net *net,
 
                 result = udp6_lib_lookup2(net, saddr, sport,
                                           daddr, hnum, dif,
-                                          hslot2, slot2, skb);
+                                          hslot2, skb);
                 if (!result) {
+                        unsigned int old_slot2 = slot2;
                         hash2 = udp6_portaddr_hash(net, &in6addr_any, hnum);
                         slot2 = hash2 & udptable->mask;
+                        /* avoid searching the same slot again. */
+                        if (unlikely(slot2 == old_slot2))
+                                return result;
+
                         hslot2 = &udptable->hash2[slot2];
                         if (hslot->count < hslot2->count)
                                 goto begin;
 
                         result = udp6_lib_lookup2(net, saddr, sport,
-                                                  &in6addr_any, hnum, dif,
-                                                  hslot2, slot2, skb);
+                                                  daddr, hnum, dif,
+                                                  hslot2, skb);
                 }
                 return result;
         }
@@ -286,7 +247,7 @@ begin:
         result = NULL;
         badness = -1;
         sk_for_each_rcu(sk, &hslot->head) {
-                score = compute_score(sk, net, hnum, saddr, sport, daddr, dport, dif);
+                score = compute_score(sk, net, saddr, sport, daddr, hnum, dif);
                 if (score > badness) {
                         reuseport = sk->sk_reuseport;
                         if (reuseport) {