1 files changed, 18 insertions, 36 deletions

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index a2dccfe1acec..7368b57842ea 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1376,7 +1376,7 @@ static void __queue_work(int cpu, struct workqueue_struct *wq,
          * queued or lose PENDING.  Grabbing PENDING and queueing should
          * happen with IRQ disabled.
          */
-        WARN_ON_ONCE(!irqs_disabled());
+        lockdep_assert_irqs_disabled();
 
         debug_work_activate(work);
 
@@ -1493,9 +1493,9 @@ bool queue_work_on(int cpu, struct workqueue_struct *wq,
 }
 EXPORT_SYMBOL(queue_work_on);
 
-void delayed_work_timer_fn(unsigned long __data)
+void delayed_work_timer_fn(struct timer_list *t)
 {
-        struct delayed_work *dwork = (struct delayed_work *)__data;
+        struct delayed_work *dwork = from_timer(dwork, t, timer);
 
         /* should have been called from irqsafe timer with irq already off */
         __queue_work(dwork->cpu, dwork->wq, &dwork->work);
@@ -1509,8 +1509,7 @@ static void __queue_delayed_work(int cpu, struct workqueue_struct *wq,
         struct work_struct *work = &dwork->work;
 
         WARN_ON_ONCE(!wq);
-        WARN_ON_ONCE(timer->function != delayed_work_timer_fn ||
-                     timer->data != (unsigned long)dwork);
+        WARN_ON_ONCE(timer->function != (TIMER_FUNC_TYPE)delayed_work_timer_fn);
         WARN_ON_ONCE(timer_pending(timer));
         WARN_ON_ONCE(!list_empty(&work->entry));
 
@@ -1833,9 +1832,9 @@ static void destroy_worker(struct worker *worker)
         wake_up_process(worker->task);
 }
 
-static void idle_worker_timeout(unsigned long __pool)
+static void idle_worker_timeout(struct timer_list *t)
 {
-        struct worker_pool *pool = (void *)__pool;
+        struct worker_pool *pool = from_timer(pool, t, idle_timer);
 
         spin_lock_irq(&pool->lock);
 
@@ -1881,9 +1880,9 @@ static void send_mayday(struct work_struct *work)
         }
 }
 
-static void pool_mayday_timeout(unsigned long __pool)
+static void pool_mayday_timeout(struct timer_list *t)
 {
-        struct worker_pool *pool = (void *)__pool;
+        struct worker_pool *pool = from_timer(pool, t, mayday_timer);
         struct work_struct *work;
 
         spin_lock_irq(&pool->lock);
@@ -2491,15 +2490,8 @@ static void insert_wq_barrier(struct pool_workqueue *pwq,
         INIT_WORK_ONSTACK(&barr->work, wq_barrier_func);
         __set_bit(WORK_STRUCT_PENDING_BIT, work_data_bits(&barr->work));
 
-        /*
-         * Explicitly init the crosslock for wq_barrier::done, make its lock
-         * key a subkey of the corresponding work. As a result we won't
-         * build a dependency between wq_barrier::done and unrelated work.
-         */
-        lockdep_init_map_crosslock((struct lockdep_map *)&barr->done.map,
-                                   "(complete)wq_barr::done",
-                                   target->lockdep_map.key, 1);
-        __init_completion(&barr->done);
+        init_completion_map(&barr->done, &target->lockdep_map);
+
         barr->task = current;
 
         /*
@@ -2605,16 +2597,13 @@ void flush_workqueue(struct workqueue_struct *wq)
         struct wq_flusher this_flusher = {
                 .list = LIST_HEAD_INIT(this_flusher.list),
                 .flush_color = -1,
-                .done = COMPLETION_INITIALIZER_ONSTACK(this_flusher.done),
+                .done = COMPLETION_INITIALIZER_ONSTACK_MAP(this_flusher.done, wq->lockdep_map),
         };
         int next_color;
 
         if (WARN_ON(!wq_online))
                 return;
 
-        lock_map_acquire(&wq->lockdep_map);
-        lock_map_release(&wq->lockdep_map);
-
         mutex_lock(&wq->mutex);
 
         /*
@@ -2877,9 +2866,6 @@ bool flush_work(struct work_struct *work)
         if (WARN_ON(!wq_online))
                 return false;
 
-        lock_map_acquire(&work->lockdep_map);
-        lock_map_release(&work->lockdep_map);
-
         if (start_flush_work(work, &barr)) {
                 wait_for_completion(&barr.done);
                 destroy_work_on_stack(&barr.work);
@@ -3236,11 +3222,9 @@ static int init_worker_pool(struct worker_pool *pool)
         INIT_LIST_HEAD(&pool->idle_list);
         hash_init(pool->busy_hash);
 
-        setup_deferrable_timer(&pool->idle_timer, idle_worker_timeout,
-                               (unsigned long)pool);
+        timer_setup(&pool->idle_timer, idle_worker_timeout, TIMER_DEFERRABLE);
 
-        setup_timer(&pool->mayday_timer, pool_mayday_timeout,
-                    (unsigned long)pool);
+        timer_setup(&pool->mayday_timer, pool_mayday_timeout, 0);
 
         mutex_init(&pool->attach_mutex);
         INIT_LIST_HEAD(&pool->workers);
@@ -4640,7 +4624,7 @@ static void rebind_workers(struct worker_pool *pool)
                  * concurrency management.  Note that when or whether
                  * @worker clears REBOUND doesn't affect correctness.
                  *
-                 * ACCESS_ONCE() is necessary because @worker->flags may be
+                 * WRITE_ONCE() is necessary because @worker->flags may be
                  * tested without holding any lock in
                  * wq_worker_waking_up().  Without it, NOT_RUNNING test may
                  * fail incorrectly leading to premature concurrency
@@ -4649,7 +4633,7 @@ static void rebind_workers(struct worker_pool *pool)
                 WARN_ON_ONCE(!(worker_flags & WORKER_UNBOUND));
                 worker_flags |= WORKER_REBOUND;
                 worker_flags &= ~WORKER_UNBOUND;
-                ACCESS_ONCE(worker->flags) = worker_flags;
+                WRITE_ONCE(worker->flags, worker_flags);
         }
 
         spin_unlock_irq(&pool->lock);
@@ -5383,11 +5367,8 @@ static void workqueue_sysfs_unregister(struct workqueue_struct *wq)	{ }
  */
 #ifdef CONFIG_WQ_WATCHDOG
 
-static void wq_watchdog_timer_fn(unsigned long data);
-
 static unsigned long wq_watchdog_thresh = 30;
-static struct timer_list wq_watchdog_timer =
-        TIMER_DEFERRED_INITIALIZER(wq_watchdog_timer_fn, 0, 0);
+static struct timer_list wq_watchdog_timer;
 
 static unsigned long wq_watchdog_touched = INITIAL_JIFFIES;
 static DEFINE_PER_CPU(unsigned long, wq_watchdog_touched_cpu) = INITIAL_JIFFIES;
@@ -5401,7 +5382,7 @@ static void wq_watchdog_reset_touched(void)
                 per_cpu(wq_watchdog_touched_cpu, cpu) = jiffies;
 }
 
-static void wq_watchdog_timer_fn(unsigned long data)
+static void wq_watchdog_timer_fn(struct timer_list *unused)
 {
         unsigned long thresh = READ_ONCE(wq_watchdog_thresh) * HZ;
         bool lockup_detected = false;
@@ -5503,6 +5484,7 @@ module_param_cb(watchdog_thresh, &wq_watchdog_thresh_ops, &wq_watchdog_thresh,
 
 static void wq_watchdog_init(void)
 {
+        timer_setup(&wq_watchdog_timer, wq_watchdog_timer_fn, TIMER_DEFERRABLE);
         wq_watchdog_set_thresh(wq_watchdog_thresh);
 }