1 files changed, 15 insertions, 2 deletions

diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c
index 39a019936768..51b56e6d9537 100644
--- a/fs/sysfs/group.c
+++ b/fs/sysfs/group.c
@@ -73,13 +73,26 @@ static int create_files(struct kernfs_node *parent, struct kobject *kobj,
         }
 
         if (grp->bin_attrs) {
-                for (bin_attr = grp->bin_attrs; *bin_attr; bin_attr++) {
+                for (i = 0, bin_attr = grp->bin_attrs; *bin_attr; i++, bin_attr++) {
+                        umode_t mode = (*bin_attr)->attr.mode;
+
                         if (update)
                                 kernfs_remove_by_name(parent,
                                                 (*bin_attr)->attr.name);
+                        if (grp->is_bin_visible) {
+                                mode = grp->is_bin_visible(kobj, *bin_attr, i);
+                                if (!mode)
+                                        continue;
+                        }
+
+                        WARN(mode & ~(SYSFS_PREALLOC | 0664),
+                             "Attribute %s: Invalid permissions 0%o\n",
+                             (*bin_attr)->attr.name, mode);
+
+                        mode &= SYSFS_PREALLOC | 0664;
                         error = sysfs_add_file_mode_ns(parent,
                                         &(*bin_attr)->attr, true,
-                                        (*bin_attr)->attr.mode, NULL);
+                                        mode, NULL);
                         if (error)
                                 break;
                 }