1 files changed, 1 insertions, 3 deletions

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index a7b4b6e10269..5c787647afe2 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3446,7 +3446,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
         unsigned long journal_devnum = 0;
         unsigned long def_mount_opts;
         struct inode *root;
-        char *cp;
         const char *descr;
         int ret = -ENOMEM;
         int blocksize, clustersize;
@@ -3477,8 +3476,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
                         part_stat_read(sb->s_bdev->bd_part, sectors[1]);
 
         /* Cleanup superblock name */
-        for (cp = sb->s_id; (cp = strchr(cp, '/'));)
-                *cp = '!';
+        strreplace(sb->s_id, '/', '!');
 
         /* -EINVAL is default */
         ret = -EINVAL;