aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
Diffstat (limited to 'drivers')
-rw-r--r--drivers/gpu/drm/drm_ioctl.c20
1 files changed, 4 insertions, 16 deletions
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
index d337f161909c..ce8a70875bd5 100644
--- a/drivers/gpu/drm/drm_ioctl.c
+++ b/drivers/gpu/drm/drm_ioctl.c
@@ -508,13 +508,6 @@ int drm_version(struct drm_device *dev, void *data,
508 return err; 508 return err;
509} 509}
510 510
511static inline bool
512drm_render_driver_and_ioctl(const struct drm_device *dev, u32 flags)
513{
514 return drm_core_check_feature(dev, DRIVER_RENDER) &&
515 (flags & DRM_RENDER_ALLOW);
516}
517
518/** 511/**
519 * drm_ioctl_permit - Check ioctl permissions against caller 512 * drm_ioctl_permit - Check ioctl permissions against caller
520 * 513 *
@@ -529,19 +522,14 @@ drm_render_driver_and_ioctl(const struct drm_device *dev, u32 flags)
529 */ 522 */
530int drm_ioctl_permit(u32 flags, struct drm_file *file_priv) 523int drm_ioctl_permit(u32 flags, struct drm_file *file_priv)
531{ 524{
532 const struct drm_device *dev = file_priv->minor->dev;
533
534 /* ROOT_ONLY is only for CAP_SYS_ADMIN */ 525 /* ROOT_ONLY is only for CAP_SYS_ADMIN */
535 if (unlikely((flags & DRM_ROOT_ONLY) && !capable(CAP_SYS_ADMIN))) 526 if (unlikely((flags & DRM_ROOT_ONLY) && !capable(CAP_SYS_ADMIN)))
536 return -EACCES; 527 return -EACCES;
537 528
538 /* AUTH is only for master ... */ 529 /* AUTH is only for authenticated or render client */
539 if (unlikely((flags & DRM_AUTH) && drm_is_primary_client(file_priv))) { 530 if (unlikely((flags & DRM_AUTH) && !drm_is_render_client(file_priv) &&
540 /* authenticated ones, or render capable on DRM_RENDER_ALLOW. */ 531 !file_priv->authenticated))
541 if (!file_priv->authenticated && 532 return -EACCES;
542 !drm_render_driver_and_ioctl(dev, flags))
543 return -EACCES;
544 }
545 533
546 /* MASTER is only for master or control clients */ 534 /* MASTER is only for master or control clients */
547 if (unlikely((flags & DRM_MASTER) && 535 if (unlikely((flags & DRM_MASTER) &&