5 files changed, 25 insertions, 17 deletions

diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c
index faf734ff4cf3..0f6e30e9009d 100644
--- a/drivers/irqchip/irq-bcm7038-l1.c
+++ b/drivers/irqchip/irq-bcm7038-l1.c
@@ -217,6 +217,7 @@ static int bcm7038_l1_set_affinity(struct irq_data *d,
         return 0;
 }
 
+#ifdef CONFIG_SMP
 static void bcm7038_l1_cpu_offline(struct irq_data *d)
 {
         struct cpumask *mask = irq_data_get_affinity_mask(d);
@@ -241,6 +242,7 @@ static void bcm7038_l1_cpu_offline(struct irq_data *d)
         }
         irq_set_affinity_locked(d, &new_affinity, false);
 }
+#endif
 
 static int __init bcm7038_l1_init_one(struct device_node *dn,
                                       unsigned int idx,
@@ -293,7 +295,9 @@ static struct irq_chip bcm7038_l1_irq_chip = {
         .irq_mask               = bcm7038_l1_mask,
         .irq_unmask             = bcm7038_l1_unmask,
         .irq_set_affinity       = bcm7038_l1_set_affinity,
+#ifdef CONFIG_SMP
         .irq_cpu_offline        = bcm7038_l1_cpu_offline,
+#endif
 };
 
 static int bcm7038_l1_map(struct irq_domain *d, unsigned int virq,
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index e214181b77b7..d5912f1ec884 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -861,7 +861,9 @@ static struct irq_chip gic_chip = {
         .irq_set_affinity       = gic_set_affinity,
         .irq_get_irqchip_state  = gic_irq_get_irqchip_state,
         .irq_set_irqchip_state  = gic_irq_set_irqchip_state,
-        .flags                  = IRQCHIP_SET_TYPE_MASKED,
+        .flags                  = IRQCHIP_SET_TYPE_MASKED |
+                                  IRQCHIP_SKIP_SET_WAKE |
+                                  IRQCHIP_MASK_ON_SUSPEND,
 };
 
 static struct irq_chip gic_eoimode1_chip = {
@@ -874,7 +876,9 @@ static struct irq_chip gic_eoimode1_chip = {
         .irq_get_irqchip_state  = gic_irq_get_irqchip_state,
         .irq_set_irqchip_state  = gic_irq_set_irqchip_state,
         .irq_set_vcpu_affinity  = gic_irq_set_vcpu_affinity,
-        .flags                  = IRQCHIP_SET_TYPE_MASKED,
+        .flags                  = IRQCHIP_SET_TYPE_MASKED |
+                                  IRQCHIP_SKIP_SET_WAKE |
+                                  IRQCHIP_MASK_ON_SUSPEND,
 };
 
 #define GIC_ID_NR       (1U << GICD_TYPER_ID_BITS(gic_data.rdists.gicd_typer))
diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
index f6fd57ebe6e6..c19766fe8a1a 100644
--- a/drivers/irqchip/irq-s3c24xx.c
+++ b/drivers/irqchip/irq-s3c24xx.c
@@ -250,7 +250,7 @@ static int s3c_irqext0_type(struct irq_data *data, unsigned int type)
         void __iomem *gpcon_reg;
         unsigned long gpcon_offset, extint_offset;
 
-        if ((data->hwirq >= 0) && (data->hwirq <= 3)) {
+        if (data->hwirq <= 3) {
                 gpcon_reg = S3C2410_GPFCON;
                 extint_reg = S3C24XX_EXTINT0;
                 gpcon_offset = (data->hwirq) * 2;
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index 3df527fcf4e1..0a2088e12d96 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -603,17 +603,24 @@ stm32_exti_host_data *stm32_exti_host_init(const struct stm32_exti_drv_data *dd,
                                         sizeof(struct stm32_exti_chip_data),
                                         GFP_KERNEL);
         if (!host_data->chips_data)
-                return NULL;
+                goto free_host_data;
 
         host_data->base = of_iomap(node, 0);
         if (!host_data->base) {
                 pr_err("%pOF: Unable to map registers\n", node);
-                return NULL;
+                goto free_chips_data;
         }
 
         stm32_host_data = host_data;
 
         return host_data;
+
+free_chips_data:
+        kfree(host_data->chips_data);
+free_host_data:
+        kfree(host_data);
+
+        return NULL;
 }
 
 static struct
@@ -665,10 +672,8 @@ static int __init stm32_exti_init(const struct stm32_exti_drv_data *drv_data,
         struct irq_domain *domain;
 
         host_data = stm32_exti_host_init(drv_data, node);
-        if (!host_data) {
-                ret = -ENOMEM;
-                goto out_free_mem;
-        }
+        if (!host_data)
+                return -ENOMEM;
 
         domain = irq_domain_add_linear(node, drv_data->bank_nr * IRQS_PER_BANK,
                                        &irq_exti_domain_ops, NULL);
@@ -725,7 +730,6 @@ out_free_domain:
         irq_domain_remove(domain);
 out_unmap:
         iounmap(host_data->base);
-out_free_mem:
         kfree(host_data->chips_data);
         kfree(host_data);
         return ret;
@@ -752,10 +756,8 @@ __init stm32_exti_hierarchy_init(const struct stm32_exti_drv_data *drv_data,
         }
 
         host_data = stm32_exti_host_init(drv_data, node);
-        if (!host_data) {
-                ret = -ENOMEM;
-                goto out_free_mem;
-        }
+        if (!host_data)
+                return -ENOMEM;
 
         for (i = 0; i < drv_data->bank_nr; i++)
                 stm32_exti_chip_init(host_data, i, node);
@@ -777,7 +779,6 @@ __init stm32_exti_hierarchy_init(const struct stm32_exti_drv_data *drv_data,
 
 out_unmap:
         iounmap(host_data->base);
-out_free_mem:
         kfree(host_data->chips_data);
         kfree(host_data);
         return ret;
diff --git a/drivers/irqchip/irq-tango.c b/drivers/irqchip/irq-tango.c
index 0c085303a583..580e2d72b9ba 100644
--- a/drivers/irqchip/irq-tango.c
+++ b/drivers/irqchip/irq-tango.c
@@ -205,8 +205,7 @@ static int __init tangox_irq_init(void __iomem *base, struct resource *baseres,
 
         tangox_irq_domain_init(dom);
 
-        irq_set_chained_handler(irq, tangox_irq_handler);
-        irq_set_handler_data(irq, dom);
+        irq_set_chained_handler_and_data(irq, tangox_irq_handler, dom);
 
         return 0;
 }