aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/storage/scsiglue.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/usb/storage/scsiglue.c')
-rw-r--r--drivers/usb/storage/scsiglue.c26
1 files changed, 12 insertions, 14 deletions
diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
index a73ea495d5a7..59190d88fa9f 100644
--- a/drivers/usb/storage/scsiglue.c
+++ b/drivers/usb/storage/scsiglue.c
@@ -65,6 +65,7 @@ static const char* host_info(struct Scsi_Host *host)
65static int slave_alloc (struct scsi_device *sdev) 65static int slave_alloc (struct scsi_device *sdev)
66{ 66{
67 struct us_data *us = host_to_us(sdev->host); 67 struct us_data *us = host_to_us(sdev->host);
68 int maxp;
68 69
69 /* 70 /*
70 * Set the INQUIRY transfer length to 36. We don't use any of 71 * Set the INQUIRY transfer length to 36. We don't use any of
@@ -74,20 +75,17 @@ static int slave_alloc (struct scsi_device *sdev)
74 sdev->inquiry_len = 36; 75 sdev->inquiry_len = 36;
75 76
76 /* 77 /*
77 * USB has unusual DMA-alignment requirements: Although the 78 * USB has unusual scatter-gather requirements: the length of each
78 * starting address of each scatter-gather element doesn't matter, 79 * scatterlist element except the last must be divisible by the
79 * the length of each element except the last must be divisible 80 * Bulk maxpacket value. Fortunately this value is always a
80 * by the Bulk maxpacket value. There's currently no way to 81 * power of 2. Inform the block layer about this requirement.
81 * express this by block-layer constraints, so we'll cop out 82 */
82 * and simply require addresses to be aligned at 512-byte 83 maxp = usb_maxpacket(us->pusb_dev, us->recv_bulk_pipe, 0);
83 * boundaries. This is okay since most block I/O involves 84 blk_queue_virt_boundary(sdev->request_queue, maxp - 1);
84 * hardware sectors that are multiples of 512 bytes in length, 85
85 * and since host controllers up through USB 2.0 have maxpacket 86 /*
86 * values no larger than 512. 87 * Some host controllers may have alignment requirements.
87 * 88 * We'll play it safe by requiring 512-byte alignment always.
88 * But it doesn't suffice for Wireless USB, where Bulk maxpacket
89 * values can be as large as 2048. To make that work properly
90 * will require changes to the block layer.
91 */ 89 */
92 blk_queue_update_dma_alignment(sdev->request_queue, (512 - 1)); 90 blk_queue_update_dma_alignment(sdev->request_queue, (512 - 1));
93 91