1 files changed, 10 insertions, 25 deletions

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 6a4fd00117ca..58f4ba6fe412 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -232,11 +232,11 @@ static inline u32 ufshcd_get_ufs_version(struct ufs_hba *hba)
  *                            the host controller
  * @reg_hcs - host controller status register value
  *
- * Returns 0 if device present, non-zero if no device detected
+ * Returns 1 if device present, 0 if no device detected
  */
 static inline int ufshcd_is_device_present(u32 reg_hcs)
 {
-        return (DEVICE_PRESENT & reg_hcs) ? 0 : -1;
+        return (DEVICE_PRESENT & reg_hcs) ? 1 : 0;
 }
 
 /**
@@ -911,7 +911,7 @@ static int ufshcd_make_hba_operational(struct ufs_hba *hba)
 
         /* check if device present */
         reg = readl((hba->mmio_base + REG_CONTROLLER_STATUS));
-        if (ufshcd_is_device_present(reg)) {
+        if (!ufshcd_is_device_present(reg)) {
                 dev_err(&hba->pdev->dev, "cc: Device not present\n");
                 err = -ENXIO;
                 goto out;
@@ -1163,6 +1163,8 @@ static int ufshcd_task_req_compl(struct ufs_hba *hba, u32 index)
                 if (task_result != UPIU_TASK_MANAGEMENT_FUNC_COMPL &&
                     task_result != UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED)
                         task_result = FAILED;
+                else
+                        task_result = SUCCESS;
         } else {
                 task_result = FAILED;
                 dev_err(&hba->pdev->dev,
@@ -1556,7 +1558,7 @@ ufshcd_issue_tm_cmd(struct ufs_hba *hba,
                 goto out;
         }
         clear_bit(free_slot, &hba->tm_condition);
-        return ufshcd_task_req_compl(hba, free_slot);
+        err = ufshcd_task_req_compl(hba, free_slot);
 out:
         return err;
 }
@@ -1580,7 +1582,7 @@ static int ufshcd_device_reset(struct scsi_cmnd *cmd)
         tag = cmd->request->tag;
 
         err = ufshcd_issue_tm_cmd(hba, &hba->lrb[tag], UFS_LOGICAL_RESET);
-        if (err)
+        if (err == FAILED)
                 goto out;
 
         for (pos = 0; pos < hba->nutrs; pos++) {
@@ -1620,7 +1622,7 @@ static int ufshcd_host_reset(struct scsi_cmnd *cmd)
         if (hba->ufshcd_state == UFSHCD_STATE_RESET)
                 return SUCCESS;
 
-        return (ufshcd_do_reset(hba) == SUCCESS) ? SUCCESS : FAILED;
+        return ufshcd_do_reset(hba);
 }
 
 /**
@@ -1652,7 +1654,7 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
         spin_unlock_irqrestore(host->host_lock, flags);
 
         err = ufshcd_issue_tm_cmd(hba, &hba->lrb[tag], UFS_ABORT_TASK);
-        if (err)
+        if (err == FAILED)
                 goto out;
 
         scsi_dma_unmap(cmd);
@@ -1953,24 +1955,7 @@ static struct pci_driver ufshcd_pci_driver = {
 #endif
 };
 
-/**
- * ufshcd_init - Driver registration routine
- */
-static int __init ufshcd_init(void)
-{
-        return pci_register_driver(&ufshcd_pci_driver);
-}
-module_init(ufshcd_init);
-
-/**
- * ufshcd_exit - Driver exit clean-up routine
- */
-static void __exit ufshcd_exit(void)
-{
-        pci_unregister_driver(&ufshcd_pci_driver);
-}
-module_exit(ufshcd_exit);
-
+module_pci_driver(ufshcd_pci_driver);
 
 MODULE_AUTHOR("Santosh Yaragnavi <santosh.sy@samsung.com>, "
               "Vinayak Holikatti <h.vinayak@samsung.com>");