1 files changed, 9 insertions, 34 deletions

diff --git a/drivers/regulator/as3711-regulator.c b/drivers/regulator/as3711-regulator.c
index 8406cd745da2..c77a58478cca 100644
--- a/drivers/regulator/as3711-regulator.c
+++ b/drivers/regulator/as3711-regulator.c
@@ -117,26 +117,19 @@ static struct regulator_ops as3711_dldo_ops = {
 };
 
 static const struct regulator_linear_range as3711_sd_ranges[] = {
-        { .min_uV = 612500, .max_uV = 1400000,
-          .min_sel = 0x1, .max_sel = 0x40, .uV_step = 12500 },
-        { .min_uV = 1425000, .max_uV = 2600000,
-          .min_sel = 0x41, .max_sel = 0x70, .uV_step = 25000 },
-        { .min_uV = 2650000, .max_uV = 3350000,
-          .min_sel = 0x71, .max_sel = 0x7f, .uV_step = 50000 },
+        REGULATOR_LINEAR_RANGE(612500, 0x1, 0x40, 12500),
+        REGULATOR_LINEAR_RANGE(1425000, 0x41, 0x70, 25000),
+        REGULATOR_LINEAR_RANGE(2650000, 0x71, 0x7f, 50000),
 };
 
 static const struct regulator_linear_range as3711_aldo_ranges[] = {
-        { .min_uV = 1200000, .max_uV = 1950000,
-          .min_sel = 0, .max_sel = 0xf, .uV_step = 50000 },
-        { .min_uV = 1800000, .max_uV = 3300000,
-          .min_sel = 0x10, .max_sel = 0x1f, .uV_step = 100000 },
+        REGULATOR_LINEAR_RANGE(1200000, 0, 0xf, 50000),
+        REGULATOR_LINEAR_RANGE(1800000, 0x10, 0x1f, 100000),
 };
 
 static const struct regulator_linear_range as3711_dldo_ranges[] = {
-        { .min_uV = 900000, .max_uV = 1700000,
-          .min_sel = 0, .max_sel = 0x10, .uV_step = 50000 },
-        { .min_uV = 1750000, .max_uV = 3300000,
-          .min_sel = 0x20, .max_sel = 0x3f, .uV_step = 50000 },
+        REGULATOR_LINEAR_RANGE(900000, 0, 0x10, 50000),
+        REGULATOR_LINEAR_RANGE(1750000, 0x20, 0x3f, 50000),
 };
 
 #define AS3711_REG(_id, _en_reg, _en_bit, _vmask, _vshift, _min_uV, _max_uV, _sfx)      \
@@ -273,33 +266,16 @@ static int as3711_regulator_probe(struct platform_device *pdev)
                 config.regmap = as3711->regmap;
                 config.of_node = of_node[id];
 
-                rdev = regulator_register(&ri->desc, &config);
+                rdev = devm_regulator_register(&pdev->dev, &ri->desc, &config);
                 if (IS_ERR(rdev)) {
                         dev_err(&pdev->dev, "Failed to register regulator %s\n",
                                 ri->desc.name);
-                        ret = PTR_ERR(rdev);
-                        goto eregreg;
+                        return PTR_ERR(rdev);
                 }
                 reg->rdev = rdev;
         }
         platform_set_drvdata(pdev, regs);
         return 0;
-
-eregreg:
-        while (--id >= 0)
-                regulator_unregister(regs[id].rdev);
-
-        return ret;
-}
-
-static int as3711_regulator_remove(struct platform_device *pdev)
-{
-        struct as3711_regulator *regs = platform_get_drvdata(pdev);
-        int id;
-
-        for (id = 0; id < AS3711_REGULATOR_NUM; ++id)
-                regulator_unregister(regs[id].rdev);
-        return 0;
 }
 
 static struct platform_driver as3711_regulator_driver = {
@@ -308,7 +284,6 @@ static struct platform_driver as3711_regulator_driver = {
                 .owner  = THIS_MODULE,
         },
         .probe          = as3711_regulator_probe,
-        .remove         = as3711_regulator_remove,
 };
 
 static int __init as3711_regulator_init(void)