1 files changed, 9 insertions, 14 deletions

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index cd888a47d0fc..925467b31a33 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -801,6 +801,7 @@ static inline void nvme_handle_cqe(struct nvme_queue *nvmeq,
                 return;
         }
 
+        nvmeq->cqe_seen = 1;
         req = blk_mq_tag_to_rq(*nvmeq->tags, cqe->command_id);
         nvme_end_request(req, cqe->status, cqe->result);
 }
@@ -830,10 +831,8 @@ static void nvme_process_cq(struct nvme_queue *nvmeq)
                 consumed++;
         }
 
-        if (consumed) {
+        if (consumed)
                 nvme_ring_cq_doorbell(nvmeq);
-                nvmeq->cqe_seen = 1;
-        }
 }
 
 static irqreturn_t nvme_irq(int irq, void *data)
@@ -1558,11 +1557,9 @@ static inline void nvme_release_cmb(struct nvme_dev *dev)
         if (dev->cmb) {
                 iounmap(dev->cmb);
                 dev->cmb = NULL;
-                if (dev->cmbsz) {
-                        sysfs_remove_file_from_group(&dev->ctrl.device->kobj,
-                                                     &dev_attr_cmb.attr, NULL);
-                        dev->cmbsz = 0;
-                }
+                sysfs_remove_file_from_group(&dev->ctrl.device->kobj,
+                                             &dev_attr_cmb.attr, NULL);
+                dev->cmbsz = 0;
         }
 }
 
@@ -1953,16 +1950,14 @@ static int nvme_pci_enable(struct nvme_dev *dev)
 
         /*
          * CMBs can currently only exist on >=1.2 PCIe devices. We only
-         * populate sysfs if a CMB is implemented. Note that we add the
-         * CMB attribute to the nvme_ctrl kobj which removes the need to remove
-         * it on exit. Since nvme_dev_attrs_group has no name we can pass
-         * NULL as final argument to sysfs_add_file_to_group.
+         * populate sysfs if a CMB is implemented. Since nvme_dev_attrs_group
+         * has no name we can pass NULL as final argument to
+         * sysfs_add_file_to_group.
          */
 
         if (readl(dev->bar + NVME_REG_VS) >= NVME_VS(1, 2, 0)) {
                 dev->cmb = nvme_map_cmb(dev);
-
-                if (dev->cmbsz) {
+                if (dev->cmb) {
                         if (sysfs_add_file_to_group(&dev->ctrl.device->kobj,
                                                     &dev_attr_cmb.attr, NULL))
                                 dev_warn(dev->ctrl.device,