1 files changed, 7 insertions, 15 deletions

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index b52258c327d2..7433bb2e4451 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -181,7 +181,6 @@ struct tun_file {
         struct tun_struct *detached;
         struct ptr_ring tx_ring;
         struct xdp_rxq_info xdp_rxq;
-        int xdp_pending_pkts;
 };
 
 struct tun_flow_entry {
@@ -1643,6 +1642,7 @@ static struct sk_buff *tun_build_skb(struct tun_struct *tun,
         else
                 *skb_xdp = 0;
 
+        preempt_disable();
         rcu_read_lock();
         xdp_prog = rcu_dereference(tun->xdp_prog);
         if (xdp_prog && !*skb_xdp) {
@@ -1662,11 +1662,12 @@ static struct sk_buff *tun_build_skb(struct tun_struct *tun,
                 case XDP_REDIRECT:
                         get_page(alloc_frag->page);
                         alloc_frag->offset += buflen;
-                        ++tfile->xdp_pending_pkts;
                         err = xdp_do_redirect(tun->dev, &xdp, xdp_prog);
+                        xdp_do_flush_map();
                         if (err)
                                 goto err_redirect;
                         rcu_read_unlock();
+                        preempt_enable();
                         return NULL;
                 case XDP_TX:
                         xdp_xmit = true;
@@ -1688,6 +1689,7 @@ static struct sk_buff *tun_build_skb(struct tun_struct *tun,
         skb = build_skb(buf, buflen);
         if (!skb) {
                 rcu_read_unlock();
+                preempt_enable();
                 return ERR_PTR(-ENOMEM);
         }
 
@@ -1700,10 +1702,12 @@ static struct sk_buff *tun_build_skb(struct tun_struct *tun,
                 skb->dev = tun->dev;
                 generic_xdp_tx(skb, xdp_prog);
                 rcu_read_unlock();
+                preempt_enable();
                 return NULL;
         }
 
         rcu_read_unlock();
+        preempt_enable();
 
         return skb;
 
@@ -1711,6 +1715,7 @@ err_redirect:
         put_page(alloc_frag->page);
 err_xdp:
         rcu_read_unlock();
+        preempt_enable();
         this_cpu_inc(tun->pcpu_stats->rx_dropped);
         return NULL;
 }
@@ -1984,11 +1989,6 @@ static ssize_t tun_chr_write_iter(struct kiocb *iocb, struct iov_iter *from)
         result = tun_get_user(tun, tfile, NULL, from,
                               file->f_flags & O_NONBLOCK, false);
 
-        if (tfile->xdp_pending_pkts) {
-                tfile->xdp_pending_pkts = 0;
-                xdp_do_flush_map();
-        }
-
         tun_put(tun);
         return result;
 }
@@ -2325,13 +2325,6 @@ static int tun_sendmsg(struct socket *sock, struct msghdr *m, size_t total_len)
         ret = tun_get_user(tun, tfile, m->msg_control, &m->msg_iter,
                            m->msg_flags & MSG_DONTWAIT,
                            m->msg_flags & MSG_MORE);
-
-        if (tfile->xdp_pending_pkts >= NAPI_POLL_WEIGHT ||
-            !(m->msg_flags & MSG_MORE)) {
-                tfile->xdp_pending_pkts = 0;
-                xdp_do_flush_map();
-        }
-
         tun_put(tun);
         return ret;
 }
@@ -3163,7 +3156,6 @@ static int tun_chr_open(struct inode *inode, struct file * file)
         sock_set_flag(&tfile->sk, SOCK_ZEROCOPY);
 
         memset(&tfile->tx_ring, 0, sizeof(tfile->tx_ring));
-        tfile->xdp_pending_pkts = 0;
 
         return 0;
 }