1 files changed, 42 insertions, 49 deletions

diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index 13749d458a31..d75c7af18a63 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -17,6 +17,8 @@
 #include <linux/mutex.h>
 #include <linux/err.h>
 #include <linux/math64.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
 
 #include <linux/spi/spi.h>
 #include <linux/spi/flash.h>
@@ -24,7 +26,6 @@
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/partitions.h>
 
-
 /*
  * DataFlash is a kind of SPI flash.  Most AT45 chips have two buffers in
  * each chip, which may be used for double buffered I/O; but this driver
@@ -98,6 +99,16 @@ struct dataflash {
         struct mtd_info         mtd;
 };
 
+#ifdef CONFIG_OF
+static const struct of_device_id dataflash_dt_ids[] = {
+        { .compatible = "atmel,at45", },
+        { .compatible = "atmel,dataflash", },
+        { /* sentinel */ }
+};
+#else
+#define dataflash_dt_ids NULL
+#endif
+
 /* ......................................................................... */
 
 /*
@@ -122,7 +133,7 @@ static int dataflash_waitready(struct spi_device *spi)
         for (;;) {
                 status = dataflash_status(spi);
                 if (status < 0) {
-                        DEBUG(MTD_DEBUG_LEVEL1, "%s: status %d?\n",
+                        pr_debug("%s: status %d?\n",
                                         dev_name(&spi->dev), status);
                         status = 0;
                 }
@@ -149,7 +160,7 @@ static int dataflash_erase(struct mtd_info *mtd, struct erase_info *instr)
         uint8_t                 *command;
         uint32_t                rem;
 
-        DEBUG(MTD_DEBUG_LEVEL2, "%s: erase addr=0x%llx len 0x%llx\n",
+        pr_debug("%s: erase addr=0x%llx len 0x%llx\n",
               dev_name(&spi->dev), (long long)instr->addr,
               (long long)instr->len);
 
@@ -187,7 +198,7 @@ static int dataflash_erase(struct mtd_info *mtd, struct erase_info *instr)
                 command[2] = (uint8_t)(pageaddr >> 8);
                 command[3] = 0;
 
-                DEBUG(MTD_DEBUG_LEVEL3, "ERASE %s: (%x) %x %x %x [%i]\n",
+                pr_debug("ERASE %s: (%x) %x %x %x [%i]\n",
                         do_block ? "block" : "page",
                         command[0], command[1], command[2], command[3],
                         pageaddr);
@@ -238,8 +249,8 @@ static int dataflash_read(struct mtd_info *mtd, loff_t from, size_t len,
         uint8_t                 *command;
         int                     status;
 
-        DEBUG(MTD_DEBUG_LEVEL2, "%s: read 0x%x..0x%x\n",
-                dev_name(&priv->spi->dev), (unsigned)from, (unsigned)(from + len));
+        pr_debug("%s: read 0x%x..0x%x\n", dev_name(&priv->spi->dev),
+                        (unsigned)from, (unsigned)(from + len));
 
         *retlen = 0;
 
@@ -255,7 +266,7 @@ static int dataflash_read(struct mtd_info *mtd, loff_t from, size_t len,
 
         command = priv->command;
 
-        DEBUG(MTD_DEBUG_LEVEL3, "READ: (%x) %x %x %x\n",
+        pr_debug("READ: (%x) %x %x %x\n",
                 command[0], command[1], command[2], command[3]);
 
         spi_message_init(&msg);
@@ -287,7 +298,7 @@ static int dataflash_read(struct mtd_info *mtd, loff_t from, size_t len,
                 *retlen = msg.actual_length - 8;
                 status = 0;
         } else
-                DEBUG(MTD_DEBUG_LEVEL1, "%s: read %x..%x --> %d\n",
+                pr_debug("%s: read %x..%x --> %d\n",
                         dev_name(&priv->spi->dev),
                         (unsigned)from, (unsigned)(from + len),
                         status);
@@ -314,7 +325,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
         int                     status = -EINVAL;
         uint8_t                 *command;
 
-        DEBUG(MTD_DEBUG_LEVEL2, "%s: write 0x%x..0x%x\n",
+        pr_debug("%s: write 0x%x..0x%x\n",
                 dev_name(&spi->dev), (unsigned)to, (unsigned)(to + len));
 
         *retlen = 0;
@@ -340,7 +351,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
 
         mutex_lock(&priv->lock);
         while (remaining > 0) {
-                DEBUG(MTD_DEBUG_LEVEL3, "write @ %i:%i len=%i\n",
+                pr_debug("write @ %i:%i len=%i\n",
                         pageaddr, offset, writelen);
 
                 /* REVISIT:
@@ -368,12 +379,12 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
                         command[2] = (addr & 0x0000FF00) >> 8;
                         command[3] = 0;
 
-                        DEBUG(MTD_DEBUG_LEVEL3, "TRANSFER: (%x) %x %x %x\n",
+                        pr_debug("TRANSFER: (%x) %x %x %x\n",
                                 command[0], command[1], command[2], command[3]);
 
                         status = spi_sync(spi, &msg);
                         if (status < 0)
-                                DEBUG(MTD_DEBUG_LEVEL1, "%s: xfer %u -> %d \n",
+                                pr_debug("%s: xfer %u -> %d\n",
                                         dev_name(&spi->dev), addr, status);
 
                         (void) dataflash_waitready(priv->spi);
@@ -386,7 +397,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
                 command[2] = (addr & 0x0000FF00) >> 8;
                 command[3] = (addr & 0x000000FF);
 
-                DEBUG(MTD_DEBUG_LEVEL3, "PROGRAM: (%x) %x %x %x\n",
+                pr_debug("PROGRAM: (%x) %x %x %x\n",
                         command[0], command[1], command[2], command[3]);
 
                 x[1].tx_buf = writebuf;
@@ -395,7 +406,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
                 status = spi_sync(spi, &msg);
                 spi_transfer_del(x + 1);
                 if (status < 0)
-                        DEBUG(MTD_DEBUG_LEVEL1, "%s: pgm %u/%u -> %d \n",
+                        pr_debug("%s: pgm %u/%u -> %d\n",
                                 dev_name(&spi->dev), addr, writelen, status);
 
                 (void) dataflash_waitready(priv->spi);
@@ -410,12 +421,12 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
                 command[2] = (addr & 0x0000FF00) >> 8;
                 command[3] = 0;
 
-                DEBUG(MTD_DEBUG_LEVEL3, "COMPARE: (%x) %x %x %x\n",
+                pr_debug("COMPARE: (%x) %x %x %x\n",
                         command[0], command[1], command[2], command[3]);
 
                 status = spi_sync(spi, &msg);
                 if (status < 0)
-                        DEBUG(MTD_DEBUG_LEVEL1, "%s: compare %u -> %d \n",
+                        pr_debug("%s: compare %u -> %d\n",
                                 dev_name(&spi->dev), addr, status);
 
                 status = dataflash_waitready(priv->spi);
@@ -634,11 +645,10 @@ add_dataflash_otp(struct spi_device *spi, char *name,
 {
         struct dataflash                *priv;
         struct mtd_info                 *device;
+        struct mtd_part_parser_data     ppdata;
         struct flash_platform_data      *pdata = spi->dev.platform_data;
         char                            *otp_tag = "";
         int                             err = 0;
-        struct mtd_partition            *parts;
-        int                             nr_parts = 0;
 
         priv = kzalloc(sizeof *priv, GFP_KERNEL);
         if (!priv)
@@ -677,28 +687,11 @@ add_dataflash_otp(struct spi_device *spi, char *name,
                         pagesize, otp_tag);
         dev_set_drvdata(&spi->dev, priv);
 
-        if (mtd_has_cmdlinepart()) {
-                static const char *part_probes[] = { "cmdlinepart", NULL, };
-
-                nr_parts = parse_mtd_partitions(device, part_probes, &parts,
-                                                0);
-        }
+        ppdata.of_node = spi->dev.of_node;
+        err = mtd_device_parse_register(device, NULL, &ppdata,
+                        pdata ? pdata->parts : NULL,
+                        pdata ? pdata->nr_parts : 0);
 
-        if (nr_parts <= 0 && pdata && pdata->parts) {
-                parts = pdata->parts;
-                nr_parts = pdata->nr_parts;
-        }
-
-        if (nr_parts > 0) {
-                priv->partitioned = 1;
-                err = mtd_device_register(device, parts, nr_parts);
-                goto out;
-        }
-
-        if (mtd_device_register(device, NULL, 0) == 1)
-                err = -ENODEV;
-
-out:
         if (!err)
                 return 0;
 
@@ -787,7 +780,7 @@ static struct flash_info *__devinit jedec_probe(struct spi_device *spi)
          */
         tmp = spi_write_then_read(spi, &code, 1, id, 3);
         if (tmp < 0) {
-                DEBUG(MTD_DEBUG_LEVEL0, "%s: error %d reading JEDEC ID\n",
+                pr_debug("%s: error %d reading JEDEC ID\n",
                         dev_name(&spi->dev), tmp);
                 return ERR_PTR(tmp);
         }
@@ -804,7 +797,7 @@ static struct flash_info *__devinit jedec_probe(struct spi_device *spi)
                         tmp < ARRAY_SIZE(dataflash_data);
                         tmp++, info++) {
                 if (info->jedec_id == jedec) {
-                        DEBUG(MTD_DEBUG_LEVEL1, "%s: OTP, sector protect%s\n",
+                        pr_debug("%s: OTP, sector protect%s\n",
                                 dev_name(&spi->dev),
                                 (info->flags & SUP_POW2PS)
                                         ? ", binary pagesize" : ""
@@ -812,8 +805,7 @@ static struct flash_info *__devinit jedec_probe(struct spi_device *spi)
                         if (info->flags & SUP_POW2PS) {
                                 status = dataflash_status(spi);
                                 if (status < 0) {
-                                        DEBUG(MTD_DEBUG_LEVEL1,
-                                                "%s: status error %d\n",
+                                        pr_debug("%s: status error %d\n",
                                                 dev_name(&spi->dev), status);
                                         return ERR_PTR(status);
                                 }
@@ -878,7 +870,7 @@ static int __devinit dataflash_probe(struct spi_device *spi)
          */
         status = dataflash_status(spi);
         if (status <= 0 || status == 0xff) {
-                DEBUG(MTD_DEBUG_LEVEL1, "%s: status error %d\n",
+                pr_debug("%s: status error %d\n",
                                 dev_name(&spi->dev), status);
                 if (status == 0 || status == 0xff)
                         status = -ENODEV;
@@ -914,14 +906,14 @@ static int __devinit dataflash_probe(struct spi_device *spi)
                 break;
         /* obsolete AT45DB1282 not (yet?) supported */
         default:
-                DEBUG(MTD_DEBUG_LEVEL1, "%s: unsupported device (%x)\n",
-                                dev_name(&spi->dev), status & 0x3c);
+                pr_debug("%s: unsupported device (%x)\n", dev_name(&spi->dev),
+                                status & 0x3c);
                 status = -ENODEV;
         }
 
         if (status < 0)
-                DEBUG(MTD_DEBUG_LEVEL1, "%s: add_dataflash --> %d\n",
-                                dev_name(&spi->dev), status);
+                pr_debug("%s: add_dataflash --> %d\n", dev_name(&spi->dev),
+                                status);
 
         return status;
 }
@@ -931,7 +923,7 @@ static int __devexit dataflash_remove(struct spi_device *spi)
         struct dataflash        *flash = dev_get_drvdata(&spi->dev);
         int                     status;
 
-        DEBUG(MTD_DEBUG_LEVEL1, "%s: remove\n", dev_name(&spi->dev));
+        pr_debug("%s: remove\n", dev_name(&spi->dev));
 
         status = mtd_device_unregister(&flash->mtd);
         if (status == 0) {
@@ -946,6 +938,7 @@ static struct spi_driver dataflash_driver = {
                 .name           = "mtd_dataflash",
                 .bus            = &spi_bus_type,
                 .owner          = THIS_MODULE,
+                .of_match_table = dataflash_dt_ids,
         },
 
         .probe          = dataflash_probe,