aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/misc/mei/hw-txe.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/misc/mei/hw-txe.c')
-rw-r--r--drivers/misc/mei/hw-txe.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/misc/mei/hw-txe.c b/drivers/misc/mei/hw-txe.c
index e9f8c0aeec13..24e4a4c96606 100644
--- a/drivers/misc/mei/hw-txe.c
+++ b/drivers/misc/mei/hw-txe.c
@@ -1057,7 +1057,7 @@ irqreturn_t mei_txe_irq_thread_handler(int irq, void *dev_id)
1057{ 1057{
1058 struct mei_device *dev = (struct mei_device *) dev_id; 1058 struct mei_device *dev = (struct mei_device *) dev_id;
1059 struct mei_txe_hw *hw = to_txe_hw(dev); 1059 struct mei_txe_hw *hw = to_txe_hw(dev);
1060 struct mei_cl_cb complete_list; 1060 struct list_head cmpl_list;
1061 s32 slots; 1061 s32 slots;
1062 int rets = 0; 1062 int rets = 0;
1063 1063
@@ -1069,7 +1069,7 @@ irqreturn_t mei_txe_irq_thread_handler(int irq, void *dev_id)
1069 1069
1070 /* initialize our complete list */ 1070 /* initialize our complete list */
1071 mutex_lock(&dev->device_lock); 1071 mutex_lock(&dev->device_lock);
1072 mei_io_list_init(&complete_list); 1072 INIT_LIST_HEAD(&cmpl_list);
1073 1073
1074 if (pci_dev_msi_enabled(to_pci_dev(dev->dev))) 1074 if (pci_dev_msi_enabled(to_pci_dev(dev->dev)))
1075 mei_txe_check_and_ack_intrs(dev, true); 1075 mei_txe_check_and_ack_intrs(dev, true);
@@ -1126,7 +1126,7 @@ irqreturn_t mei_txe_irq_thread_handler(int irq, void *dev_id)
1126 slots = mei_count_full_read_slots(dev); 1126 slots = mei_count_full_read_slots(dev);
1127 if (test_and_clear_bit(TXE_INTR_OUT_DB_BIT, &hw->intr_cause)) { 1127 if (test_and_clear_bit(TXE_INTR_OUT_DB_BIT, &hw->intr_cause)) {
1128 /* Read from TXE */ 1128 /* Read from TXE */
1129 rets = mei_irq_read_handler(dev, &complete_list, &slots); 1129 rets = mei_irq_read_handler(dev, &cmpl_list, &slots);
1130 if (rets && dev->dev_state != MEI_DEV_RESETTING) { 1130 if (rets && dev->dev_state != MEI_DEV_RESETTING) {
1131 dev_err(dev->dev, 1131 dev_err(dev->dev,
1132 "mei_irq_read_handler ret = %d.\n", rets); 1132 "mei_irq_read_handler ret = %d.\n", rets);
@@ -1144,14 +1144,14 @@ irqreturn_t mei_txe_irq_thread_handler(int irq, void *dev_id)
1144 if (hw->aliveness && dev->hbuf_is_ready) { 1144 if (hw->aliveness && dev->hbuf_is_ready) {
1145 /* get the real register value */ 1145 /* get the real register value */
1146 dev->hbuf_is_ready = mei_hbuf_is_ready(dev); 1146 dev->hbuf_is_ready = mei_hbuf_is_ready(dev);
1147 rets = mei_irq_write_handler(dev, &complete_list); 1147 rets = mei_irq_write_handler(dev, &cmpl_list);
1148 if (rets && rets != -EMSGSIZE) 1148 if (rets && rets != -EMSGSIZE)
1149 dev_err(dev->dev, "mei_irq_write_handler ret = %d.\n", 1149 dev_err(dev->dev, "mei_irq_write_handler ret = %d.\n",
1150 rets); 1150 rets);
1151 dev->hbuf_is_ready = mei_hbuf_is_ready(dev); 1151 dev->hbuf_is_ready = mei_hbuf_is_ready(dev);
1152 } 1152 }
1153 1153
1154 mei_irq_compl_handler(dev, &complete_list); 1154 mei_irq_compl_handler(dev, &cmpl_list);
1155 1155
1156end: 1156end:
1157 dev_dbg(dev->dev, "interrupt thread end ret = %d\n", rets); 1157 dev_dbg(dev->dev, "interrupt thread end ret = %d\n", rets);
@@ -1207,8 +1207,8 @@ struct mei_device *mei_txe_dev_init(struct pci_dev *pdev)
1207 struct mei_device *dev; 1207 struct mei_device *dev;
1208 struct mei_txe_hw *hw; 1208 struct mei_txe_hw *hw;
1209 1209
1210 dev = kzalloc(sizeof(struct mei_device) + 1210 dev = devm_kzalloc(&pdev->dev, sizeof(struct mei_device) +
1211 sizeof(struct mei_txe_hw), GFP_KERNEL); 1211 sizeof(struct mei_txe_hw), GFP_KERNEL);
1212 if (!dev) 1212 if (!dev)
1213 return NULL; 1213 return NULL;
1214 1214