1 files changed, 5 insertions, 10 deletions

diff --git a/drivers/media/video/tvp7002.c b/drivers/media/video/tvp7002.c
index b799851bf3d0..7875e80cb2ff 100644
--- a/drivers/media/video/tvp7002.c
+++ b/drivers/media/video/tvp7002.c
@@ -28,6 +28,7 @@
 #include <linux/i2c.h>
 #include <linux/slab.h>
 #include <linux/videodev2.h>
+#include <linux/module.h>
 #include <media/tvp7002.h>
 #include <media/v4l2-device.h>
 #include <media/v4l2-chip-ident.h>
@@ -128,7 +129,7 @@ static const struct i2c_reg_value tvp7002_init_default[] = {
         { TVP7002_ADC_SETUP, 0x50, TVP7002_WRITE },
         { TVP7002_COARSE_CLAMP_CTL, 0x00, TVP7002_WRITE },
         { TVP7002_SOG_CLAMP, 0x80, TVP7002_WRITE },
-        { TVP7002_RGB_COARSE_CLAMP_CTL, 0x00, TVP7002_WRITE },
+        { TVP7002_RGB_COARSE_CLAMP_CTL, 0x8c, TVP7002_WRITE },
         { TVP7002_SOG_COARSE_CLAMP_CTL, 0x04, TVP7002_WRITE },
         { TVP7002_ALC_PLACEMENT, 0x5a, TVP7002_WRITE },
         { 0x32, 0x18, TVP7002_RESERVED },
@@ -182,7 +183,6 @@ static const struct i2c_reg_value tvp7002_parms_480P[] = {
         { TVP7002_HPLL_FDBK_DIV_MSBS, 0x35, TVP7002_WRITE },
         { TVP7002_HPLL_FDBK_DIV_LSBS, 0xa0, TVP7002_WRITE },
         { TVP7002_HPLL_CRTL, 0x02, TVP7002_WRITE },
-        { TVP7002_HPLL_PHASE_SEL, 0x14, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_LSBS, 0x91, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_MSBS, 0x00, TVP7002_WRITE },
         { TVP7002_AVID_STOP_PIXEL_LSBS, 0x0B, TVP7002_WRITE },
@@ -204,7 +204,6 @@ static const struct i2c_reg_value tvp7002_parms_576P[] = {
         { TVP7002_HPLL_FDBK_DIV_MSBS, 0x36, TVP7002_WRITE },
         { TVP7002_HPLL_FDBK_DIV_LSBS, 0x00, TVP7002_WRITE },
         { TVP7002_HPLL_CRTL, 0x18, TVP7002_WRITE },
-        { TVP7002_HPLL_PHASE_SEL, 0x14, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_LSBS, 0x9B, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_MSBS, 0x00, TVP7002_WRITE },
         { TVP7002_AVID_STOP_PIXEL_LSBS, 0x0F, TVP7002_WRITE },
@@ -226,7 +225,6 @@ static const struct i2c_reg_value tvp7002_parms_1080I60[] = {
         { TVP7002_HPLL_FDBK_DIV_MSBS, 0x89, TVP7002_WRITE },
         { TVP7002_HPLL_FDBK_DIV_LSBS, 0x80, TVP7002_WRITE },
         { TVP7002_HPLL_CRTL, 0x98, TVP7002_WRITE },
-        { TVP7002_HPLL_PHASE_SEL, 0x14, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_LSBS, 0x06, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_MSBS, 0x01, TVP7002_WRITE },
         { TVP7002_AVID_STOP_PIXEL_LSBS, 0x8a, TVP7002_WRITE },
@@ -248,7 +246,6 @@ static const struct i2c_reg_value tvp7002_parms_1080P60[] = {
         { TVP7002_HPLL_FDBK_DIV_MSBS, 0x89, TVP7002_WRITE },
         { TVP7002_HPLL_FDBK_DIV_LSBS, 0x80, TVP7002_WRITE },
         { TVP7002_HPLL_CRTL, 0xE0, TVP7002_WRITE },
-        { TVP7002_HPLL_PHASE_SEL, 0x14, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_LSBS, 0x06, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_MSBS, 0x01, TVP7002_WRITE },
         { TVP7002_AVID_STOP_PIXEL_LSBS, 0x8a, TVP7002_WRITE },
@@ -270,7 +267,6 @@ static const struct i2c_reg_value tvp7002_parms_1080I50[] = {
         { TVP7002_HPLL_FDBK_DIV_MSBS, 0xa5, TVP7002_WRITE },
         { TVP7002_HPLL_FDBK_DIV_LSBS, 0x00, TVP7002_WRITE },
         { TVP7002_HPLL_CRTL, 0x98, TVP7002_WRITE },
-        { TVP7002_HPLL_PHASE_SEL, 0x14, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_LSBS, 0x06, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_MSBS, 0x01, TVP7002_WRITE },
         { TVP7002_AVID_STOP_PIXEL_LSBS, 0x8a, TVP7002_WRITE },
@@ -292,7 +288,6 @@ static const struct i2c_reg_value tvp7002_parms_720P60[] = {
         { TVP7002_HPLL_FDBK_DIV_MSBS, 0x67, TVP7002_WRITE },
         { TVP7002_HPLL_FDBK_DIV_LSBS, 0x20, TVP7002_WRITE },
         { TVP7002_HPLL_CRTL, 0xa0, TVP7002_WRITE },
-        { TVP7002_HPLL_PHASE_SEL, 0x16, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_LSBS, 0x47, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_MSBS, 0x01, TVP7002_WRITE },
         { TVP7002_AVID_STOP_PIXEL_LSBS, 0x4B, TVP7002_WRITE },
@@ -314,7 +309,6 @@ static const struct i2c_reg_value tvp7002_parms_720P50[] = {
         { TVP7002_HPLL_FDBK_DIV_MSBS, 0x7b, TVP7002_WRITE },
         { TVP7002_HPLL_FDBK_DIV_LSBS, 0xc0, TVP7002_WRITE },
         { TVP7002_HPLL_CRTL, 0x98, TVP7002_WRITE },
-        { TVP7002_HPLL_PHASE_SEL, 0x16, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_LSBS, 0x47, TVP7002_WRITE },
         { TVP7002_AVID_START_PIXEL_MSBS, 0x01, TVP7002_WRITE },
         { TVP7002_AVID_STOP_PIXEL_LSBS, 0x4B, TVP7002_WRITE },
@@ -687,6 +681,9 @@ static int tvp7002_query_dv_preset(struct v4l2_subdev *sd,
         u8 cpl_msb;
         int index;
 
+        /* Return invalid preset if no active input is detected */
+        qpreset->preset = V4L2_DV_INVALID;
+
         device = to_tvp7002(sd);
 
         /* Read standards from device registers */
@@ -720,8 +717,6 @@ static int tvp7002_query_dv_preset(struct v4l2_subdev *sd,
         if (index == NUM_PRESETS) {
                 v4l2_dbg(1, debug, sd, "detection failed: lpf = %x, cpl = %x\n",
                                                                 lpfr, cpln);
-                /* Could not detect a signal, so return the 'invalid' preset */
-                qpreset->preset = V4L2_DV_INVALID;
                 return 0;
         }