4 files changed, 25 insertions, 8 deletions

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 35ac23768ce9..577d58d1f1a1 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -633,6 +633,7 @@ config I2C_MPC
 config I2C_MT65XX
         tristate "MediaTek I2C adapter"
         depends on ARCH_MEDIATEK || COMPILE_TEST
+        depends on HAS_DMA
         help
           This selects the MediaTek(R) Integrated Inter Circuit bus driver
           for MT65xx and MT81xx.
diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c
index 19b2d689a5ef..f325663c27c5 100644
--- a/drivers/i2c/busses/i2c-jz4780.c
+++ b/drivers/i2c/busses/i2c-jz4780.c
@@ -764,12 +764,15 @@ static int jz4780_i2c_probe(struct platform_device *pdev)
         if (IS_ERR(i2c->clk))
                 return PTR_ERR(i2c->clk);
 
-        clk_prepare_enable(i2c->clk);
+        ret = clk_prepare_enable(i2c->clk);
+        if (ret)
+                return ret;
 
-        if (of_property_read_u32(pdev->dev.of_node, "clock-frequency",
-                                 &clk_freq)) {
+        ret = of_property_read_u32(pdev->dev.of_node, "clock-frequency",
+                                   &clk_freq);
+        if (ret) {
                 dev_err(&pdev->dev, "clock-frequency not specified in DT");
-                return clk_freq;
+                goto err;
         }
 
         i2c->speed = clk_freq / 1000;
@@ -790,10 +793,8 @@ static int jz4780_i2c_probe(struct platform_device *pdev)
         i2c->irq = platform_get_irq(pdev, 0);
         ret = devm_request_irq(&pdev->dev, i2c->irq, jz4780_i2c_irq, 0,
                                dev_name(&pdev->dev), i2c);
-        if (ret) {
-                ret = -ENODEV;
+        if (ret)
                 goto err;
-        }
 
         ret = i2c_add_adapter(&i2c->adap);
         if (ret < 0) {
diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index dcca7076231e..1c9cb65ac4cf 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -419,6 +419,7 @@ static int xgene_slimpro_i2c_probe(struct platform_device *pdev)
         rc = i2c_add_adapter(adapter);
         if (rc) {
                 dev_err(&pdev->dev, "Adapter registeration failed\n");
+                mbox_free_channel(ctx->mbox_chan);
                 return rc;
         }
 
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 069a41f116dd..e6d4935161e4 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1012,6 +1012,8 @@ EXPORT_SYMBOL_GPL(i2c_new_device);
  */
 void i2c_unregister_device(struct i2c_client *client)
 {
+        if (client->dev.of_node)
+                of_node_clear_flag(client->dev.of_node, OF_POPULATED);
         device_unregister(&client->dev);
 }
 EXPORT_SYMBOL_GPL(i2c_unregister_device);
@@ -1320,8 +1322,11 @@ static void of_i2c_register_devices(struct i2c_adapter *adap)
 
         dev_dbg(&adap->dev, "of_i2c: walking child nodes\n");
 
-        for_each_available_child_of_node(adap->dev.of_node, node)
+        for_each_available_child_of_node(adap->dev.of_node, node) {
+                if (of_node_test_and_set_flag(node, OF_POPULATED))
+                        continue;
                 of_i2c_register_device(adap, node);
+        }
 }
 
 static int of_dev_node_match(struct device *dev, void *data)
@@ -1853,6 +1858,11 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action,
                 if (adap == NULL)
                         return NOTIFY_OK;       /* not for us */
 
+                if (of_node_test_and_set_flag(rd->dn, OF_POPULATED)) {
+                        put_device(&adap->dev);
+                        return NOTIFY_OK;
+                }
+
                 client = of_i2c_register_device(adap, rd->dn);
                 put_device(&adap->dev);
 
@@ -1863,6 +1873,10 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action,
                 }
                 break;
         case OF_RECONFIG_CHANGE_REMOVE:
+                /* already depopulated? */
+                if (!of_node_check_flag(rd->dn, OF_POPULATED))
+                        return NOTIFY_OK;
+
                 /* find our device by node */
                 client = of_find_i2c_device_by_node(rd->dn);
                 if (client == NULL)